All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
To: Emil Renner Berthing <emil.renner.berthing@gmail.com>
Cc: michael.opdenacker@rootcommit.com,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Yixun Lan <dlan@gentoo.org>,
	netdev@vger.kernel.org, linux-riscv@lists.infradead.org,
	spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] net: spacemit: compile k1_emac driver as built-in by default
Date: Fri, 17 Oct 2025 15:53:44 +0000 (UTC)	[thread overview]
Message-ID: <63b2056f-3d5a-4fca-8600-526619c33647@rootcommit.com> (raw)
In-Reply-To: <CANBLGcykz77U_V4CqE7PHvtgmeXiKFo0FXy-sHHiAoZ11HnCjw@mail.gmail.com>

Hi Emil

Thanks for the review!

On 10/17/25 17:33, Emil Renner Berthing wrote:
> On Fri, 17 Oct 2025 at 12:03, <michael.opdenacker@rootcommit.com> wrote:
>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>
>> Supports booting boards on NFS filesystems, without going
>> through an initramfs.
> Please don't do this. If we build in every ethernet driver that might
> be used to boot from NFS we'll end up with almost every driver
> built-in and huge kernels. If you need this there is nothing
> preventing you from building the driver in, but please don't bloat
> defconfig kernels for everyone else.

Understood. You have a point. It's not really a problem to customize 
kernel configuration for each board as you said.
So, please forget this particular patch :)
Cheers
Michael.

-- 
Michael Opdenacker
Root Commit
Embedded Linux Training and Consulting
https://rootcommit.com


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
To: Emil Renner Berthing <emil.renner.berthing@gmail.com>
Cc: michael.opdenacker@rootcommit.com,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Yixun Lan <dlan@gentoo.org>,
	netdev@vger.kernel.org, linux-riscv@lists.infradead.org,
	spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] net: spacemit: compile k1_emac driver as built-in by default
Date: Fri, 17 Oct 2025 15:53:44 +0000 (UTC)	[thread overview]
Message-ID: <63b2056f-3d5a-4fca-8600-526619c33647@rootcommit.com> (raw)
In-Reply-To: <CANBLGcykz77U_V4CqE7PHvtgmeXiKFo0FXy-sHHiAoZ11HnCjw@mail.gmail.com>

Hi Emil

Thanks for the review!

On 10/17/25 17:33, Emil Renner Berthing wrote:
> On Fri, 17 Oct 2025 at 12:03, <michael.opdenacker@rootcommit.com> wrote:
>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>
>> Supports booting boards on NFS filesystems, without going
>> through an initramfs.
> Please don't do this. If we build in every ethernet driver that might
> be used to boot from NFS we'll end up with almost every driver
> built-in and huge kernels. If you need this there is nothing
> preventing you from building the driver in, but please don't bloat
> defconfig kernels for everyone else.

Understood. You have a point. It's not really a problem to customize 
kernel configuration for each board as you said.
So, please forget this particular patch :)
Cheers
Michael.

-- 
Michael Opdenacker
Root Commit
Embedded Linux Training and Consulting
https://rootcommit.com


  reply	other threads:[~2025-10-17 15:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-17 10:01 [PATCH 0/2] Add Ethernet and PDMA support to OrangePi RV2 board michael.opdenacker
2025-10-17 10:01 ` michael.opdenacker
2025-10-17 10:02 ` [PATCH 1/2] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2 michael.opdenacker
2025-10-17 10:02   ` michael.opdenacker
2025-10-20  1:00   ` Yixun Lan
2025-10-20  1:00     ` Yixun Lan
2025-10-20  9:07   ` Vivian Wang
2025-10-20  9:07     ` Vivian Wang
2025-10-21  5:39     ` Vivian Wang
2025-10-21  5:39       ` Vivian Wang
2025-10-22 18:54     ` Michael Opdenacker
2025-10-22 18:54       ` Michael Opdenacker
2025-10-17 10:02 ` [PATCH 2/2] net: spacemit: compile k1_emac driver as built-in by default michael.opdenacker
2025-10-17 10:02   ` michael.opdenacker
2025-10-17 15:33   ` Emil Renner Berthing
2025-10-17 15:33     ` Emil Renner Berthing
2025-10-17 15:53     ` Michael Opdenacker [this message]
2025-10-17 15:53       ` Michael Opdenacker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63b2056f-3d5a-4fca-8600-526619c33647@rootcommit.com \
    --to=michael.opdenacker@rootcommit.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dlan@gentoo.org \
    --cc=edumazet@google.com \
    --cc=emil.renner.berthing@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.