All of lore.kernel.org
 help / color / mirror / Atom feed
From: E Shattow <e@freeshell.de>
To: Yixun Lan <dlan@kernel.org>, u-boot@lists.u-boot-project.org
Cc: Yao Zi <me@ziyao.cc>, Tim Ouyang <tim609@andestech.com>,
	Leo Liang <leo.liang@sifive.com>, Tom Rini <trini@konsulko.com>,
	Michal Simek <michal.simek@amd.com>,
	Raymond Mao <raymond.mao@riscstar.com>,
	Hiago De Franco <hfranco@baylibre.com>,
	Junhui Liu <junhui.liu@pigmoral.tech>
Subject: Re: [PATCH v2 2/4] riscv: dts: spacemit: k3: add binman node
Date: Thu, 1 Oct 2026 20:20:29 -0700	[thread overview]
Message-ID: <63b49361-13f7-400b-802a-80b27feb48c2@freeshell.de> (raw)
In-Reply-To: <20261002-00-basic-spacemit-k3-v2-2-fd6779a0317c@kernel.org>

Hi Yixun,

On 10/1/26 18:03, Yixun Lan wrote:
> SpacemiT K3 follow the standard riscv binman layout, which has opensbi
> and U-Boot proper, so include the common binman dtsi file.
> 
> Signed-off-by: Yixun Lan <dlan@kernel.org>
> ---
>  arch/riscv/dts/k3-u-boot.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/riscv/dts/k3-u-boot.dtsi b/arch/riscv/dts/k3-u-boot.dtsi
> new file mode 100644
> index 00000000000..f1c1c3ee6fd
> --- /dev/null
> +++ b/arch/riscv/dts/k3-u-boot.dtsi
> @@ -0,0 +1,6 @@
> +// SPDX-License-Identifier: GPL-2.0+ OR MIT
> +/*
> + * Copyright (C) 2026 Yixun Lan <dlan@kernel.org>
> + */
> +
> +#include "binman.dtsi"
> 

Please rename k3-u-boot.dtsi as similar to the target defconfig (e.g.
spacemit-k3-u-boot.dtsi) while avoiding any matches for the automatic
SOC/CPU/VENDOR inclusion routine of scripts/Makefile.lib:222. Add the
CONFIG_DEVICE_TREE_INCLUDES="spacemit-k3-u-boot.dtsi" board defconfig
option to ensure its inclusion.

The automatic inclusion of per-CPU -u-boot.dtsi does short-circuit any
automatic inclusion of per-target-board -u-boot.dtsi, and so becomes a
blocker in the situation where we would need to override something
per-board on a multi-board capable u-boot target (Pico-ITX, CoM260,
FML13v05, so I think this is likely).

Essentially repeating here my previous advice to Hal about adding a new
multi-board target from
https://lore.kernel.org/u-boot/ff0313ed-5d43-4603-aed4-6e41b2abed37@freeshell.de/

Thanks,

-E

  reply	other threads:[~2026-10-02  3:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02  1:03 [PATCH v2 0/4] riscv: spacemit: Add support for K3 Pico-ITX board Yixun Lan
2026-10-02  1:03 ` [PATCH v2 1/4] board: spacemit: add SpacemiT K3 Pico-ITX Yixun Lan
2026-10-02  7:02   ` E Shattow
2026-10-02 11:43     ` Yixun Lan
2026-10-02  1:03 ` [PATCH v2 2/4] riscv: dts: spacemit: k3: add binman node Yixun Lan
2026-10-02  3:20   ` E Shattow [this message]
2026-10-02  1:03 ` [PATCH v2 3/4] configs: spacemit: Add K3 default configuration Yixun Lan
2026-10-02  1:03 ` [PATCH v2 4/4] doc: spacemit: k3: Add Pico-ITX board Yixun Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63b49361-13f7-400b-802a-80b27feb48c2@freeshell.de \
    --to=e@freeshell.de \
    --cc=dlan@kernel.org \
    --cc=hfranco@baylibre.com \
    --cc=junhui.liu@pigmoral.tech \
    --cc=leo.liang@sifive.com \
    --cc=me@ziyao.cc \
    --cc=michal.simek@amd.com \
    --cc=raymond.mao@riscstar.com \
    --cc=tim609@andestech.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.