All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ira Weiny <ira.weiny@intel.com>
To: "Zhao Liu" <zhao1.liu@linux.intel.com>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Matthew Auld" <matthew.auld@intel.com>,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Nirmoy Das" <nirmoy.das@intel.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	"Christian König" <christian.koenig@amd.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: "Fabio M . De Francesco" <fmdefrancesco@gmail.com>,
	Ira Weiny <ira.weiny@intel.com>, Zhao Liu <zhao1.liu@intel.com>,
	Zhenyu Wang <zhenyu.z.wang@intel.com>
Subject: Re: [Intel-gfx] [PATCH 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page()
Date: Tue, 14 Feb 2023 20:25:08 -0800	[thread overview]
Message-ID: <63ec5ea4d162d_18bf5929443@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20221017093726.2070674-1-zhao1.liu@linux.intel.com>

Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
> 
> The use of kmap_atomic() is being deprecated in favor of
> kmap_local_page()[1].

Zhao,

Was there ever a v2 of this series?  I'm not finding it on Lore.

Thanks,
Ira

> 
> In the following patches, we can convert the calls of kmap_atomic() /
> kunmap_atomic() to kmap_local_page() / kunmap_local(), which can
> instead do the mapping / unmapping regardless of the context.
> 
> With kmap_local_page(), the mapping is per thread, CPU local and not
> globally visible.
> 
> [1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.weiny@intel.com
> ---
> Zhao Liu (9):
>   drm/i915: Use kmap_local_page() in gem/i915_gem_object.c
>   drm/i915: Use kmap_local_page() in gem/i915_gem_pyhs.c
>   drm/i915: Use kmap_local_page() in gem/i915_gem_shmem.c
>   drm/i915: Use kmap_local_page() in gem/selftests/huge_pages.c
>   drm/i915: Use kmap_local_page() in gem/selftests/i915_gem_coherency.c
>   drm/i915: Use kmap_local_page() in gem/selftests/i915_gem_context.c
>   drm/i915: Use memcpy_from_page() in gt/uc/intel_uc_fw.c
>   drm/i915: Use kmap_local_page() in i915_cmd_parser.c
>   drm/i915: Use kmap_local_page() in gem/i915_gem_execbuffer.c
> 
>  drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c       | 10 +++++-----
>  drivers/gpu/drm/i915/gem/i915_gem_object.c           |  8 +++-----
>  drivers/gpu/drm/i915/gem/i915_gem_phys.c             |  8 ++++----
>  drivers/gpu/drm/i915/gem/i915_gem_shmem.c            |  6 ++++--
>  drivers/gpu/drm/i915/gem/selftests/huge_pages.c      |  6 +++---
>  .../gpu/drm/i915/gem/selftests/i915_gem_coherency.c  | 12 ++++--------
>  .../gpu/drm/i915/gem/selftests/i915_gem_context.c    |  8 ++++----
>  drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c             |  5 +----
>  drivers/gpu/drm/i915/i915_cmd_parser.c               |  4 ++--
>  9 files changed, 30 insertions(+), 37 deletions(-)
> 
> -- 
> 2.34.1
> 



WARNING: multiple messages have this Message-ID (diff)
From: Ira Weiny <ira.weiny@intel.com>
To: "Zhao Liu" <zhao1.liu@linux.intel.com>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Matthew Auld" <matthew.auld@intel.com>,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Nirmoy Das" <nirmoy.das@intel.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	"Christian König" <christian.koenig@amd.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: "Fabio M . De Francesco" <fmdefrancesco@gmail.com>,
	Ira Weiny <ira.weiny@intel.com>, Zhao Liu <zhao1.liu@intel.com>,
	Zhenyu Wang <zhenyu.z.wang@intel.com>
Subject: Re: [PATCH 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page()
Date: Tue, 14 Feb 2023 20:25:08 -0800	[thread overview]
Message-ID: <63ec5ea4d162d_18bf5929443@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20221017093726.2070674-1-zhao1.liu@linux.intel.com>

Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
> 
> The use of kmap_atomic() is being deprecated in favor of
> kmap_local_page()[1].

Zhao,

Was there ever a v2 of this series?  I'm not finding it on Lore.

Thanks,
Ira

> 
> In the following patches, we can convert the calls of kmap_atomic() /
> kunmap_atomic() to kmap_local_page() / kunmap_local(), which can
> instead do the mapping / unmapping regardless of the context.
> 
> With kmap_local_page(), the mapping is per thread, CPU local and not
> globally visible.
> 
> [1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.weiny@intel.com
> ---
> Zhao Liu (9):
>   drm/i915: Use kmap_local_page() in gem/i915_gem_object.c
>   drm/i915: Use kmap_local_page() in gem/i915_gem_pyhs.c
>   drm/i915: Use kmap_local_page() in gem/i915_gem_shmem.c
>   drm/i915: Use kmap_local_page() in gem/selftests/huge_pages.c
>   drm/i915: Use kmap_local_page() in gem/selftests/i915_gem_coherency.c
>   drm/i915: Use kmap_local_page() in gem/selftests/i915_gem_context.c
>   drm/i915: Use memcpy_from_page() in gt/uc/intel_uc_fw.c
>   drm/i915: Use kmap_local_page() in i915_cmd_parser.c
>   drm/i915: Use kmap_local_page() in gem/i915_gem_execbuffer.c
> 
>  drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c       | 10 +++++-----
>  drivers/gpu/drm/i915/gem/i915_gem_object.c           |  8 +++-----
>  drivers/gpu/drm/i915/gem/i915_gem_phys.c             |  8 ++++----
>  drivers/gpu/drm/i915/gem/i915_gem_shmem.c            |  6 ++++--
>  drivers/gpu/drm/i915/gem/selftests/huge_pages.c      |  6 +++---
>  .../gpu/drm/i915/gem/selftests/i915_gem_coherency.c  | 12 ++++--------
>  .../gpu/drm/i915/gem/selftests/i915_gem_context.c    |  8 ++++----
>  drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c             |  5 +----
>  drivers/gpu/drm/i915/i915_cmd_parser.c               |  4 ++--
>  9 files changed, 30 insertions(+), 37 deletions(-)
> 
> -- 
> 2.34.1
> 



WARNING: multiple messages have this Message-ID (diff)
From: Ira Weiny <ira.weiny@intel.com>
To: "Zhao Liu" <zhao1.liu@linux.intel.com>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Matthew Auld" <matthew.auld@intel.com>,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Nirmoy Das" <nirmoy.das@intel.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	"Christian König" <christian.koenig@amd.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: Ira Weiny <ira.weiny@intel.com>,
	"Fabio M . De Francesco" <fmdefrancesco@gmail.com>,
	Zhenyu Wang <zhenyu.z.wang@intel.com>,
	Zhao Liu <zhao1.liu@intel.com>
Subject: Re: [PATCH 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page()
Date: Tue, 14 Feb 2023 20:25:08 -0800	[thread overview]
Message-ID: <63ec5ea4d162d_18bf5929443@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20221017093726.2070674-1-zhao1.liu@linux.intel.com>

Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
> 
> The use of kmap_atomic() is being deprecated in favor of
> kmap_local_page()[1].

Zhao,

Was there ever a v2 of this series?  I'm not finding it on Lore.

Thanks,
Ira

> 
> In the following patches, we can convert the calls of kmap_atomic() /
> kunmap_atomic() to kmap_local_page() / kunmap_local(), which can
> instead do the mapping / unmapping regardless of the context.
> 
> With kmap_local_page(), the mapping is per thread, CPU local and not
> globally visible.
> 
> [1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.weiny@intel.com
> ---
> Zhao Liu (9):
>   drm/i915: Use kmap_local_page() in gem/i915_gem_object.c
>   drm/i915: Use kmap_local_page() in gem/i915_gem_pyhs.c
>   drm/i915: Use kmap_local_page() in gem/i915_gem_shmem.c
>   drm/i915: Use kmap_local_page() in gem/selftests/huge_pages.c
>   drm/i915: Use kmap_local_page() in gem/selftests/i915_gem_coherency.c
>   drm/i915: Use kmap_local_page() in gem/selftests/i915_gem_context.c
>   drm/i915: Use memcpy_from_page() in gt/uc/intel_uc_fw.c
>   drm/i915: Use kmap_local_page() in i915_cmd_parser.c
>   drm/i915: Use kmap_local_page() in gem/i915_gem_execbuffer.c
> 
>  drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c       | 10 +++++-----
>  drivers/gpu/drm/i915/gem/i915_gem_object.c           |  8 +++-----
>  drivers/gpu/drm/i915/gem/i915_gem_phys.c             |  8 ++++----
>  drivers/gpu/drm/i915/gem/i915_gem_shmem.c            |  6 ++++--
>  drivers/gpu/drm/i915/gem/selftests/huge_pages.c      |  6 +++---
>  .../gpu/drm/i915/gem/selftests/i915_gem_coherency.c  | 12 ++++--------
>  .../gpu/drm/i915/gem/selftests/i915_gem_context.c    |  8 ++++----
>  drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c             |  5 +----
>  drivers/gpu/drm/i915/i915_cmd_parser.c               |  4 ++--
>  9 files changed, 30 insertions(+), 37 deletions(-)
> 
> -- 
> 2.34.1
> 



  parent reply	other threads:[~2023-02-15  4:25 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17  9:37 [Intel-gfx] [PATCH 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page() Zhao Liu
2022-10-17  9:37 ` Zhao Liu
2022-10-17  9:37 ` Zhao Liu
2022-10-17  9:37 ` [Intel-gfx] [PATCH 1/9] drm/i915: Use kmap_local_page() in gem/i915_gem_object.c Zhao Liu
2022-10-17  9:37   ` Zhao Liu
2022-10-17  9:37   ` Zhao Liu
2022-10-29 11:17   ` [Intel-gfx] " Fabio M. De Francesco
2022-10-29 11:17     ` Fabio M. De Francesco
2022-10-29 11:17     ` Fabio M. De Francesco
2022-11-03 16:51     ` [Intel-gfx] " Ira Weiny
2022-11-03 16:51       ` Ira Weiny
2022-11-03 16:51       ` Ira Weiny
2022-11-03 19:22       ` [Intel-gfx] " Fabio M. De Francesco
2022-11-03 19:22         ` Fabio M. De Francesco
2022-11-03 19:22         ` Fabio M. De Francesco
2022-11-04 11:44         ` [Intel-gfx] " Zhao Liu
2022-11-04 11:44           ` Zhao Liu
2022-11-04 11:44           ` Zhao Liu
2022-11-04 11:35       ` [Intel-gfx] " Zhao Liu
2022-11-04 11:35         ` Zhao Liu
2022-11-04 11:35         ` Zhao Liu
2022-11-04 11:29     ` [Intel-gfx] " Zhao Liu
2022-11-04 11:29       ` Zhao Liu
2022-11-04 11:29       ` Zhao Liu
2022-10-17  9:37 ` [Intel-gfx] [PATCH 2/9] drm/i915: Use kmap_local_page() in gem/i915_gem_pyhs.c Zhao Liu
2022-10-17  9:37   ` Zhao Liu
2022-10-17  9:37   ` Zhao Liu
2022-10-29 13:32   ` [Intel-gfx] " Fabio M. De Francesco
2022-10-29 13:32     ` Fabio M. De Francesco
2022-10-29 13:32     ` Fabio M. De Francesco
2022-11-04 12:15     ` [Intel-gfx] " Zhao Liu
2022-11-04 12:15       ` Zhao Liu
2022-11-04 12:15       ` Zhao Liu
2022-10-17  9:37 ` [Intel-gfx] [PATCH 3/9] drm/i915: Use kmap_local_page() in gem/i915_gem_shmem.c Zhao Liu
2022-10-17  9:37   ` Zhao Liu
2022-10-17  9:37   ` Zhao Liu
2022-11-03 16:49   ` [Intel-gfx] " Ira Weiny
2022-11-03 16:49     ` Ira Weiny
2022-11-03 16:49     ` Ira Weiny
2022-11-03 22:22   ` [Intel-gfx] " Fabio M. De Francesco
2022-11-03 22:22     ` Fabio M. De Francesco
2022-11-03 22:22     ` Fabio M. De Francesco
2022-10-17  9:37 ` [Intel-gfx] [PATCH 4/9] drm/i915: Use kmap_local_page() in gem/selftests/huge_pages.c Zhao Liu
2022-10-17  9:37   ` Zhao Liu
2022-10-17  9:37   ` Zhao Liu
2022-10-17  9:37 ` [Intel-gfx] [PATCH 5/9] drm/i915: Use kmap_local_page() in gem/selftests/i915_gem_coherency.c Zhao Liu
2022-10-17  9:37   ` Zhao Liu
2022-10-17  9:37   ` Zhao Liu
2022-10-17  9:37 ` [Intel-gfx] [PATCH 6/9] drm/i915: Use kmap_local_page() in gem/selftests/i915_gem_context.c Zhao Liu
2022-10-17  9:37   ` Zhao Liu
2022-10-17  9:37   ` Zhao Liu
2022-10-17  9:37 ` [Intel-gfx] [PATCH 7/9] drm/i915: Use memcpy_from_page() in gt/uc/intel_uc_fw.c Zhao Liu
2022-10-17  9:37   ` Zhao Liu
2022-10-17  9:37   ` Zhao Liu
2022-11-03 19:03   ` [Intel-gfx] " Ira Weiny
2022-11-03 19:03     ` Ira Weiny
2022-11-03 19:03     ` Ira Weiny
2022-10-17  9:37 ` [Intel-gfx] [PATCH 8/9] drm/i915: Use kmap_local_page() in i915_cmd_parser.c Zhao Liu
2022-10-17  9:37   ` Zhao Liu
2022-10-17  9:37   ` Zhao Liu
2022-10-17  9:37 ` [Intel-gfx] [PATCH 9/9] drm/i915: Use kmap_local_page() in gem/i915_gem_execbuffer.c Zhao Liu
2022-10-17  9:37   ` Zhao Liu
2022-10-17  9:37   ` Zhao Liu
2022-10-17  9:37 ` [Intel-gfx] [PATCH v3] x86/hyperv: Replace kmap() with kmap_local_page() Zhao Liu
2022-10-17  9:37   ` Zhao Liu
2022-10-17  9:37   ` Zhao Liu
2022-10-17  9:53   ` [Intel-gfx] " Zhao Liu
2022-10-17  9:53     ` Zhao Liu
2022-10-17  9:53     ` Zhao Liu
2022-10-17 11:36 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-10-17 11:36 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-10-17 11:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-10-17 16:35 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-10-29  7:12 ` [Intel-gfx] [PATCH 0/9] drm/i915: Replace kmap_atomic() " Fabio M. De Francesco
2022-10-29  7:12   ` Fabio M. De Francesco
2022-10-29  7:12   ` Fabio M. De Francesco
2022-11-04 10:44   ` [Intel-gfx] " Zhao Liu
2022-11-04 10:44     ` Zhao Liu
2022-11-04 10:44     ` Zhao Liu
2023-02-15  4:25 ` Ira Weiny [this message]
2023-02-15  4:25   ` Ira Weiny
2023-02-15  4:25   ` Ira Weiny
2023-02-15  7:13   ` [Intel-gfx] " Zhao Liu
2023-02-15  7:13     ` Zhao Liu
2023-02-15  7:13     ` Zhao Liu
2023-02-16 17:24     ` [Intel-gfx] " Ira Weiny
2023-02-16 17:24       ` Ira Weiny
2023-02-16 17:24       ` Ira Weiny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63ec5ea4d162d_18bf5929443@iweiny-mobl.notmuch \
    --to=ira.weiny@intel.com \
    --cc=airlied@gmail.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fmdefrancesco@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthew.auld@intel.com \
    --cc=nirmoy.das@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    --cc=zhao1.liu@intel.com \
    --cc=zhao1.liu@linux.intel.com \
    --cc=zhenyu.z.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.