* [PATCH] xen/cpu-policy: Add an IBRS -> AUTO_IBRS dependency
@ 2023-05-31 15:30 Andrew Cooper
2023-05-31 16:01 ` Alejandro Vallejo
2023-06-01 8:30 ` Jan Beulich
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Cooper @ 2023-05-31 15:30 UTC (permalink / raw)
To: Xen-devel
Cc: Andrew Cooper, Jan Beulich, Roger Pau Monné, Wei Liu,
Alejandro Vallejo
AUTO_IBRS is an extention over regular (AMD) IBRS, and needs hiding if IBRS is
levelled out for any reason.
Fixes: defaf651631a ("x86/hvm: Expose Automatic IBRS to guests")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Alejandro Vallejo <alejandro.vallejo@cloud.com>
This was an oversight of mine when reviewing the aformentioned patch.
---
xen/tools/gen-cpuid.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/tools/gen-cpuid.py b/xen/tools/gen-cpuid.py
index f28ff708a2fc..973fcc1c64e8 100755
--- a/xen/tools/gen-cpuid.py
+++ b/xen/tools/gen-cpuid.py
@@ -319,7 +319,7 @@ def crunch_numbers(state):
# as dependent features simplifies Xen's logic, and prevents the guest
# from seeing implausible configurations.
IBRSB: [STIBP, SSBD, INTEL_PSFD],
- IBRS: [AMD_STIBP, AMD_SSBD, PSFD,
+ IBRS: [AMD_STIBP, AMD_SSBD, PSFD, AUTO_IBRS,
IBRS_ALWAYS, IBRS_FAST, IBRS_SAME_MODE],
AMD_STIBP: [STIBP_ALWAYS],
base-commit: 465217b0f872602b4084a1b0fa2ef75377cb3589
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/cpu-policy: Add an IBRS -> AUTO_IBRS dependency
2023-05-31 15:30 [PATCH] xen/cpu-policy: Add an IBRS -> AUTO_IBRS dependency Andrew Cooper
@ 2023-05-31 16:01 ` Alejandro Vallejo
2023-06-01 8:30 ` Jan Beulich
1 sibling, 0 replies; 3+ messages in thread
From: Alejandro Vallejo @ 2023-05-31 16:01 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Xen-devel, Jan Beulich, Roger Pau Monné, Wei Liu
On Wed, May 31, 2023 at 04:30:28PM +0100, Andrew Cooper wrote:
> AUTO_IBRS is an extention over regular (AMD) IBRS, and needs hiding if IBRS is
> levelled out for any reason.
True that. My bad.
> ---
> xen/tools/gen-cpuid.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/tools/gen-cpuid.py b/xen/tools/gen-cpuid.py
> index f28ff708a2fc..973fcc1c64e8 100755
> --- a/xen/tools/gen-cpuid.py
> +++ b/xen/tools/gen-cpuid.py
> @@ -319,7 +319,7 @@ def crunch_numbers(state):
> # as dependent features simplifies Xen's logic, and prevents the guest
> # from seeing implausible configurations.
> IBRSB: [STIBP, SSBD, INTEL_PSFD],
> - IBRS: [AMD_STIBP, AMD_SSBD, PSFD,
> + IBRS: [AMD_STIBP, AMD_SSBD, PSFD, AUTO_IBRS,
> IBRS_ALWAYS, IBRS_FAST, IBRS_SAME_MODE],
> AMD_STIBP: [STIBP_ALWAYS],
>
>
> base-commit: 465217b0f872602b4084a1b0fa2ef75377cb3589
> --
> 2.30.2
>
LGTM
Alejandro
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/cpu-policy: Add an IBRS -> AUTO_IBRS dependency
2023-05-31 15:30 [PATCH] xen/cpu-policy: Add an IBRS -> AUTO_IBRS dependency Andrew Cooper
2023-05-31 16:01 ` Alejandro Vallejo
@ 2023-06-01 8:30 ` Jan Beulich
1 sibling, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2023-06-01 8:30 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Roger Pau Monné, Wei Liu, Alejandro Vallejo, Xen-devel
On 31.05.2023 17:30, Andrew Cooper wrote:
> AUTO_IBRS is an extention over regular (AMD) IBRS, and needs hiding if IBRS is
> levelled out for any reason.
>
> Fixes: defaf651631a ("x86/hvm: Expose Automatic IBRS to guests")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-01 8:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-31 15:30 [PATCH] xen/cpu-policy: Add an IBRS -> AUTO_IBRS dependency Andrew Cooper
2023-05-31 16:01 ` Alejandro Vallejo
2023-06-01 8:30 ` Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.