From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Samuel Holland <samuel@sholland.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Maxime Ripard <mripard@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v3 1/4] regulator: dt-bindings: Add Allwinner D1 LDOs
Date: Wed, 17 Aug 2022 16:46:11 +0300 [thread overview]
Message-ID: <64913eef-8b4f-7617-578b-53ddc22bd06e@linaro.org> (raw)
In-Reply-To: <03de0f7b-9251-a5c0-91a1-5f2b5d41d8a0@sholland.org>
On 17/08/2022 11:15, Samuel Holland wrote:
>>> + audio-codec@2030000 {
>>> + compatible = "simple-mfd", "syscon";
>>
>> This cannot be on its own. Both require device specific compatible.
>
> Again, the device-specific compatible does not exist, because the binding for
> the audio codec has not been written (and it will be quite nontrivial).
>
> So I can:
> 1) Leave the example as-is until the audio codec binding gets written,
> and fill in the specific compatible at that time.
> 2) Remove the example, with the reasoning that the example really
> belongs with the MFD parent (like for the other regulator). Then
> there will be no example until the audio codec binding is written.
> 3) Drop the analog LDOs from this series entirely, and some parts
> of the SoC (like thermal monitoring) cannot be added to the DTSI
> until the audio codec binding is written.
>
> What do you think?
>
> The same question applies for the D1 SoC DTSI, where I use this same construct.
>
> (And technically this does validate with the current schema.)
BTW, it validates only because of limitation in DT schema. Such
combination is not allowed and I wonder if we can make the schema
stricter...
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Samuel Holland <samuel@sholland.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Maxime Ripard <mripard@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v3 1/4] regulator: dt-bindings: Add Allwinner D1 LDOs
Date: Wed, 17 Aug 2022 16:46:11 +0300 [thread overview]
Message-ID: <64913eef-8b4f-7617-578b-53ddc22bd06e@linaro.org> (raw)
In-Reply-To: <03de0f7b-9251-a5c0-91a1-5f2b5d41d8a0@sholland.org>
On 17/08/2022 11:15, Samuel Holland wrote:
>>> + audio-codec@2030000 {
>>> + compatible = "simple-mfd", "syscon";
>>
>> This cannot be on its own. Both require device specific compatible.
>
> Again, the device-specific compatible does not exist, because the binding for
> the audio codec has not been written (and it will be quite nontrivial).
>
> So I can:
> 1) Leave the example as-is until the audio codec binding gets written,
> and fill in the specific compatible at that time.
> 2) Remove the example, with the reasoning that the example really
> belongs with the MFD parent (like for the other regulator). Then
> there will be no example until the audio codec binding is written.
> 3) Drop the analog LDOs from this series entirely, and some parts
> of the SoC (like thermal monitoring) cannot be added to the DTSI
> until the audio codec binding is written.
>
> What do you think?
>
> The same question applies for the D1 SoC DTSI, where I use this same construct.
>
> (And technically this does validate with the current schema.)
BTW, it validates only because of limitation in DT schema. Such
combination is not allowed and I wonder if we can make the schema
stricter...
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-17 13:46 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 4:34 [PATCH v3 0/4] regulator: Add support for Allwinner D1 LDOs Samuel Holland
2022-08-15 4:34 ` Samuel Holland
2022-08-15 4:34 ` [PATCH v3 1/4] regulator: dt-bindings: Add " Samuel Holland
2022-08-15 4:34 ` Samuel Holland
2022-08-15 15:32 ` Heiko Stübner
2022-08-15 15:32 ` Heiko Stübner
2022-08-16 10:00 ` Krzysztof Kozlowski
2022-08-16 10:00 ` Krzysztof Kozlowski
2022-08-16 9:55 ` Krzysztof Kozlowski
2022-08-16 9:55 ` Krzysztof Kozlowski
2022-08-17 8:15 ` Samuel Holland
2022-08-17 8:15 ` Samuel Holland
2022-08-17 8:27 ` Krzysztof Kozlowski
2022-08-17 8:27 ` Krzysztof Kozlowski
2022-08-17 8:39 ` Samuel Holland
2022-08-17 8:39 ` Samuel Holland
2022-08-17 8:46 ` Krzysztof Kozlowski
2022-08-17 8:46 ` Krzysztof Kozlowski
2022-08-17 13:46 ` Krzysztof Kozlowski [this message]
2022-08-17 13:46 ` Krzysztof Kozlowski
2022-08-16 9:57 ` Krzysztof Kozlowski
2022-08-16 9:57 ` Krzysztof Kozlowski
2022-08-15 4:34 ` [PATCH v3 2/4] regulator: sun20i: Add support for " Samuel Holland
2022-08-15 4:34 ` Samuel Holland
2022-08-15 17:00 ` Heiko Stübner
2022-08-15 17:00 ` Heiko Stübner
2022-08-17 8:28 ` Samuel Holland
2022-08-17 8:28 ` Samuel Holland
2022-08-17 10:01 ` Heiko Stübner
2022-08-17 10:01 ` Heiko Stübner
2022-08-15 4:34 ` [PATCH v3 3/4] dt-bindings: sram: sunxi-sram: Add optional regulators child Samuel Holland
2022-08-15 4:34 ` Samuel Holland
2022-08-15 14:01 ` Rob Herring
2022-08-15 14:01 ` Rob Herring
2022-08-15 17:02 ` Heiko Stübner
2022-08-15 17:02 ` Heiko Stübner
2022-08-16 9:59 ` Krzysztof Kozlowski
2022-08-16 9:59 ` Krzysztof Kozlowski
2022-08-17 8:47 ` Samuel Holland
2022-08-17 8:47 ` Samuel Holland
2022-08-17 13:22 ` Krzysztof Kozlowski
2022-08-17 13:22 ` Krzysztof Kozlowski
2022-08-15 4:34 ` [PATCH v3 4/4] soc: sunxi: sram: Only iterate over SRAM children Samuel Holland
2022-08-15 4:34 ` Samuel Holland
2022-08-15 17:04 ` Heiko Stübner
2022-08-15 17:04 ` Heiko Stübner
2022-08-16 10:01 ` Krzysztof Kozlowski
2022-08-16 10:01 ` Krzysztof Kozlowski
2022-08-16 10:03 ` Krzysztof Kozlowski
2022-08-16 10:03 ` Krzysztof Kozlowski
2022-08-17 8:50 ` Samuel Holland
2022-08-17 8:50 ` Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64913eef-8b4f-7617-578b-53ddc22bd06e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.