All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kumar Gala <galak@kernel.crashing.org>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 1/2] mpc85xx: Add support for SBC8548
Date: Wed, 12 Dec 2007 22:20:10 -0600	[thread overview]
Message-ID: <64EE8341-7125-4BC3-8F69-F1FC5ABC054F@kernel.crashing.org> (raw)
In-Reply-To: <1197510565.24565.11.camel@server>


Missing updates to MAKEALL

[snip]

> +
> +typedef struct epld_reg {
> +	u_char bd_rev;		/* Board revision */
> +} epld_reg_t;

seems over kill for the one usage below.

>
> +
> +unsigned int get_board_rev(void)
> +{
> +	volatile epld_reg_t *epld = (epld_reg_t *)CFG_BD_REV;
> +
> +	return ((epld->bd_rev) >> 4);
> +}
> +
> +#if defined(CONFIG_OF_BOARD_SETUP)
> +void
> +ft_board_setup(void *blob, bd_t *bd)
> +{
> +	ft_cpu_setup(blob, bd);

PCI of setup code?

>
> +}
> +#endif
> +

- k

  reply	other threads:[~2007-12-13  4:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-13  1:49 [U-Boot-Users] [PATCH 1/2] mpc85xx: Add support for SBC8548 Joe Hamman
2007-12-13  4:20 ` Kumar Gala [this message]
2007-12-13 12:39   ` Joe Hamman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64EE8341-7125-4BC3-8F69-F1FC5ABC054F@kernel.crashing.org \
    --to=galak@kernel.crashing.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.