From: nicolas.ferre@microchip.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pcmcia: at91_cf: Use PTR_ERR_OR_ZERO()
Date: Tue, 28 Nov 2017 16:41:55 +0100 [thread overview]
Message-ID: <64b581c0-059f-bdea-d661-bcbdd8d1d1a4@microchip.com> (raw)
In-Reply-To: <1511882500-7285-1-git-send-email-gomonovych@gmail.com>
On 28/11/2017 at 16:21, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/pcmcia/at91_cf.c:239:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
okay...
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> drivers/pcmcia/at91_cf.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pcmcia/at91_cf.c b/drivers/pcmcia/at91_cf.c
> index 87147bcd1655..7da7b0f0ae1b 100644
> --- a/drivers/pcmcia/at91_cf.c
> +++ b/drivers/pcmcia/at91_cf.c
> @@ -236,10 +236,8 @@ static int at91_cf_dt_init(struct platform_device *pdev)
> pdev->dev.platform_data = board;
>
> mc = syscon_regmap_lookup_by_compatible("atmel,at91rm9200-sdramc");
> - if (IS_ERR(mc))
> - return PTR_ERR(mc);
>
> - return 0;
> + return PTR_ERR_OR_ZERO(mc);
> }
> #else
> static int at91_cf_dt_init(struct platform_device *pdev)
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Vasyl Gomonovych <gomonovych@gmail.com>,
<alexandre.belloni@free-electrons.com>,
<linux-pcmcia@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pcmcia: at91_cf: Use PTR_ERR_OR_ZERO()
Date: Tue, 28 Nov 2017 16:41:55 +0100 [thread overview]
Message-ID: <64b581c0-059f-bdea-d661-bcbdd8d1d1a4@microchip.com> (raw)
In-Reply-To: <1511882500-7285-1-git-send-email-gomonovych@gmail.com>
On 28/11/2017 at 16:21, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/pcmcia/at91_cf.c:239:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
okay...
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> drivers/pcmcia/at91_cf.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pcmcia/at91_cf.c b/drivers/pcmcia/at91_cf.c
> index 87147bcd1655..7da7b0f0ae1b 100644
> --- a/drivers/pcmcia/at91_cf.c
> +++ b/drivers/pcmcia/at91_cf.c
> @@ -236,10 +236,8 @@ static int at91_cf_dt_init(struct platform_device *pdev)
> pdev->dev.platform_data = board;
>
> mc = syscon_regmap_lookup_by_compatible("atmel,at91rm9200-sdramc");
> - if (IS_ERR(mc))
> - return PTR_ERR(mc);
>
> - return 0;
> + return PTR_ERR_OR_ZERO(mc);
> }
> #else
> static int at91_cf_dt_init(struct platform_device *pdev)
>
--
Nicolas Ferre
next prev parent reply other threads:[~2017-11-28 15:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 15:21 [PATCH] pcmcia: at91_cf: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
2017-11-28 15:21 ` Vasyl Gomonovych
2017-11-28 15:41 ` Nicolas Ferre [this message]
2017-11-28 15:41 ` Nicolas Ferre
2017-11-29 20:59 ` Alexandre Belloni
2017-11-29 20:59 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64b581c0-059f-bdea-d661-bcbdd8d1d1a4@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.