From: Christian Marangi <ansuelsmth@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Atin Bainada <hi@atinb.me>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH 3/3] net: dsa: qca8k: limit user ports access to the first CPU port on setup
Date: Thu, 27 Jul 2023 21:10:56 +0200 [thread overview]
Message-ID: <64c2c142.5d0a0220.9ae33.deab@mx.google.com> (raw)
In-Reply-To: <20230726131851.w5ty2mftr7tdl3mi@skbuf>
On Wed, Jul 26, 2023 at 04:18:51PM +0300, Vladimir Oltean wrote:
> On Mon, Jul 24, 2023 at 05:30:58AM +0200, Christian Marangi wrote:
> > In preparation for multi-CPU support, set CPU port LOOKUP MEMBER outside
> > the port loop and setup the LOOKUP MEMBER mask for user ports only to
> > the first CPU port.
> >
> > This is to handle flooding condition where every CPU port is set as
> > target and prevent packet duplication for unknown frames from user ports.
> >
> > Secondary CPU port LOOKUP MEMBER mask will be setup later when
> > port_change_master will be implemented.
> >
> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > ---
>
> This is kinda "net.git" material, in the sense that it fixes the current
> driver behavior with device trees from the future, right?
This is not strictly a fix. The secondary CPU (if defined) doesn't have
flood enabled so the switch won't forward packet. It's more of a
cleanup/preparation from my point of view. What do you think?
--
Ansuel
next prev parent reply other threads:[~2023-07-27 19:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 3:30 [net-next PATCH 1/3] net: dsa: tag_qca: return early if dev is not found Christian Marangi
2023-07-24 3:30 ` [net-next PATCH 2/3] net: dsa: qca8k: make learning configurable and keep off if standalone Christian Marangi
2023-07-26 8:19 ` Simon Horman
2023-07-26 12:14 ` Vladimir Oltean
2023-07-26 13:15 ` Simon Horman
2023-07-26 12:12 ` Vladimir Oltean
2023-07-27 19:05 ` Christian Marangi
2023-07-26 22:22 ` Florian Fainelli
2023-07-24 3:30 ` [net-next PATCH 3/3] net: dsa: qca8k: limit user ports access to the first CPU port on setup Christian Marangi
2023-07-26 8:19 ` Simon Horman
2023-07-26 13:18 ` Vladimir Oltean
2023-07-27 19:10 ` Christian Marangi [this message]
2023-07-27 21:14 ` Vladimir Oltean
2023-07-26 22:21 ` Florian Fainelli
2023-07-27 21:16 ` Vladimir Oltean
2023-07-26 8:17 ` [net-next PATCH 1/3] net: dsa: tag_qca: return early if dev is not found Simon Horman
2023-07-26 12:06 ` Vladimir Oltean
2023-07-26 22:19 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64c2c142.5d0a0220.9ae33.deab@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hi@atinb.me \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.