From: Simon Horman <simon.horman@corigine.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Christian Marangi <ansuelsmth@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Atin Bainada <hi@atinb.me>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH 2/3] net: dsa: qca8k: make learning configurable and keep off if standalone
Date: Wed, 26 Jul 2023 15:15:20 +0200 [thread overview]
Message-ID: <ZMEcaKWzoAvtz+CK@corigine.com> (raw)
In-Reply-To: <20230726121435.stqwc3jzjll222ck@skbuf>
On Wed, Jul 26, 2023 at 03:14:35PM +0300, Vladimir Oltean wrote:
> On Wed, Jul 26, 2023 at 10:19:34AM +0200, Simon Horman wrote:
> > > +int qca8k_port_pre_bridge_flags(struct dsa_switch *ds, int port,
> > > + struct switchdev_brport_flags flags,
> > > + struct netlink_ext_ack *extack)
> > > +{
> > > + if (flags.mask & ~BR_LEARNING)
> > > + return -EINVAL;
> >
> > If I am reading things right then some implementation of this callback
> > return -EINVAL when they see unexpected flags. And some seem not to
> > - possibly because all flags are expected.
> >
> > So I'm slightly unsure if this is correct or not.
>
> Which ones don't? All handlers of SWITCHDEV_ATTR_ID_PORT_PRE_BRIDGE_FLAGS
> should return -EINVAL for changes made to bridge port flags that aren't
> supported.
Sorry, on a second look I see that my statement above is incorrect.
I do wonder what it was I saw this morning. But this afternoon
I see that all users check flags and return -EINVAL as appropriate.
next prev parent reply other threads:[~2023-07-26 13:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 3:30 [net-next PATCH 1/3] net: dsa: tag_qca: return early if dev is not found Christian Marangi
2023-07-24 3:30 ` [net-next PATCH 2/3] net: dsa: qca8k: make learning configurable and keep off if standalone Christian Marangi
2023-07-26 8:19 ` Simon Horman
2023-07-26 12:14 ` Vladimir Oltean
2023-07-26 13:15 ` Simon Horman [this message]
2023-07-26 12:12 ` Vladimir Oltean
2023-07-27 19:05 ` Christian Marangi
2023-07-26 22:22 ` Florian Fainelli
2023-07-24 3:30 ` [net-next PATCH 3/3] net: dsa: qca8k: limit user ports access to the first CPU port on setup Christian Marangi
2023-07-26 8:19 ` Simon Horman
2023-07-26 13:18 ` Vladimir Oltean
2023-07-27 19:10 ` Christian Marangi
2023-07-27 21:14 ` Vladimir Oltean
2023-07-26 22:21 ` Florian Fainelli
2023-07-27 21:16 ` Vladimir Oltean
2023-07-26 8:17 ` [net-next PATCH 1/3] net: dsa: tag_qca: return early if dev is not found Simon Horman
2023-07-26 12:06 ` Vladimir Oltean
2023-07-26 22:19 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMEcaKWzoAvtz+CK@corigine.com \
--to=simon.horman@corigine.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hi@atinb.me \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.