From: Haipeng Lin <jimmie.lin@gmail.com>
To: Val Packett <val@packett.cool>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: "Maximilian Luz" <luzmaximilian@gmail.com>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org
Subject: Re: [PATCH 2/5] arm64: dts: qcom: sc8180x: Add Microsoft Surface Pro X
Date: Sat, 14 Nov 2026 22:16:23 -0500 [thread overview]
Message-ID: <64e7afd3-50e5-4134-9bf6-92c4aa740bd7@gmail.com> (raw)
In-Reply-To: <20261104070441.74127-3-val@packett.cool>
On 11/4/26 2:04 AM, Val Packett wrote:
> From: Maximilian Luz <luzmaximilian@gmail.com>
>
> Introduce a device tree for the Surface Pro X tablet in all 3 variants
> (SQ1 with cellular, SQ1 Wi-Fi only, SQ2 with cellular).
[...]
I believe there is also a Wi-Fi only SQ2 variant. Looking at the WoA
drivers for 8180_CAS (Caspar, Wi-Fi only)
https://github.com/WOA-Project/Qualcomm-Reference-Drivers/tree/master/Surface/8180_CAS/200.0.31.0
This variant is the only that has both SurfaceSMF_SQ1.cab and
SurfaceSMF_SQ2.cab. Only 8180_CAS MPSS INF maps the no-modem subsystem
ID (SUBSYS_MSNM8180 -> qcmpss8180_nm.mbn), the 8180_CAR (Carina) only
lists the cellular MSWW/MSJP/MSCN IDs.
My SQ2 Wi-Fi boots with the caspar dts in this patch fine but the
gold cluster is pinned at SQ1's top clocks because the 3.072 / 3.1488
GHz OPPs are only in carina.dts.
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x-microsoft-carina.dts b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-carina.dts
> new file mode 100644
> index 000000000000..5d155c69907a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-carina.dts
> @@ -0,0 +1,50 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +
> +/dts-v1/;
> +
> +#include "sc8180x-microsoft-surface-pro-x.dtsi"
> +
> +/ {
> + model = "Microsoft Surface Pro X (SQ2)";
> + compatible = "microsoft,carina", "qcom,sc8180x";
> +};
> +
> +&cpu4_opp_table {
> + opp-3072000000 {
> + opp-hz = /bits/ 64 <3072000000>;
> + opp-peak-kBps = <8368000 51609600>;
> + };
> +
> + opp-3148800000 {
> + opp-hz = /bits/ 64 <3148800000>;
> + opp-peak-kBps = <8368000 51609600>;
> + };
> +};
> +
[...]
Would it make sense to move opp-3072000000 and opp-3148800000 into the
shared sc8180x-microsoft-surface-pro-x.dtsi? qcom-cpufreq-hw disables
all DT OPPs first and only re-enables freqs present in the hardware LUT
so this would work for SQ1 and caspar.dtb will cover both the SQ1 and
SQ2 Wi-Fi models out of the box and carina.dts won't need its own
&cpu4_opp_table override.
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi
> new file mode 100644
> index 000000000000..17fb01c6b164
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sc8180x-microsoft-surface-pro-x.dtsi
[...]
> +&smb2351_2 {
> + status = "disabled";
> +};
> +
> +&smb2351_a {
> + status = "disabled";
> +};
Confirmed on hardware that labeling pmic@2 and pmic@a in
sc8180x-pmics.dtsi fixes the dtc build failure here.
[...]> +&uart13 {
> + pinctrl-0 = <&uart13_state>;
> + pinctrl-names = "default";
> +
> + status = "okay";
[...]
On linux-surface, ad1bb617a15a from Maximilian Luz had
&qupv3_id_2 {
status = "okay";
};
Would it be helpful to add here? I confirmed on hardware that adding it
allows uart13 (WCN3998 Bluetooth) and uart15 (SAM EC) to populate and
probe properly.
Thanks,
Haipeng
next prev parent reply other threads:[~2026-11-15 3:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 7:04 [PATCH 0/5] Add support for the Microsoft Surface Pro X Val Packett
2026-11-04 7:04 ` [PATCH 1/5] dt-bindings: arm: qcom: Document " Val Packett
2026-11-04 7:10 ` sashiko-bot
2026-11-15 3:25 ` Haipeng Lin
2026-11-04 7:04 ` [PATCH 2/5] arm64: dts: qcom: sc8180x: Add " Val Packett
2026-11-04 7:22 ` sashiko-bot
2026-11-04 8:36 ` Konrad Dybcio
2026-11-04 9:05 ` Val Packett
2026-11-15 3:16 ` Haipeng Lin [this message]
2026-11-15 8:20 ` Val Packett
2026-11-15 16:28 ` Haipeng Lin
2026-11-04 7:04 ` [PATCH 3/5] firmware: qcom: scm: Allow QSEECOM on the " Val Packett
2026-11-04 7:09 ` sashiko-bot
2026-11-04 7:04 ` [PATCH 4/5] rtc: Add basic support for RTC via Surface System Aggregator Module Val Packett
2026-11-04 7:13 ` sashiko-bot
2026-11-04 18:44 ` Alexandre Belloni
2026-11-04 7:04 ` [PATCH 5/5] platform/surface: aggregator_registry: Add support for Surface Pro X Val Packett
2026-11-04 7:09 ` sashiko-bot
2026-11-15 2:53 ` [PATCH 0/5] Add support for the Microsoft " Haipeng Lin
-- strict thread matches above, loose matches on Subject: below --
2026-11-17 23:07 [PATCH 2/5] arm64: dts: qcom: sc8180x: Add " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64e7afd3-50e5-4134-9bf6-92c4aa740bd7@gmail.com \
--to=jimmie.lin@gmail.com \
--cc=abelvesa@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=robh@kernel.org \
--cc=val@packett.cool \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.