From: Timur Tabi <ttabi@nvidia.com>
To: "dakr@redhat.com" <dakr@redhat.com>,
"gustavoars@kernel.org" <gustavoars@kernel.org>
Cc: "nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Nouveau] [PATCH][next] nouveau/gsp: replace zero-length array with flex-array member and use __counted_by
Date: Thu, 16 Nov 2023 19:55:54 +0000 [thread overview]
Message-ID: <6517a6a41eb72d16596c913dc56467e0390287a3.camel@nvidia.com> (raw)
In-Reply-To: <ZVZxXiXYIzEwUE3N@pollux>
On Thu, 2023-11-16 at 20:45 +0100, Danilo Krummrich wrote:
> As I already mentioned for Timur's patch [2], I'd prefer to get a fix
> upstream
> (meaning [1] in this case). Of course, that's probably more up to Timur to
> tell
> if this will work out.
Don't count on it.
Even if I did change [0] to [], I'm not going to be able to add the
"__counted_by(numEntries);" because that's just not something that our build
system uses.
And even then, I would need to change all [0] to [].
You're not going to be able to use RM's header files as-is anyway in the
long term. If we changed the layout of PACKED_REGISTRY_TABLE, we're not
going to create a PACKED_REGISTRY_TABLE2 and keep both around. We're just
going to change PACKED_REGISTRY_TABLE and pretend the previous version never
existed. You will then have to manually copy the new struct to your header
files and and maintain two versions yourself.
WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <ttabi@nvidia.com>
To: "dakr@redhat.com" <dakr@redhat.com>,
"gustavoars@kernel.org" <gustavoars@kernel.org>
Cc: "nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Nouveau] [PATCH][next] nouveau/gsp: replace zero-length array with flex-array member and use __counted_by
Date: Thu, 16 Nov 2023 19:55:54 +0000 [thread overview]
Message-ID: <6517a6a41eb72d16596c913dc56467e0390287a3.camel@nvidia.com> (raw)
In-Reply-To: <ZVZxXiXYIzEwUE3N@pollux>
On Thu, 2023-11-16 at 20:45 +0100, Danilo Krummrich wrote:
> As I already mentioned for Timur's patch [2], I'd prefer to get a fix
> upstream
> (meaning [1] in this case). Of course, that's probably more up to Timur to
> tell
> if this will work out.
Don't count on it.
Even if I did change [0] to [], I'm not going to be able to add the
"__counted_by(numEntries);" because that's just not something that our build
system uses.
And even then, I would need to change all [0] to [].
You're not going to be able to use RM's header files as-is anyway in the
long term. If we changed the layout of PACKED_REGISTRY_TABLE, we're not
going to create a PACKED_REGISTRY_TABLE2 and keep both around. We're just
going to change PACKED_REGISTRY_TABLE and pretend the previous version never
existed. You will then have to manually copy the new struct to your header
files and and maintain two versions yourself.
WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <ttabi@nvidia.com>
To: "dakr@redhat.com" <dakr@redhat.com>,
"gustavoars@kernel.org" <gustavoars@kernel.org>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Nouveau] [PATCH][next] nouveau/gsp: replace zero-length array with flex-array member and use __counted_by
Date: Thu, 16 Nov 2023 19:55:54 +0000 [thread overview]
Message-ID: <6517a6a41eb72d16596c913dc56467e0390287a3.camel@nvidia.com> (raw)
In-Reply-To: <ZVZxXiXYIzEwUE3N@pollux>
On Thu, 2023-11-16 at 20:45 +0100, Danilo Krummrich wrote:
> As I already mentioned for Timur's patch [2], I'd prefer to get a fix
> upstream
> (meaning [1] in this case). Of course, that's probably more up to Timur to
> tell
> if this will work out.
Don't count on it.
Even if I did change [0] to [], I'm not going to be able to add the
"__counted_by(numEntries);" because that's just not something that our build
system uses.
And even then, I would need to change all [0] to [].
You're not going to be able to use RM's header files as-is anyway in the
long term. If we changed the layout of PACKED_REGISTRY_TABLE, we're not
going to create a PACKED_REGISTRY_TABLE2 and keep both around. We're just
going to change PACKED_REGISTRY_TABLE and pretend the previous version never
existed. You will then have to manually copy the new struct to your header
files and and maintain two versions yourself.
next prev parent reply other threads:[~2023-11-16 19:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 18:11 [PATCH][next] nouveau/gsp: replace zero-length array with flex-array member and use __counted_by Gustavo A. R. Silva
2023-11-16 18:11 ` Gustavo A. R. Silva
2023-11-16 18:11 ` [Nouveau] " Gustavo A. R. Silva
2023-11-16 18:28 ` Kees Cook
2023-11-16 18:28 ` Kees Cook
2023-11-16 18:28 ` [Nouveau] " Kees Cook
2023-11-16 19:08 ` Timur Tabi
2023-11-16 19:45 ` Danilo Krummrich
2023-11-16 19:45 ` Danilo Krummrich
2023-11-16 19:45 ` [Nouveau] " Danilo Krummrich
2023-11-16 19:55 ` Timur Tabi [this message]
2023-11-16 19:55 ` Timur Tabi
2023-11-16 19:55 ` Timur Tabi
2023-11-29 1:01 ` Danilo Krummrich
2023-11-29 1:01 ` Danilo Krummrich
2023-11-29 1:01 ` Danilo Krummrich
2023-11-29 1:06 ` Gustavo A. R. Silva
2023-11-29 1:06 ` Gustavo A. R. Silva
2023-11-29 1:06 ` Gustavo A. R. Silva
2023-11-29 2:15 ` Danilo Krummrich
2023-11-29 2:15 ` Danilo Krummrich
2023-11-29 2:15 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6517a6a41eb72d16596c913dc56467e0390287a3.camel@nvidia.com \
--to=ttabi@nvidia.com \
--cc=dakr@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavoars@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.