All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Conor.Dooley@microchip.com>
To: <xianting.tian@linux.alibaba.com>, <paul.walmsley@sifive.com>,
	<palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
	<anup@brainfault.org>, <heiko@sntech.de>, <guoren@kernel.org>,
	<mick@ics.forth.gr>, <alexandre.ghiti@canonical.com>,
	<bhe@redhat.com>, <vgoyal@redhat.com>, <dyoung@redhat.com>,
	<corbet@lwn.net>
Cc: <kexec@lists.infradead.org>, <linux-doc@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<crash-utility@redhat.com>, <huanyi.xj@alibaba-inc.com>,
	<heinrich.schuchardt@canonical.com>, <k-hagio-ab@nec.com>,
	<hschauhan@nulltrace.org>
Subject: Re: [PATCH V4 0/5] RISC-V fixups to work with crash tool
Date: Tue, 26 Jul 2022 09:52:00 +0000	[thread overview]
Message-ID: <651b552d-8954-e58c-e994-4a9782f1112a@microchip.com> (raw)
In-Reply-To: <20220726093729.1231867-1-xianting.tian@linux.alibaba.com>

On 26/07/2022 10:37, Xianting Tian wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Ah I see you've already sent a v4.

> 
> Changes v1 -> v2:
>   1, remove the patch "Add a fast call path of crash_kexec()" from this series
>   of patches, as it already applied to riscv git.
>   https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/commit/?h=for-next&id=3f1901110a89b0e2e13adb2ac8d1a7102879ea98
>   2, add 'Reviewed-by' based on the comments of v1.
> Changes v2 -> v3:
>   use "riscv" instead of "riscv64" in patch 5 subject line.
> Changes v3 -> v4:
>   use "riscv" instead of "riscv64" in the summary of patch 5 subject line.

There's no need to respin a series for the sake 3 characters in the cover
letter (so sorry if you misunderstood me!)...

> 
> Xianting Tian (5):
>    RISC-V: use __smp_processor_id() instead of smp_processor_id()
>    RISC-V: Add arch_crash_save_vmcoreinfo support
>    riscv: Add modules to virtual kernel memory layout dump
>    RISC-V: Fixup getting correct current pc
>    riscv: crash_core: Export kernel vm layout, phys_ram_base

...but it would've been good to align these to either "riscv:" or
"RISC-V:" & not mix the two in a series. Don't do this right away,
it is okay to wait for more significant changes before sending out
a new version as this sort of thing could easily be changed when
being applied.

Thanks,
Conor.


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: <Conor.Dooley@microchip.com>
To: <xianting.tian@linux.alibaba.com>, <paul.walmsley@sifive.com>,
	<palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
	<anup@brainfault.org>, <heiko@sntech.de>, <guoren@kernel.org>,
	<mick@ics.forth.gr>, <alexandre.ghiti@canonical.com>,
	<bhe@redhat.com>, <vgoyal@redhat.com>, <dyoung@redhat.com>,
	<corbet@lwn.net>
Cc: <kexec@lists.infradead.org>, <linux-doc@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<crash-utility@redhat.com>, <huanyi.xj@alibaba-inc.com>,
	<heinrich.schuchardt@canonical.com>, <k-hagio-ab@nec.com>,
	<hschauhan@nulltrace.org>
Subject: Re: [PATCH V4 0/5] RISC-V fixups to work with crash tool
Date: Tue, 26 Jul 2022 09:52:00 +0000	[thread overview]
Message-ID: <651b552d-8954-e58c-e994-4a9782f1112a@microchip.com> (raw)
In-Reply-To: <20220726093729.1231867-1-xianting.tian@linux.alibaba.com>

On 26/07/2022 10:37, Xianting Tian wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Ah I see you've already sent a v4.

> 
> Changes v1 -> v2:
>   1, remove the patch "Add a fast call path of crash_kexec()" from this series
>   of patches, as it already applied to riscv git.
>   https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/commit/?h=for-next&id=3f1901110a89b0e2e13adb2ac8d1a7102879ea98
>   2, add 'Reviewed-by' based on the comments of v1.
> Changes v2 -> v3:
>   use "riscv" instead of "riscv64" in patch 5 subject line.
> Changes v3 -> v4:
>   use "riscv" instead of "riscv64" in the summary of patch 5 subject line.

There's no need to respin a series for the sake 3 characters in the cover
letter (so sorry if you misunderstood me!)...

> 
> Xianting Tian (5):
>    RISC-V: use __smp_processor_id() instead of smp_processor_id()
>    RISC-V: Add arch_crash_save_vmcoreinfo support
>    riscv: Add modules to virtual kernel memory layout dump
>    RISC-V: Fixup getting correct current pc
>    riscv: crash_core: Export kernel vm layout, phys_ram_base

...but it would've been good to align these to either "riscv:" or
"RISC-V:" & not mix the two in a series. Don't do this right away,
it is okay to wait for more significant changes before sending out
a new version as this sort of thing could easily be changed when
being applied.

Thanks,
Conor.



WARNING: multiple messages have this Message-ID (diff)
From: <Conor.Dooley@microchip.com>
To: <xianting.tian@linux.alibaba.com>, <paul.walmsley@sifive.com>,
	<palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
	<anup@brainfault.org>, <heiko@sntech.de>, <guoren@kernel.org>,
	<mick@ics.forth.gr>, <alexandre.ghiti@canonical.com>,
	<bhe@redhat.com>, <vgoyal@redhat.com>, <dyoung@redhat.com>,
	<corbet@lwn.net>
Cc: <kexec@lists.infradead.org>, <linux-doc@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<crash-utility@redhat.com>, <huanyi.xj@alibaba-inc.com>,
	<heinrich.schuchardt@canonical.com>, <k-hagio-ab@nec.com>,
	<hschauhan@nulltrace.org>
Subject: Re: [PATCH V4 0/5] RISC-V fixups to work with crash tool
Date: Tue, 26 Jul 2022 09:52:00 +0000	[thread overview]
Message-ID: <651b552d-8954-e58c-e994-4a9782f1112a@microchip.com> (raw)
In-Reply-To: <20220726093729.1231867-1-xianting.tian@linux.alibaba.com>

On 26/07/2022 10:37, Xianting Tian wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Ah I see you've already sent a v4.

> 
> Changes v1 -> v2:
>   1, remove the patch "Add a fast call path of crash_kexec()" from this series
>   of patches, as it already applied to riscv git.
>   https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/commit/?h=for-next&id=3f1901110a89b0e2e13adb2ac8d1a7102879ea98
>   2, add 'Reviewed-by' based on the comments of v1.
> Changes v2 -> v3:
>   use "riscv" instead of "riscv64" in patch 5 subject line.
> Changes v3 -> v4:
>   use "riscv" instead of "riscv64" in the summary of patch 5 subject line.

There's no need to respin a series for the sake 3 characters in the cover
letter (so sorry if you misunderstood me!)...

> 
> Xianting Tian (5):
>    RISC-V: use __smp_processor_id() instead of smp_processor_id()
>    RISC-V: Add arch_crash_save_vmcoreinfo support
>    riscv: Add modules to virtual kernel memory layout dump
>    RISC-V: Fixup getting correct current pc
>    riscv: crash_core: Export kernel vm layout, phys_ram_base

...but it would've been good to align these to either "riscv:" or
"RISC-V:" & not mix the two in a series. Don't do this right away,
it is okay to wait for more significant changes before sending out
a new version as this sort of thing could easily be changed when
being applied.

Thanks,
Conor.


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2022-07-26  9:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-26  9:37 [PATCH V4 0/5] RISC-V fixups to work with crash tool Xianting Tian
2022-07-26  9:37 ` Xianting Tian
2022-07-26  9:37 ` Xianting Tian
2022-07-26  9:37 ` [PATCH V4 1/5] RISC-V: use __smp_processor_id() instead of smp_processor_id() Xianting Tian
2022-07-26  9:37   ` Xianting Tian
2022-07-26  9:37   ` Xianting Tian
2022-07-26  9:37 ` [PATCH V4 2/5] RISC-V: Add arch_crash_save_vmcoreinfo support Xianting Tian
2022-07-26  9:37   ` Xianting Tian
2022-07-26  9:37   ` Xianting Tian
2022-07-26  9:37 ` [PATCH V4 3/5] riscv: Add modules to virtual kernel memory layout dump Xianting Tian
2022-07-26  9:37   ` Xianting Tian
2022-07-26  9:37   ` Xianting Tian
2022-07-26  9:37 ` [PATCH V4 4/5] RISC-V: Fixup getting correct current pc Xianting Tian
2022-07-26  9:37   ` Xianting Tian
2022-07-26  9:37   ` Xianting Tian
2022-07-26  9:37 ` [PATCH V4 5/5] riscv: crash_core: Export kernel vm layout, phys_ram_base Xianting Tian
2022-07-26  9:37   ` Xianting Tian
2022-07-26  9:37   ` Xianting Tian
2022-07-26  9:52 ` Conor.Dooley [this message]
2022-07-26  9:52   ` [PATCH V4 0/5] RISC-V fixups to work with crash tool Conor.Dooley
2022-07-26  9:52   ` Conor.Dooley
2022-07-26 13:58   ` Xianting Tian
2022-07-26 13:58     ` Xianting Tian
2022-07-26 13:58     ` Xianting Tian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=651b552d-8954-e58c-e994-4a9782f1112a@microchip.com \
    --to=conor.dooley@microchip.com \
    --cc=alexandre.ghiti@canonical.com \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=bhe@redhat.com \
    --cc=corbet@lwn.net \
    --cc=crash-utility@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=guoren@kernel.org \
    --cc=heiko@sntech.de \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=hschauhan@nulltrace.org \
    --cc=huanyi.xj@alibaba-inc.com \
    --cc=k-hagio-ab@nec.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mick@ics.forth.gr \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=vgoyal@redhat.com \
    --cc=xianting.tian@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.