[PATCH 0/1] Bluetooth: ISO: Match QoS adv handle with BIG handle

[PATCH 0/1] Bluetooth: ISO: Match QoS adv handle with BIG handle

[Iulia Tanasescu]

Currently, if the user wants to bind multiple broadcast sockets to the
same BIG handle, the BIG and BIS fields of the QoS structs must be set
and identical for all sockets.

It means that the user must remember both the BIG handle and the
associated advertising handle that the BIG will be opened for.
This information is redundant, since one BIG handle may only be
associated with an unique adv handle.

This patch makes it possible for the user to only provide a desired
BIG handle and leave the advertising handle as unset - in this case,
the kernel should allocate an unused adv handle for the first opened
socket and then be able to match it for all other sockets that will
be later bound for the same BIG.

Iulia Tanasescu (1):
  Bluetooth: ISO: Match QoS adv handle with BIG handle

 net/bluetooth/hci_conn.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)


base-commit: 091e25d6b54992d1d702ae91cbac139d4c243251
-- 
2.39.2

[PATCH 1/1] Bluetooth: ISO: Match QoS adv handle with BIG handle

[Iulia Tanasescu]

In case the user binds multiple sockets for the same BIG, the BIG
handle should be matched with the associated adv handle, if it has
already been allocated previously.

Signed-off-by: Iulia Tanasescu <iulia.tanasescu@nxp.com>
---
 net/bluetooth/hci_conn.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index e62a5f368a51..7890ec449a7b 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -1494,6 +1494,18 @@ static int qos_set_bis(struct hci_dev *hdev, struct bt_iso_qos *qos)
 
 	/* Allocate BIS if not set */
 	if (qos->bcast.bis == BT_ISO_QOS_BIS_UNSET) {
+		if (qos->bcast.big != BT_ISO_QOS_BIG_UNSET) {
+			conn = hci_conn_hash_lookup_big(hdev, qos->bcast.big);
+
+			if (conn) {
+				/* If the BIG handle is already matched to an advertising
+				 * handle, do not allocate a new one.
+				 */
+				qos->bcast.bis = conn->iso_qos.bcast.bis;
+				return 0;
+			}
+		}
+
 		/* Find an unused adv set to advertise BIS, skip instance 0x00
 		 * since it is reserved as general purpose set.
 		 */
-- 
2.39.2

RE: Bluetooth: ISO: Match QoS adv handle with BIG handle

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=789623

---Test result---

Test Summary:
CheckPatch                    PASS      0.64 seconds
GitLint                       PASS      0.26 seconds
SubjectPrefix                 PASS      0.07 seconds
BuildKernel                   PASS      41.21 seconds
CheckAllWarning               PASS      44.77 seconds
CheckSparse                   PASS      51.08 seconds
CheckSmatch                   PASS      135.75 seconds
BuildKernel32                 PASS      40.17 seconds
TestRunnerSetup               PASS      602.36 seconds
TestRunner_l2cap-tester       PASS      36.77 seconds
TestRunner_iso-tester         PASS      61.80 seconds
TestRunner_bnep-tester        PASS      13.83 seconds
TestRunner_mgmt-tester        PASS      252.90 seconds
TestRunner_rfcomm-tester      PASS      19.04 seconds
TestRunner_sco-tester         PASS      22.40 seconds
TestRunner_ioctl-tester       PASS      21.64 seconds
TestRunner_mesh-tester        PASS      15.99 seconds
TestRunner_smp-tester         PASS      17.23 seconds
TestRunner_userchan-tester    PASS      13.50 seconds
IncrementalBuild              PASS      37.36 seconds



---
Regards,
Linux Bluetooth

Re: [PATCH 0/1] Bluetooth: ISO: Match QoS adv handle with BIG handle

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue,  3 Oct 2023 17:37:38 +0300 you wrote:
> Currently, if the user wants to bind multiple broadcast sockets to the
> same BIG handle, the BIG and BIS fields of the QoS structs must be set
> and identical for all sockets.
> 
> It means that the user must remember both the BIG handle and the
> associated advertising handle that the BIG will be opened for.
> This information is redundant, since one BIG handle may only be
> associated with an unique adv handle.
> 
> [...]

Here is the summary with links:
  - [1/1] Bluetooth: ISO: Match QoS adv handle with BIG handle
    https://git.kernel.org/bluetooth/bluetooth-next/c/cffdc28aa2e2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

[PATCH 1/1] Bluetooth: ISO: Match QoS adv handle with BIG handle

[Iulia Tanasescu]

In case the user binds multiple sockets for the same BIG, the BIG
handle should be matched with the associated adv handle, if it has
already been allocated previously.

Signed-off-by: Iulia Tanasescu <iulia.tanasescu@nxp.com>
---
 net/bluetooth/hci_conn.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index e62a5f368a51..7890ec449a7b 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -1494,6 +1494,18 @@ static int qos_set_bis(struct hci_dev *hdev, struct bt_iso_qos *qos)
 
 	/* Allocate BIS if not set */
 	if (qos->bcast.bis == BT_ISO_QOS_BIS_UNSET) {
+		if (qos->bcast.big != BT_ISO_QOS_BIG_UNSET) {
+			conn = hci_conn_hash_lookup_big(hdev, qos->bcast.big);
+
+			if (conn) {
+				/* If the BIG handle is already matched to an advertising
+				 * handle, do not allocate a new one.
+				 */
+				qos->bcast.bis = conn->iso_qos.bcast.bis;
+				return 0;
+			}
+		}
+
 		/* Find an unused adv set to advertise BIS, skip instance 0x00
 		 * since it is reserved as general purpose set.
 		 */
-- 
2.39.2

RE: Bluetooth: ISO: Match QoS adv handle with BIG handle

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=788854

---Test result---

Test Summary:
CheckPatch                    PASS      0.58 seconds
GitLint                       PASS      0.26 seconds
SubjectPrefix                 PASS      0.08 seconds
BuildKernel                   PASS      33.90 seconds
CheckAllWarning               PASS      36.67 seconds
CheckSparse                   PASS      42.09 seconds
CheckSmatch                   PASS      117.46 seconds
BuildKernel32                 PASS      32.87 seconds
TestRunnerSetup               PASS      496.38 seconds
TestRunner_l2cap-tester       PASS      30.09 seconds
TestRunner_iso-tester         PASS      49.60 seconds
TestRunner_bnep-tester        PASS      10.53 seconds
TestRunner_mgmt-tester        PASS      218.45 seconds
TestRunner_rfcomm-tester      PASS      15.14 seconds
TestRunner_sco-tester         PASS      18.75 seconds
TestRunner_ioctl-tester       PASS      17.13 seconds
TestRunner_mesh-tester        PASS      12.56 seconds
TestRunner_smp-tester         PASS      13.61 seconds
TestRunner_userchan-tester    PASS      10.40 seconds
IncrementalBuild              PASS      30.93 seconds



---
Regards,
Linux Bluetooth