[PATCH BlueZ v1 0/1] Changed Obex default timeout

[PATCH BlueZ v1 0/1] Changed Obex default timeout

[Purendra-Singh]

Hello Maintainers,

This patch is related to changing the obex default timeout.
It is obeserved that some reference devices send file reception
status delayed, which causes timeout. Even though the file is
completely transferred we observed status error, changing the timeout
is resolving the issue.

Thankyou in advance for your review.

Regards,
Purendra Singh

Purendra-Singh (1):
  gobex/gobex.c : Changed default obex timeout

 gobex/gobex.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.34.1

[PATCH BlueZ v1 1/1] gobex/gobex.c : Changed default obex timeout

[Purendra-Singh]

Description: File received status of some reference devices
is delayed, that causes timeout and file transfer status error.
---
 gobex/gobex.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gobex/gobex.c b/gobex/gobex.c
index e9b89cead..f0e1c2c83 100644
--- a/gobex/gobex.c
+++ b/gobex/gobex.c
@@ -22,7 +22,7 @@
 #define G_OBEX_MINIMUM_MTU	255
 #define G_OBEX_MAXIMUM_MTU	65535
 
-#define G_OBEX_DEFAULT_TIMEOUT	10
+#define G_OBEX_DEFAULT_TIMEOUT	500
 #define G_OBEX_ABORT_TIMEOUT	5
 
 #define G_OBEX_OP_NONE		0xff
-- 
2.34.1

Re: [PATCH BlueZ v1 1/1] gobex/gobex.c : Changed default obex timeout

[Paul Menzel]

Dear Purendra-Singh,


Thank you for your patch.

Am 19.10.23 um 09:16 schrieb Purendra-Singh:
> Description: File received status of some reference devices
> is delayed, that causes timeout and file transfer status error.

Some formal issues:

1.  Please remove the redundant *Description* at the beginning.
2.  Do you only have “one” name, or is the transcription(?) spelled 
without a hyphen/minus: Purendra Singh?
3.  Please be more specific in the commit messages summary/title. Maybe:

     > gobex: Increase default obex timeout from 10 ms to 500 ms

Most importantly, why did you pick 500 ms, and what reference device is 
it? (What chipset for example?)

> ---
>   gobex/gobex.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gobex/gobex.c b/gobex/gobex.c
> index e9b89cead..f0e1c2c83 100644
> --- a/gobex/gobex.c
> +++ b/gobex/gobex.c
> @@ -22,7 +22,7 @@
>   #define G_OBEX_MINIMUM_MTU	255
>   #define G_OBEX_MAXIMUM_MTU	65535
>   
> -#define G_OBEX_DEFAULT_TIMEOUT	10
> +#define G_OBEX_DEFAULT_TIMEOUT	500
>   #define G_OBEX_ABORT_TIMEOUT	5
>   
>   #define G_OBEX_OP_NONE		0xff


Kind regards,

Paul

RE: Changed Obex default timeout

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=794595

---Test result---

Test Summary:
CheckPatch                    PASS      0.50 seconds
GitLint                       PASS      0.34 seconds
BuildEll                      PASS      29.22 seconds
BluezMake                     PASS      1046.14 seconds
MakeCheck                     PASS      12.19 seconds
MakeDistcheck                 PASS      178.48 seconds
CheckValgrind                 PASS      277.44 seconds
CheckSmatch                   PASS      367.49 seconds
bluezmakeextell               PASS      119.40 seconds
IncrementalBuild              PASS      854.28 seconds
ScanBuild                     PASS      1126.69 seconds



---
Regards,
Linux Bluetooth