From: Tomasz Figa <tomasz.figa@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Padmavathi Venna <padma.v@samsung.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
padma.kvr@gmail.com, kgene.kim@samsung.com,
abrestic@chromium.org
Subject: Re: [PATCH V4 0/4] Add i2s support on smdk5420
Date: Wed, 14 Aug 2013 10:25:27 +0200 [thread overview]
Message-ID: <6538092.D4LPomiMyc@flatron> (raw)
In-Reply-To: <20130813124440.GX6427@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
On Tuesday 13 of August 2013 13:44:40 Mark Brown wrote:
> On Mon, Aug 12, 2013 at 03:19:50PM +0530, Padmavathi Venna wrote:
> > Samsung has different versions of I2S introduced in different
> > platforms. Each version has some new support added for multichannel,
> > secondary fifo, s/w reset control, internal mux for rclk src clk and
> > tdm support. Each newly added change has a quirk. So this patch adds
> > all the required quirks as driver data and based on compatible string
> > from dtsi fetches the quirks. This also adds i2s support on
> > exynos5420.
>
> Applied all these, thanks.
Hmm, this series looks good to me too, except one thing. What about the
bisection breakage introduced by the hole between patches 1/4 and 4/4
(after the list of supported compatible changes in the driver and before
respective dts files are updated)?
Best regards,
Tomasz
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 0/4] Add i2s support on smdk5420
Date: Wed, 14 Aug 2013 10:25:27 +0200 [thread overview]
Message-ID: <6538092.D4LPomiMyc@flatron> (raw)
In-Reply-To: <20130813124440.GX6427@sirena.org.uk>
On Tuesday 13 of August 2013 13:44:40 Mark Brown wrote:
> On Mon, Aug 12, 2013 at 03:19:50PM +0530, Padmavathi Venna wrote:
> > Samsung has different versions of I2S introduced in different
> > platforms. Each version has some new support added for multichannel,
> > secondary fifo, s/w reset control, internal mux for rclk src clk and
> > tdm support. Each newly added change has a quirk. So this patch adds
> > all the required quirks as driver data and based on compatible string
> > from dtsi fetches the quirks. This also adds i2s support on
> > exynos5420.
>
> Applied all these, thanks.
Hmm, this series looks good to me too, except one thing. What about the
bisection breakage introduced by the hole between patches 1/4 and 4/4
(after the list of supported compatible changes in the driver and before
respective dts files are updated)?
Best regards,
Tomasz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130814/8e85ba14/attachment.sig>
next prev parent reply other threads:[~2013-08-14 8:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 9:49 [PATCH V4 0/4] Add i2s support on smdk5420 Padmavathi Venna
2013-08-12 9:49 ` Padmavathi Venna
2013-08-12 9:49 ` [PATCH V4 1/4] ASoC: Samsung: I2S: Add quirks as driver data in I2S Padmavathi Venna
2013-08-12 9:49 ` Padmavathi Venna
2013-08-12 12:06 ` Tomasz Figa
2013-08-12 12:06 ` Tomasz Figa
2013-08-12 22:57 ` Stephen Warren
2013-08-12 22:57 ` Stephen Warren
2013-08-12 23:13 ` Mark Brown
2013-08-12 23:13 ` Mark Brown
2013-08-12 23:18 ` Stephen Warren
2013-08-12 23:18 ` Stephen Warren
2013-08-12 23:46 ` Mark Brown
2013-08-12 23:46 ` Mark Brown
2013-08-13 15:42 ` Stephen Warren
2013-08-13 15:42 ` Stephen Warren
2013-08-12 9:49 ` [PATCH V4 2/4] ASoC: Samsung: I2S: Modify the I2S driver to support I2S on Exynos5420 Padmavathi Venna
2013-08-12 9:49 ` Padmavathi Venna
2013-08-12 9:49 ` [PATCH V4 3/4] ARM: dts: exynos5250: move common i2s properties to exynos5 dtsi Padmavathi Venna
2013-08-12 9:49 ` Padmavathi Venna
2013-08-12 9:49 ` [PATCH V4 4/4] ARM: dts: Change i2s compatible string on exynos5250 Padmavathi Venna
2013-08-12 9:49 ` Padmavathi Venna
2013-08-13 12:44 ` [PATCH V4 0/4] Add i2s support on smdk5420 Mark Brown
2013-08-13 12:44 ` Mark Brown
2013-08-14 8:25 ` Tomasz Figa [this message]
2013-08-14 8:25 ` Tomasz Figa
2013-08-14 10:03 ` Mark Brown
2013-08-14 10:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6538092.D4LPomiMyc@flatron \
--to=tomasz.figa@gmail.com \
--cc=abrestic@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=padma.kvr@gmail.com \
--cc=padma.v@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.