All of lore.kernel.org
 help / color / mirror / Atom feed
* remap_pte_range
@ 2004-06-30  0:17 ` Martin J. Bligh
  0 siblings, 0 replies; 6+ messages in thread
From: Martin J. Bligh @ 2004-06-30  0:17 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-mm mailing list, linux-kernel

I have no idea what remap_pte_range is trying to do here, but what it
is doing makes no sense (to me at least). 

If the pfn is not valid, we CANNOT safely call PageReserved on it - 
the *page returned from pfn_to_page is bullshit, and we crash deref'ing
it.

Perhaps this was what it was trying to do? Not sure.

diff -purN -X /home/mbligh/.diff.exclude virgin/mm/memory.c remap_pte_range/mm/memory.c
--- virgin/mm/memory.c	2004-06-16 10:22:15.000000000 -0700
+++ remap_pte_range/mm/memory.c	2004-06-29 17:15:35.000000000 -0700
@@ -908,7 +908,7 @@ static inline void remap_pte_range(pte_t
 	pfn = phys_addr >> PAGE_SHIFT;
 	do {
 		BUG_ON(!pte_none(*pte));
-		if (!pfn_valid(pfn) || PageReserved(pfn_to_page(pfn)))
+		if (pfn_valid(pfn) && !PageReserved(pfn_to_page(pfn)))
  			set_pte(pte, pfn_pte(pfn, prot));
 		address += PAGE_SIZE;
 		pfn++;


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2004-06-30  6:44 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-30  0:17 remap_pte_range Martin J. Bligh
2004-06-30  0:17 ` remap_pte_range Martin J. Bligh
2004-06-30  0:30 ` remap_pte_range Andrew Morton
2004-06-30  0:30   ` remap_pte_range Andrew Morton
2004-06-30  6:44   ` remap_pte_range Martin J. Bligh
2004-06-30  6:44     ` remap_pte_range Martin J. Bligh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.