From: Jarkko Sakkinen <jarkko@kernel.org>
To: Stefan Berger <stefanb@linux.ibm.com>,
linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org, mpe@ellerman.id.au,
naveen.n.rao@linux.ibm.com
Subject: Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support
Date: Mon, 01 Jul 2024 14:52:33 +0000 [thread overview]
Message-ID: <656b319fc58683e399323b880722434467cf20f2.camel@kernel.org> (raw)
In-Reply-To: <20240617193408.1234365-1-stefanb@linux.ibm.com>
On Mon, 2024-06-17 at 15:34 -0400, Stefan Berger wrote:
> Fix the following type of error message caused by a missing call to
> tpm2_sessions_init() in the IBM vTPM driver:
>
> [ 2.987131] tpm tpm0: tpm2_load_context: failed with a TPM error 0x01C4
> [ 2.987140] ima: Error Communicating to TPM chip, result: -14
>
> Fixes: d2add27cf2b8 ("tpm: Add NULL primary creation")
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
This is a bug in the hmac encryption. It should be robust enough
to only be enabled if tpm_sessions_init() was called.
It is fine to enable the feature IBM vTPM driver but definitely
not as a bug fix.
Missed this one in the code review.
BR, Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Stefan Berger <stefanb@linux.ibm.com>,
linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: naveen.n.rao@linux.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support
Date: Mon, 01 Jul 2024 14:52:33 +0000 [thread overview]
Message-ID: <656b319fc58683e399323b880722434467cf20f2.camel@kernel.org> (raw)
In-Reply-To: <20240617193408.1234365-1-stefanb@linux.ibm.com>
On Mon, 2024-06-17 at 15:34 -0400, Stefan Berger wrote:
> Fix the following type of error message caused by a missing call to
> tpm2_sessions_init() in the IBM vTPM driver:
>
> [ 2.987131] tpm tpm0: tpm2_load_context: failed with a TPM error 0x01C4
> [ 2.987140] ima: Error Communicating to TPM chip, result: -14
>
> Fixes: d2add27cf2b8 ("tpm: Add NULL primary creation")
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
This is a bug in the hmac encryption. It should be robust enough
to only be enabled if tpm_sessions_init() was called.
It is fine to enable the feature IBM vTPM driver but definitely
not as a bug fix.
Missed this one in the code review.
BR, Jarkko
next prev parent reply other threads:[~2024-07-01 14:52 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 19:34 [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support Stefan Berger
2024-06-17 19:34 ` Stefan Berger
2024-06-17 19:42 ` James Bottomley
2024-06-17 19:42 ` James Bottomley
2024-06-17 19:56 ` Stefan Berger
2024-06-17 19:56 ` Stefan Berger
2024-06-17 20:05 ` James Bottomley
2024-06-17 20:05 ` James Bottomley
2024-06-17 20:17 ` Stefan Berger
2024-06-17 20:17 ` Stefan Berger
2024-06-19 22:34 ` Stefan Berger
2024-06-19 22:34 ` Stefan Berger
2024-06-28 15:00 ` Linux regression tracking (Thorsten Leemhuis)
2024-06-28 15:00 ` Linux regression tracking (Thorsten Leemhuis)
2024-07-01 15:22 ` Jarkko Sakkinen
2024-07-01 15:22 ` Jarkko Sakkinen
2024-07-01 18:29 ` Stefan Berger
2024-07-01 18:29 ` Stefan Berger
2024-07-01 19:01 ` Jarkko Sakkinen
2024-07-01 19:01 ` Jarkko Sakkinen
2024-07-01 19:14 ` Stefan Berger
2024-07-01 19:14 ` Stefan Berger
2024-07-02 23:48 ` Jarkko Sakkinen
2024-07-02 23:48 ` Jarkko Sakkinen
2024-07-02 23:57 ` Jarkko Sakkinen
2024-07-02 23:57 ` Jarkko Sakkinen
2024-07-03 0:34 ` Jarkko Sakkinen
2024-07-03 0:34 ` Jarkko Sakkinen
2024-07-03 0:48 ` Jarkko Sakkinen
2024-07-03 0:48 ` Jarkko Sakkinen
2024-07-03 1:00 ` Jarkko Sakkinen
2024-07-03 1:00 ` Jarkko Sakkinen
2024-07-01 14:53 ` Jarkko Sakkinen
2024-07-01 14:53 ` Jarkko Sakkinen
2024-06-28 0:54 ` Michael Ellerman
2024-06-28 0:54 ` Michael Ellerman
2024-06-28 16:39 ` James Bottomley
2024-06-28 16:39 ` James Bottomley
2024-06-28 17:21 ` Stefan Berger
2024-06-28 17:21 ` Stefan Berger
2024-07-02 0:19 ` Michael Ellerman
2024-07-02 0:19 ` Michael Ellerman
2024-07-01 14:52 ` Jarkko Sakkinen [this message]
2024-07-01 14:52 ` Jarkko Sakkinen
-- strict thread matches above, loose matches on Subject: below --
2024-08-29 13:47 Qianqiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=656b319fc58683e399323b880722434467cf20f2.camel@kernel.org \
--to=jarkko@kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.ibm.com \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.