[Bugme-new] [Bug 442] New: compile failure in drivers/cpufreq/userspace.c (fwd)

[Bugme-new] [Bug 442] New: compile failure in drivers/cpufreq/userspace.c (fwd)

[Martin J. Bligh]

http://bugme.osdl.org/show_bug.cgi?id=442

           Summary: compile failure in drivers/cpufreq/userspace.c
    Kernel Version: 2.5.64
            Status: NEW
          Severity: normal
             Owner: bugme-janitors@lists.osdl.org
         Submitter: john@larvalstage.com


Distribution:  Gentoo 1.4rc3
Hardware Environment:  Abit KG7-RAID, AMD Athlon TBird 1.4, 512MB DDR, Geforce 3
Software Environment:  gcc 3.2.2, glibc 2.3.1, ld 2.13.90.0.18
Problem Description:

  gcc -Wp,-MD,drivers/cpufreq/.userspace.o.d -D__KERNEL__ -Iinclude -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe
-mpreferred-stack-boundary=2 -march=athlon -Iinclude/asm-i386/mach-default
-nostdinc -iwithprefix include    -DKBUILD_BASENAME=userspace
-DKBUILD_MODNAME=userspace -c -o drivers/cpufreq/.tmp_userspace.o
drivers/cpufreq/userspace.c
drivers/cpufreq/userspace.c: In function `cpufreq_governor_userspace':
drivers/cpufreq/userspace.c:514: structure has no member named `intf'
drivers/cpufreq/userspace.c:523: structure has no member named `intf'
make[2]: *** [drivers/cpufreq/userspace.o] Error 1
make[1]: *** [drivers/cpufreq] Error 2
make: *** [drivers] Error 2


Steps to reproduce:

Power management options (ACPI, APM)  --->
CPU Frequency scaling  --->
<*>   'userspace' governor for userspace frequency scaling

CONFIG_CPU_FREQ_GOV_USERSPACE=y

Re: [Bugme-new] [Bug 442] New: compile failure in drivers/cpufreq/userspace.c (fwd)

[Patrick Mochel]

On Wed, 5 Mar 2003, Bob Miller wrote:

> On Wed, Mar 05, 2003 at 02:53:33PM -0800, Martin J. Bligh wrote:
> >   gcc -Wp,-MD,drivers/cpufreq/.userspace.o.d -D__KERNEL__ -Iinclude -Wall
> > -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe
> > -mpreferred-stack-boundary=2 -march=athlon -Iinclude/asm-i386/mach-default
> > -nostdinc -iwithprefix include    -DKBUILD_BASENAME=userspace
> > -DKBUILD_MODNAME=userspace -c -o drivers/cpufreq/.tmp_userspace.o
> > drivers/cpufreq/userspace.c
> > drivers/cpufreq/userspace.c: In function `cpufreq_governor_userspace':
> > drivers/cpufreq/userspace.c:514: structure has no member named `intf'
> > drivers/cpufreq/userspace.c:523: structure has no member named `intf'
> > make[2]: *** [drivers/cpufreq/userspace.o] Error 1
> > make[1]: *** [drivers/cpufreq] Error 2
> > make: *** [drivers] Error 2
> 
> I believe the patch below fixes the problem.  Pat?

Yup, that'll do it. 

I just sent Linus an update with an identical patch in it, so hopefully 
it'll be in BK soon.

	-pat

Re: [Bugme-new] [Bug 442] New: compile failure in drivers/cpufreq/userspace.c (fwd)

[Bob Miller]

On Wed, Mar 05, 2003 at 02:53:33PM -0800, Martin J. Bligh wrote:
>   gcc -Wp,-MD,drivers/cpufreq/.userspace.o.d -D__KERNEL__ -Iinclude -Wall
> -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe
> -mpreferred-stack-boundary=2 -march=athlon -Iinclude/asm-i386/mach-default
> -nostdinc -iwithprefix include    -DKBUILD_BASENAME=userspace
> -DKBUILD_MODNAME=userspace -c -o drivers/cpufreq/.tmp_userspace.o
> drivers/cpufreq/userspace.c
> drivers/cpufreq/userspace.c: In function `cpufreq_governor_userspace':
> drivers/cpufreq/userspace.c:514: structure has no member named `intf'
> drivers/cpufreq/userspace.c:523: structure has no member named `intf'
> make[2]: *** [drivers/cpufreq/userspace.o] Error 1
> make[1]: *** [drivers/cpufreq] Error 2
> make: *** [drivers] Error 2

I believe the patch below fixes the problem.  Pat?

-- 
Bob Miller					Email: rem@osdl.org
Open Source Development Lab			Phone: 503.626.2455 Ext. 17


===== userspace.c 1.1 vs edited =====
--- 1.1/drivers/cpufreq/userspace.c	Sun Feb 16 05:23:39 2003
+++ edited/userspace.c	Wed Mar  5 16:12:16 2003
@@ -511,7 +511,7 @@
 		cpu_min_freq[cpu] = policy->min;
 		cpu_max_freq[cpu] = policy->max;
 		cpu_cur_freq[cpu] = policy->cur;
-		device_create_file (policy->intf.dev, &dev_attr_scaling_setspeed);
+		device_create_file (policy->dev, &dev_attr_scaling_setspeed);
 		memcpy (&current_policy[cpu], policy, sizeof(struct cpufreq_policy));
 		up(&userspace_sem);
 		break;
@@ -520,7 +520,7 @@
 		cpu_is_managed[cpu] = 0;
 		cpu_min_freq[cpu] = 0;
 		cpu_max_freq[cpu] = 0;
-		device_remove_file (policy->intf.dev, &dev_attr_scaling_setspeed);
+		device_remove_file (policy->dev, &dev_attr_scaling_setspeed);
 		up(&userspace_sem);
 		module_put(THIS_MODULE);
 		break;