All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	Marek Vasut <marex@denx.de>,
	Jagan Teki <jagan@amarulasolutions.com>
Cc: Laurent.pinchart@ideasonboard.com, aford173@gmail.com,
	andrzej.hajda@intel.com, dri-devel@lists.freedesktop.org,
	inki.dae@samsung.com, kyungmin.park@samsung.com,
	linux-amarula@amarulasolutions.com,
	linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
	linux-samsung-soc@vger.kernel.org, m.szyprowski@samsung.com,
	matteo.lisi@engicam.com, sw0312.kim@samsung.com,
	tharvey@gateworks.com
Subject: Re: [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge
Date: Wed, 22 Feb 2023 11:05:09 +0100	[thread overview]
Message-ID: <657fa528-ca01-0c6a-2c2b-bb7f4a95096d@kontron.de> (raw)
In-Reply-To: <b246aae9-b719-02f9-dd0f-305b74611fab@prevas.dk>

On 17.02.23 19:22, Rasmus Villemoes wrote:
> On 07/02/2023 10.09, Rasmus Villemoes wrote:
> 
>> I managed to get the whole chain lcdif -> mipi -> bridge -> dp-connector
>> to probe with these settings
>>
> [...]
>> Now hotplug-detect doesn't work with the current sn65dsi86 driver, but
>> that's a separate issue; when I boot with a monitor attached, its edid
>> is correctly read out. But I still don't get any output, and the monitor
>> says "no signal" - my naive attempt (which has worked fine in other
>> cases) was to just dd /dev/urandom to /dev/fb0, so I'm clearly missing
>> some important step.
> 
> No idea if it's important, but in the NXP kernel, there's a
> 
> 	display-subsystem {
> 		compatible = "fsl,imx-display-subsystem";
> 		ports = <&lcdif1_disp>,
> 			<&lcdif2_disp>,
> 			<&lcdif3_disp>;
> 	};
> 
> node in imx8mp.dtsi, and when commenting out that node, the graphics
> ceases to work, even if all the devices in the lcdif->mipi->bridge chain
> actually probes. However, adding a corresponding node in mainline, which
> does have a driver for that "fsl,imx-display-subsystem", makes no
> difference; with or without that, I do get a /dev/fb0 device and the
> whole chain probes, but again the monitor says no signal.

The NXP kernel is completely different. AFAIK it uses the component
helpers to bundle all subdrivers from a central driver
(display-subsystem). This is not how the mainline approach using the
bridge driver interface works. So you can't compare them.

Did you look at this extensive thread with findings from Adam?

https://lore.kernel.org/lkml/CAHCN7xJ=N1vWVTBjArskJ59fyaLzmAGWfc0E=_iGizrDNR_Udw@mail.gmail.com/

It is related to HDMI, but I guess a lot of things are valid for DP, too.

Anyway, we need to get this series merged. Otherwise we can't work on
fixing all the other issues on top.

WARNING: multiple messages have this Message-ID (diff)
From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	Marek Vasut <marex@denx.de>,
	Jagan Teki <jagan@amarulasolutions.com>
Cc: Laurent.pinchart@ideasonboard.com, aford173@gmail.com,
	andrzej.hajda@intel.com, dri-devel@lists.freedesktop.org,
	inki.dae@samsung.com, kyungmin.park@samsung.com,
	linux-amarula@amarulasolutions.com,
	linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
	linux-samsung-soc@vger.kernel.org, m.szyprowski@samsung.com,
	matteo.lisi@engicam.com, sw0312.kim@samsung.com,
	tharvey@gateworks.com
Subject: Re: [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge
Date: Wed, 22 Feb 2023 11:05:09 +0100	[thread overview]
Message-ID: <657fa528-ca01-0c6a-2c2b-bb7f4a95096d@kontron.de> (raw)
In-Reply-To: <b246aae9-b719-02f9-dd0f-305b74611fab@prevas.dk>

On 17.02.23 19:22, Rasmus Villemoes wrote:
> On 07/02/2023 10.09, Rasmus Villemoes wrote:
> 
>> I managed to get the whole chain lcdif -> mipi -> bridge -> dp-connector
>> to probe with these settings
>>
> [...]
>> Now hotplug-detect doesn't work with the current sn65dsi86 driver, but
>> that's a separate issue; when I boot with a monitor attached, its edid
>> is correctly read out. But I still don't get any output, and the monitor
>> says "no signal" - my naive attempt (which has worked fine in other
>> cases) was to just dd /dev/urandom to /dev/fb0, so I'm clearly missing
>> some important step.
> 
> No idea if it's important, but in the NXP kernel, there's a
> 
> 	display-subsystem {
> 		compatible = "fsl,imx-display-subsystem";
> 		ports = <&lcdif1_disp>,
> 			<&lcdif2_disp>,
> 			<&lcdif3_disp>;
> 	};
> 
> node in imx8mp.dtsi, and when commenting out that node, the graphics
> ceases to work, even if all the devices in the lcdif->mipi->bridge chain
> actually probes. However, adding a corresponding node in mainline, which
> does have a driver for that "fsl,imx-display-subsystem", makes no
> difference; with or without that, I do get a /dev/fb0 device and the
> whole chain probes, but again the monitor says no signal.

The NXP kernel is completely different. AFAIK it uses the component
helpers to bundle all subdrivers from a central driver
(display-subsystem). This is not how the mainline approach using the
bridge driver interface works. So you can't compare them.

Did you look at this extensive thread with findings from Adam?

https://lore.kernel.org/lkml/CAHCN7xJ=N1vWVTBjArskJ59fyaLzmAGWfc0E=_iGizrDNR_Udw@mail.gmail.com/

It is related to HDMI, but I guess a lot of things are valid for DP, too.

Anyway, we need to get this series merged. Otherwise we can't work on
fixing all the other issues on top.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	Marek Vasut <marex@denx.de>,
	Jagan Teki <jagan@amarulasolutions.com>
Cc: linux-samsung-soc@vger.kernel.org, matteo.lisi@engicam.com,
	linux-amarula@amarulasolutions.com, sw0312.kim@samsung.com,
	dri-devel@lists.freedesktop.org, kyungmin.park@samsung.com,
	Laurent.pinchart@ideasonboard.com, andrzej.hajda@intel.com,
	m.szyprowski@samsung.com, aford173@gmail.com,
	linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com
Subject: Re: [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge
Date: Wed, 22 Feb 2023 11:05:09 +0100	[thread overview]
Message-ID: <657fa528-ca01-0c6a-2c2b-bb7f4a95096d@kontron.de> (raw)
In-Reply-To: <b246aae9-b719-02f9-dd0f-305b74611fab@prevas.dk>

On 17.02.23 19:22, Rasmus Villemoes wrote:
> On 07/02/2023 10.09, Rasmus Villemoes wrote:
> 
>> I managed to get the whole chain lcdif -> mipi -> bridge -> dp-connector
>> to probe with these settings
>>
> [...]
>> Now hotplug-detect doesn't work with the current sn65dsi86 driver, but
>> that's a separate issue; when I boot with a monitor attached, its edid
>> is correctly read out. But I still don't get any output, and the monitor
>> says "no signal" - my naive attempt (which has worked fine in other
>> cases) was to just dd /dev/urandom to /dev/fb0, so I'm clearly missing
>> some important step.
> 
> No idea if it's important, but in the NXP kernel, there's a
> 
> 	display-subsystem {
> 		compatible = "fsl,imx-display-subsystem";
> 		ports = <&lcdif1_disp>,
> 			<&lcdif2_disp>,
> 			<&lcdif3_disp>;
> 	};
> 
> node in imx8mp.dtsi, and when commenting out that node, the graphics
> ceases to work, even if all the devices in the lcdif->mipi->bridge chain
> actually probes. However, adding a corresponding node in mainline, which
> does have a driver for that "fsl,imx-display-subsystem", makes no
> difference; with or without that, I do get a /dev/fb0 device and the
> whole chain probes, but again the monitor says no signal.

The NXP kernel is completely different. AFAIK it uses the component
helpers to bundle all subdrivers from a central driver
(display-subsystem). This is not how the mainline approach using the
bridge driver interface works. So you can't compare them.

Did you look at this extensive thread with findings from Adam?

https://lore.kernel.org/lkml/CAHCN7xJ=N1vWVTBjArskJ59fyaLzmAGWfc0E=_iGizrDNR_Udw@mail.gmail.com/

It is related to HDMI, but I guess a lot of things are valid for DP, too.

Anyway, we need to get this series merged. Otherwise we can't work on
fixing all the other issues on top.

  reply	other threads:[~2023-02-22 10:05 UTC|newest]

Thread overview: 133+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26 14:44 [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge Jagan Teki
2023-01-26 14:44 ` Jagan Teki
2023-01-26 14:44 ` Jagan Teki
2023-01-26 14:44 ` [PATCH v12 01/18] drm: of: Lookup if child node has DSI panel or bridge Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44 ` [PATCH v12 02/18] drm: bridge: panel: Add devm_drm_of_dsi_get_bridge helper Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:47   ` Maxime Ripard
2023-01-26 14:47     ` Maxime Ripard
2023-01-26 14:47     ` Maxime Ripard
2023-01-26 14:58     ` Jagan Teki
2023-01-26 14:58       ` Jagan Teki
2023-01-26 14:58       ` Jagan Teki
2023-01-26 14:44 ` [PATCH v12 03/18] drm: exynos: dsi: Drop explicit call to bridge detach Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44 ` [PATCH v12 04/18] drm: exynos: dsi: Switch to devm_drm_of_dsi_get_bridge Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44 ` [PATCH v12 05/18] drm: exynos: dsi: Mark PHY as optional Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44 ` [PATCH v12 06/18] drm: exynos: dsi: Add platform PLL_P (PMS_P) offset Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44 ` [PATCH v12 07/18] drm: exynos: dsi: Introduce hw_type platform data Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44 ` [PATCH v12 08/18] drm: exynos: dsi: Handle proper host initialization Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44 ` [PATCH v12 09/18] drm: exynos: dsi: Add atomic check Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44 ` [PATCH v12 10/18] drm: exynos: dsi: Add input_bus_flags Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44 ` [PATCH v12 11/18] drm: exynos: dsi: Add atomic_get_input_bus_fmts Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 15:29   ` Marek Vasut
2023-01-26 15:29     ` Marek Vasut
2023-01-26 15:29     ` Marek Vasut
2023-01-26 14:44 ` [PATCH v12 12/18] drm: exynos: dsi: Consolidate component and bridge Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44 ` [PATCH v12 13/18] drm: exynos: dsi: Add host helper for te_irq_handler Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44 ` [PATCH v12 14/18] drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge Jagan Teki
2023-01-26 14:44 ` [PATCH v12 15/18] dt-bindings: display: exynos: dsim: Add NXP i.MX8M Mini/Nano support Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44 ` [PATCH v12 16/18] drm: bridge: samsung-dsim: Add " Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44 ` [PATCH v12 17/18] dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44 ` [PATCH v12 18/18] drm: bridge: samsung-dsim: Add " Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-26 14:44   ` Jagan Teki
2023-01-27 10:33 ` [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge Rasmus Villemoes
2023-01-27 10:33   ` Rasmus Villemoes
2023-01-27 10:33   ` Rasmus Villemoes
2023-01-27 10:39   ` Jagan Teki
2023-01-27 10:39     ` Jagan Teki
2023-01-27 10:39     ` Jagan Teki
2023-01-27 10:56     ` Rasmus Villemoes
2023-01-27 10:56       ` Rasmus Villemoes
2023-01-27 10:56       ` Rasmus Villemoes
2023-01-27 11:04       ` Jagan Teki
2023-01-27 11:04         ` Jagan Teki
2023-01-27 11:04         ` Jagan Teki
2023-01-27 11:30         ` Marek Vasut
2023-01-27 11:30           ` Marek Vasut
2023-01-27 11:30           ` Marek Vasut
2023-01-30 12:45           ` Rasmus Villemoes
2023-01-30 12:45             ` Rasmus Villemoes
2023-01-30 12:45             ` Rasmus Villemoes
2023-01-31  7:27             ` Alexander Stein
2023-01-31  7:27               ` Alexander Stein
2023-01-31  7:27               ` Alexander Stein
2023-02-01 22:00             ` Marek Vasut
2023-02-01 22:00               ` Marek Vasut
2023-02-01 22:00               ` Marek Vasut
2023-02-03 12:29               ` Rasmus Villemoes
2023-02-03 12:29                 ` Rasmus Villemoes
2023-02-03 12:29                 ` Rasmus Villemoes
2023-02-06  8:11                 ` Frieder Schrempf
2023-02-06  8:11                   ` Frieder Schrempf
2023-02-06  8:11                   ` Frieder Schrempf
2023-02-07  9:09                   ` Rasmus Villemoes
2023-02-07  9:09                     ` Rasmus Villemoes
2023-02-07  9:09                     ` Rasmus Villemoes
2023-02-07  9:23                     ` Marek Vasut
2023-02-07  9:23                       ` Marek Vasut
2023-02-07  9:23                       ` Marek Vasut
2023-02-14 10:55                       ` Rasmus Villemoes
2023-02-14 10:55                         ` Rasmus Villemoes
2023-02-14 10:55                         ` Rasmus Villemoes
2023-02-14 11:08                         ` Rasmus Villemoes
2023-02-14 11:08                           ` Rasmus Villemoes
2023-02-14 11:08                           ` Rasmus Villemoes
2023-02-14 11:09                         ` Fabio Estevam
2023-02-14 11:09                           ` Fabio Estevam
2023-02-14 11:09                           ` Fabio Estevam
2023-02-14 11:11                           ` Fabio Estevam
2023-02-14 11:11                             ` Fabio Estevam
2023-02-14 11:11                             ` Fabio Estevam
2023-02-17  8:55                           ` Rasmus Villemoes
2023-02-17  8:55                             ` Rasmus Villemoes
2023-02-17  8:55                             ` Rasmus Villemoes
2023-02-17 10:05                             ` Alexander Stein
2023-02-17 10:05                               ` Alexander Stein
2023-02-17 10:05                               ` Alexander Stein
2023-02-17 18:22                     ` Rasmus Villemoes
2023-02-17 18:22                       ` Rasmus Villemoes
2023-02-17 18:22                       ` Rasmus Villemoes
2023-02-22 10:05                       ` Frieder Schrempf [this message]
2023-02-22 10:05                         ` Frieder Schrempf
2023-02-22 10:05                         ` Frieder Schrempf
2023-02-24 14:08                         ` Rasmus Villemoes
2023-02-24 14:08                           ` Rasmus Villemoes
2023-02-24 14:08                           ` Rasmus Villemoes
2023-02-24 15:00                           ` Adam Ford
2023-02-24 15:00                             ` Adam Ford
2023-02-24 15:00                             ` Adam Ford
2023-02-01  8:37 ` Frieder Schrempf
2023-02-01  8:37   ` Frieder Schrempf
2023-02-01  8:37   ` Frieder Schrempf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=657fa528-ca01-0c6a-2c2b-bb7f4a95096d@kontron.de \
    --to=frieder.schrempf@kontron.de \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=aford173@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=inki.dae@samsung.com \
    --cc=jagan@amarulasolutions.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=marex@denx.de \
    --cc=matteo.lisi@engicam.com \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=sw0312.kim@samsung.com \
    --cc=tharvey@gateworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.