From: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
To: Cristian Marussi <cristian.marussi@arm.com>,
Etienne Carriere <etienne.carriere@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
Heiko Stuebner <heiko@sntech.de>, Liang Chen <cl@rock-chips.com>,
linux-kernel@vger.kernel.org,
Kever Yang <kever.yang@rock-chips.com>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
Peter Geis <pgwipeout@gmail.com>
Subject: Re: [BUG] New arm scmi check in linux-next causing rk3568 not to boot due to firmware bug
Date: Thu, 12 May 2022 13:11:22 +0200 [thread overview]
Message-ID: <6587375.6lpfYT6tjA@archbook> (raw)
In-Reply-To: <CAN5uoS_MgBiTVZCRSZyYCH4cnUZD_bHj2+mZu661bFV8TKWScw@mail.gmail.com>
Hello,
sorry for the late reply, completely missed that there was a question
for me in this mail.
On Donnerstag, 5. Mai 2022 11:40:09 CEST Etienne Carriere wrote:
> Hello Nicolas, Cristian,
> [...]
>
> Indeed the firmware implementation is wrong in TF-A.
> And also in OP-TEE by the way:
> https://github.com/OP-TEE/optee_os/blob/3.17.0/core/drivers/scmi-msg/base.c#L163-L166
>
> @Nicoals, do you want to send a patch to TF-A, or do you want me to do it?
I have no experience with TF-A, so I'd prefer if you could do it.
In good news, Rockchip has confirmed they're preparing to release RK356x
TF-A sources, so I'll be able to port the patch over to their sources once
they are released, if they don't already apply it themselves.
>
> I can fix the optee_os implementation. I'll tell you when I'll have
> created a P-R.
> The fix is the same for TF-A and OP-TEE.
> Proposal from Cristian looks good to me, maybe simplified:
>
> ```patch
> memcpy(outargs, &p2a, sizeof(p2a));
> memcpy(outargs + sizeof(p2a), list + a2p->skip, count);
>
> - scmi_write_response(msg, outargs, sizeof(outargs));
> + list_sz = (1 + (count - 1) / sizeof(uint32_t)) * sizeof(uint32_t);
> + scmi_write_response(msg, outargs, sizeof(p2a) + list_sz);
> ```
> [...]
>
> BR,
> Etienne
Regards,
Nicolas Frattaroli
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
To: Cristian Marussi <cristian.marussi@arm.com>,
Etienne Carriere <etienne.carriere@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
Heiko Stuebner <heiko@sntech.de>, Liang Chen <cl@rock-chips.com>,
linux-kernel@vger.kernel.org,
Kever Yang <kever.yang@rock-chips.com>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
Peter Geis <pgwipeout@gmail.com>
Subject: Re: [BUG] New arm scmi check in linux-next causing rk3568 not to boot due to firmware bug
Date: Thu, 12 May 2022 13:11:22 +0200 [thread overview]
Message-ID: <6587375.6lpfYT6tjA@archbook> (raw)
In-Reply-To: <CAN5uoS_MgBiTVZCRSZyYCH4cnUZD_bHj2+mZu661bFV8TKWScw@mail.gmail.com>
Hello,
sorry for the late reply, completely missed that there was a question
for me in this mail.
On Donnerstag, 5. Mai 2022 11:40:09 CEST Etienne Carriere wrote:
> Hello Nicolas, Cristian,
> [...]
>
> Indeed the firmware implementation is wrong in TF-A.
> And also in OP-TEE by the way:
> https://github.com/OP-TEE/optee_os/blob/3.17.0/core/drivers/scmi-msg/base.c#L163-L166
>
> @Nicoals, do you want to send a patch to TF-A, or do you want me to do it?
I have no experience with TF-A, so I'd prefer if you could do it.
In good news, Rockchip has confirmed they're preparing to release RK356x
TF-A sources, so I'll be able to port the patch over to their sources once
they are released, if they don't already apply it themselves.
>
> I can fix the optee_os implementation. I'll tell you when I'll have
> created a P-R.
> The fix is the same for TF-A and OP-TEE.
> Proposal from Cristian looks good to me, maybe simplified:
>
> ```patch
> memcpy(outargs, &p2a, sizeof(p2a));
> memcpy(outargs + sizeof(p2a), list + a2p->skip, count);
>
> - scmi_write_response(msg, outargs, sizeof(outargs));
> + list_sz = (1 + (count - 1) / sizeof(uint32_t)) * sizeof(uint32_t);
> + scmi_write_response(msg, outargs, sizeof(p2a) + list_sz);
> ```
> [...]
>
> BR,
> Etienne
Regards,
Nicolas Frattaroli
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
To: Cristian Marussi <cristian.marussi@arm.com>,
Etienne Carriere <etienne.carriere@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
Heiko Stuebner <heiko@sntech.de>, Liang Chen <cl@rock-chips.com>,
linux-kernel@vger.kernel.org,
Kever Yang <kever.yang@rock-chips.com>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
Peter Geis <pgwipeout@gmail.com>
Subject: Re: [BUG] New arm scmi check in linux-next causing rk3568 not to boot due to firmware bug
Date: Thu, 12 May 2022 13:11:22 +0200 [thread overview]
Message-ID: <6587375.6lpfYT6tjA@archbook> (raw)
In-Reply-To: <CAN5uoS_MgBiTVZCRSZyYCH4cnUZD_bHj2+mZu661bFV8TKWScw@mail.gmail.com>
Hello,
sorry for the late reply, completely missed that there was a question
for me in this mail.
On Donnerstag, 5. Mai 2022 11:40:09 CEST Etienne Carriere wrote:
> Hello Nicolas, Cristian,
> [...]
>
> Indeed the firmware implementation is wrong in TF-A.
> And also in OP-TEE by the way:
> https://github.com/OP-TEE/optee_os/blob/3.17.0/core/drivers/scmi-msg/base.c#L163-L166
>
> @Nicoals, do you want to send a patch to TF-A, or do you want me to do it?
I have no experience with TF-A, so I'd prefer if you could do it.
In good news, Rockchip has confirmed they're preparing to release RK356x
TF-A sources, so I'll be able to port the patch over to their sources once
they are released, if they don't already apply it themselves.
>
> I can fix the optee_os implementation. I'll tell you when I'll have
> created a P-R.
> The fix is the same for TF-A and OP-TEE.
> Proposal from Cristian looks good to me, maybe simplified:
>
> ```patch
> memcpy(outargs, &p2a, sizeof(p2a));
> memcpy(outargs + sizeof(p2a), list + a2p->skip, count);
>
> - scmi_write_response(msg, outargs, sizeof(outargs));
> + list_sz = (1 + (count - 1) / sizeof(uint32_t)) * sizeof(uint32_t);
> + scmi_write_response(msg, outargs, sizeof(p2a) + list_sz);
> ```
> [...]
>
> BR,
> Etienne
Regards,
Nicolas Frattaroli
next prev parent reply other threads:[~2022-05-12 11:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 12:49 [BUG] New arm scmi check in linux-next causing rk3568 not to boot due to firmware bug Nicolas Frattaroli
2022-05-04 12:49 ` Nicolas Frattaroli
2022-05-04 12:49 ` Nicolas Frattaroli
2022-05-04 13:21 ` Sudeep Holla
2022-05-04 13:21 ` Sudeep Holla
2022-05-04 13:21 ` Sudeep Holla
2022-05-04 17:51 ` Nicolas Frattaroli
2022-05-04 17:51 ` Nicolas Frattaroli
2022-05-04 17:51 ` Nicolas Frattaroli
2022-05-05 8:03 ` Cristian Marussi
2022-05-05 8:03 ` Cristian Marussi
2022-05-05 8:03 ` Cristian Marussi
2022-05-05 9:40 ` Etienne Carriere
2022-05-05 9:40 ` Etienne Carriere
2022-05-05 9:40 ` Etienne Carriere
2022-05-05 10:10 ` Sudeep Holla
2022-05-05 10:10 ` Sudeep Holla
2022-05-05 10:10 ` Sudeep Holla
2022-05-05 13:42 ` Nicolas Frattaroli
2022-05-05 13:42 ` Nicolas Frattaroli
2022-05-05 13:42 ` Nicolas Frattaroli
2022-05-05 10:47 ` Cristian Marussi
2022-05-05 10:47 ` Cristian Marussi
2022-05-05 10:47 ` Cristian Marussi
2022-05-05 14:21 ` Cristian Marussi
2022-05-05 14:21 ` Cristian Marussi
2022-05-05 14:21 ` Cristian Marussi
2022-05-12 11:11 ` Nicolas Frattaroli [this message]
2022-05-12 11:11 ` Nicolas Frattaroli
2022-05-12 11:11 ` Nicolas Frattaroli
2022-05-12 14:34 ` Sudeep Holla
2022-05-12 14:34 ` Sudeep Holla
2022-05-12 14:34 ` Sudeep Holla
2022-05-13 8:44 ` Kever Yang
2022-05-13 8:44 ` Kever Yang
2022-05-13 8:44 ` Kever Yang
2022-05-13 8:58 ` Etienne Carriere
2022-05-13 8:58 ` Etienne Carriere
2022-05-13 8:58 ` Etienne Carriere
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6587375.6lpfYT6tjA@archbook \
--to=frattaroli.nicolas@gmail.com \
--cc=cl@rock-chips.com \
--cc=cristian.marussi@arm.com \
--cc=etienne.carriere@linaro.org \
--cc=heiko@sntech.de \
--cc=jeffy.chen@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.