All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] DM RAID: Remove duplicate code.
@ 2012-06-26  8:55 Jonathan Brassow
  2012-07-04  1:14 ` Alasdair G Kergon
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Brassow @ 2012-06-26  8:55 UTC (permalink / raw)
  To: dm-devel

dm-raid: Remove duplicate code.

Code must have gotten pasted in twice somehow.  Remove redundant chunk.

Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>

Index: linux-upstream/drivers/md/dm-raid.c
===================================================================
--- linux-upstream.orig/drivers/md/dm-raid.c
+++ linux-upstream/drivers/md/dm-raid.c
@@ -526,11 +526,6 @@ static int parse_raid_params(struct raid
 	else
 		rs->ti->split_io = region_size;
 
-	if (rs->md.chunk_sectors)
-		rs->ti->split_io = rs->md.chunk_sectors;
-	else
-		rs->ti->split_io = region_size;
-
 	/* Assume there are no metadata devices until the drives are parsed */
 	rs->md.persistent = 0;
 	rs->md.external = 1;

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] DM RAID: Remove duplicate code.
  2012-06-26  8:55 [PATCH] DM RAID: Remove duplicate code Jonathan Brassow
@ 2012-07-04  1:14 ` Alasdair G Kergon
  2012-07-04  4:02   ` Brassow Jonathan
  0 siblings, 1 reply; 3+ messages in thread
From: Alasdair G Kergon @ 2012-07-04  1:14 UTC (permalink / raw)
  To: device-mapper development

On Tue, Jun 26, 2012 at 03:55:41AM -0500, Jon Brassow wrote:
> dm-raid: Remove duplicate code.
> Code must have gotten pasted in twice somehow.  Remove redundant chunk.
 
I think that change is already in linux-next.

Alasdair

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] DM RAID: Remove duplicate code.
  2012-07-04  1:14 ` Alasdair G Kergon
@ 2012-07-04  4:02   ` Brassow Jonathan
  0 siblings, 0 replies; 3+ messages in thread
From: Brassow Jonathan @ 2012-07-04  4:02 UTC (permalink / raw)
  To: device-mapper development


On Jul 3, 2012, at 8:14 PM, Alasdair G Kergon wrote:

> On Tue, Jun 26, 2012 at 03:55:41AM -0500, Jon Brassow wrote:
>> dm-raid: Remove duplicate code.
>> Code must have gotten pasted in twice somehow.  Remove redundant chunk.
> 
> I think that change is already in linux-next.

yup, in dm-support-non-power-of-two-target-max_io_len.patch.

Thanks,
 brassow

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-07-04  4:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-26  8:55 [PATCH] DM RAID: Remove duplicate code Jonathan Brassow
2012-07-04  1:14 ` Alasdair G Kergon
2012-07-04  4:02   ` Brassow Jonathan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.