All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karthikeyan periyasamy <periyasa@codeaurora.org>
To: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
	Miles Hu <milehu@codeaurora.org>, John Crispin <john@phrozen.org>,
	pradeepc=codeaurora.org@codeaurora.org
Subject: Re: [PATCH v7 1/3] ath11k: switch to using ieee80211_tx_status_ext()
Date: Mon, 15 Mar 2021 22:13:04 +0530	[thread overview]
Message-ID: <65a8f70609a1758611c97205abd205f2@codeaurora.org> (raw)
In-Reply-To: <20210305230337.23047-2-pradeepc@codeaurora.org>

> --- a/drivers/net/wireless/ath/ath11k/dp_tx.c
> +++ b/drivers/net/wireless/ath/ath11k/dp_tx.c
> @@ -417,9 +417,12 @@ static void ath11k_dp_tx_complete_msdu(struct 
> ath11k *ar,
>  				       struct sk_buff *msdu,
>  				       struct hal_tx_status *ts)
>  {
> +	struct ieee80211_tx_status status = { 0 };
>  	struct ath11k_base *ab = ar->ab;
>  	struct ieee80211_tx_info *info;
>  	struct ath11k_skb_cb *skb_cb;
> +	struct ath11k_peer *peer;
> +	struct ath11k_sta *arsta;
> 
>  	if (WARN_ON_ONCE(ts->buf_rel_source != HAL_WBM_REL_SRC_MODULE_TQM)) {
>  		/* Must not happen */
> @@ -483,13 +486,22 @@ static void ath11k_dp_tx_complete_msdu(struct 
> ath11k *ar,
>  		ath11k_dp_tx_cache_peer_stats(ar, msdu, ts);
>  	}
> 
> -	/* NOTE: Tx rate status reporting. Tx completion status does not have
> -	 * necessary information (for example nss) to build the tx rate.
> -	 * Might end up reporting it out-of-band from HTT stats.
> -	 */
> -
> -	ieee80211_tx_status(ar->hw, msdu);
> -
> +	spin_lock_bh(&ab->base_lock);
> +	peer = ath11k_peer_find_by_id(ab, ts->peer_id);
> +	if (peer) {
> +		arsta = (struct ath11k_sta *)peer->sta->drv_priv;
> +		status.sta = peer->sta;
> +		status.skb = msdu;
> +		status.info = info;
> +		status.rate = &arsta->last_txrate;
> +	}
> +	rcu_read_unlock();
> +	if (peer)
> +		ieee80211_tx_status_ext(ar->hw, &status);
> +	else
> +		dev_kfree_skb_any(msdu);
> +	spin_unlock_bh(&ab->base_lock);

Why ieee80211_tx_status_ext() kept under spin_lock?

Thanks,
Karthikeyan P

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Karthikeyan periyasamy <periyasa@codeaurora.org>
To: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
	Miles Hu <milehu@codeaurora.org>, John Crispin <john@phrozen.org>,
	pradeepc=codeaurora.org@codeaurora.org
Subject: Re: [PATCH v7 1/3] ath11k: switch to using ieee80211_tx_status_ext()
Date: Mon, 15 Mar 2021 22:13:04 +0530	[thread overview]
Message-ID: <65a8f70609a1758611c97205abd205f2@codeaurora.org> (raw)
In-Reply-To: <20210305230337.23047-2-pradeepc@codeaurora.org>

> --- a/drivers/net/wireless/ath/ath11k/dp_tx.c
> +++ b/drivers/net/wireless/ath/ath11k/dp_tx.c
> @@ -417,9 +417,12 @@ static void ath11k_dp_tx_complete_msdu(struct 
> ath11k *ar,
>  				       struct sk_buff *msdu,
>  				       struct hal_tx_status *ts)
>  {
> +	struct ieee80211_tx_status status = { 0 };
>  	struct ath11k_base *ab = ar->ab;
>  	struct ieee80211_tx_info *info;
>  	struct ath11k_skb_cb *skb_cb;
> +	struct ath11k_peer *peer;
> +	struct ath11k_sta *arsta;
> 
>  	if (WARN_ON_ONCE(ts->buf_rel_source != HAL_WBM_REL_SRC_MODULE_TQM)) {
>  		/* Must not happen */
> @@ -483,13 +486,22 @@ static void ath11k_dp_tx_complete_msdu(struct 
> ath11k *ar,
>  		ath11k_dp_tx_cache_peer_stats(ar, msdu, ts);
>  	}
> 
> -	/* NOTE: Tx rate status reporting. Tx completion status does not have
> -	 * necessary information (for example nss) to build the tx rate.
> -	 * Might end up reporting it out-of-band from HTT stats.
> -	 */
> -
> -	ieee80211_tx_status(ar->hw, msdu);
> -
> +	spin_lock_bh(&ab->base_lock);
> +	peer = ath11k_peer_find_by_id(ab, ts->peer_id);
> +	if (peer) {
> +		arsta = (struct ath11k_sta *)peer->sta->drv_priv;
> +		status.sta = peer->sta;
> +		status.skb = msdu;
> +		status.info = info;
> +		status.rate = &arsta->last_txrate;
> +	}
> +	rcu_read_unlock();
> +	if (peer)
> +		ieee80211_tx_status_ext(ar->hw, &status);
> +	else
> +		dev_kfree_skb_any(msdu);
> +	spin_unlock_bh(&ab->base_lock);

Why ieee80211_tx_status_ext() kept under spin_lock?

Thanks,
Karthikeyan P

  reply	other threads:[~2021-03-15 16:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05 23:03 [PATCH v7 0/3] ath11k: add HE radiotap header support Pradeep Kumar Chitrapu
2021-03-05 23:03 ` Pradeep Kumar Chitrapu
2021-03-05 23:03 ` [PATCH v7 1/3] ath11k: switch to using ieee80211_tx_status_ext() Pradeep Kumar Chitrapu
2021-03-05 23:03   ` Pradeep Kumar Chitrapu
2021-03-15 16:43   ` Karthikeyan periyasamy [this message]
2021-03-15 16:43     ` Karthikeyan periyasamy
2021-03-18 20:24     ` Pradeep Kumar Chitrapu
2021-03-18 20:24       ` Pradeep Kumar Chitrapu
2021-03-05 23:03 ` [PATCH v7 2/3] ath11k: decode HE status tlv Pradeep Kumar Chitrapu
2021-03-05 23:03   ` Pradeep Kumar Chitrapu
2021-03-05 23:03 ` [PATCH v7 3/3] ath11k: translate HE status to radiotap format Pradeep Kumar Chitrapu
2021-03-05 23:03   ` Pradeep Kumar Chitrapu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65a8f70609a1758611c97205abd205f2@codeaurora.org \
    --to=periyasa@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=john@phrozen.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=milehu@codeaurora.org \
    --cc=pradeepc=codeaurora.org@codeaurora.org \
    --cc=pradeepc@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.