All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Marangi <ansuelsmth@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Russell King <linux@armlinux.org.uk>,
	Arnd Bergmann <arnd@arndb.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Randy Dunlap <rdunlap@infradead.org>,
	"Mike Rapoport (IBM)" <rppt@kernel.org>,
	Eric DeVolder <eric.devolder@oracle.com>,
	Nathan Chancellor <nathan@kernel.org>,
	"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
	Kees Cook <keescook@chromium.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	John Crispin <john@phrozen.org>
Subject: Re: [PATCH 2/2] ARM: decompressor: add option to ignore MEM ATAGs
Date: Sat, 20 Jan 2024 18:00:32 +0100	[thread overview]
Message-ID: <65abfc33.df0a0220.65bf1.4e35@mx.google.com> (raw)
In-Reply-To: <CACRpkdaR_gtW6VmenfV5=xounqV18-kZyNprJUtLWkpgXUnkvA@mail.gmail.com>

On Sat, Jan 20, 2024 at 12:52:33PM +0100, Linus Walleij wrote:
> On Fri, Jan 19, 2024 at 9:14 PM Christian Marangi <ansuelsmth@gmail.com> wrote:
> 
> > +#if defined(CONFIG_ARM_ATAG_DTB_COMPAT_IGNORE_MEM)
> > +#define do_ignore_mem 1
> > +#else
> > +#define do_ignore_mem 0
> > +#endif
> 
> Is there a reason why you can't just use:
> 
> if (IS_ENABLED(CONFIG_ARM_ATAG_DTB_COMPAT_IGNORE_MEM))
> in the code?
> 

Was following the pattern, yes I can totally do this change... Will send
a v2 with this changed.

Since the first patch has to be regression tested, is it ok to add the
Tag in v2 or I should wait that to send v2?

-- 
	Ansuel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Christian Marangi <ansuelsmth@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Russell King <linux@armlinux.org.uk>,
	Arnd Bergmann <arnd@arndb.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Randy Dunlap <rdunlap@infradead.org>,
	"Mike Rapoport (IBM)" <rppt@kernel.org>,
	Eric DeVolder <eric.devolder@oracle.com>,
	Nathan Chancellor <nathan@kernel.org>,
	"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
	Kees Cook <keescook@chromium.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	John Crispin <john@phrozen.org>
Subject: Re: [PATCH 2/2] ARM: decompressor: add option to ignore MEM ATAGs
Date: Sat, 20 Jan 2024 18:00:32 +0100	[thread overview]
Message-ID: <65abfc33.df0a0220.65bf1.4e35@mx.google.com> (raw)
In-Reply-To: <CACRpkdaR_gtW6VmenfV5=xounqV18-kZyNprJUtLWkpgXUnkvA@mail.gmail.com>

On Sat, Jan 20, 2024 at 12:52:33PM +0100, Linus Walleij wrote:
> On Fri, Jan 19, 2024 at 9:14 PM Christian Marangi <ansuelsmth@gmail.com> wrote:
> 
> > +#if defined(CONFIG_ARM_ATAG_DTB_COMPAT_IGNORE_MEM)
> > +#define do_ignore_mem 1
> > +#else
> > +#define do_ignore_mem 0
> > +#endif
> 
> Is there a reason why you can't just use:
> 
> if (IS_ENABLED(CONFIG_ARM_ATAG_DTB_COMPAT_IGNORE_MEM))
> in the code?
> 

Was following the pattern, yes I can totally do this change... Will send
a v2 with this changed.

Since the first patch has to be regression tested, is it ok to add the
Tag in v2 or I should wait that to send v2?

-- 
	Ansuel

  reply	other threads:[~2024-01-20 17:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-19 20:12 [PATCH 0/2] ARM: decompressor: support AUTO_ZRELADDR and appended DTB Christian Marangi
2024-01-19 20:12 ` Christian Marangi
2024-01-19 20:12 ` [PATCH 1/2] ARM: decompressor: support memory start validation for " Christian Marangi
2024-01-19 20:12   ` Christian Marangi
2024-01-20 11:15   ` Geert Uytterhoeven
2024-01-20 11:15     ` Geert Uytterhoeven
2024-01-20 11:48   ` Linus Walleij
2024-01-20 11:48     ` Linus Walleij
2024-01-19 20:12 ` [PATCH 2/2] ARM: decompressor: add option to ignore MEM ATAGs Christian Marangi
2024-01-19 20:12   ` Christian Marangi
2024-01-20 11:51   ` Linus Walleij
2024-01-20 11:51     ` Linus Walleij
2024-01-20 16:57     ` Christian Marangi
2024-01-20 16:57       ` Christian Marangi
2024-01-20 11:52   ` Linus Walleij
2024-01-20 11:52     ` Linus Walleij
2024-01-20 17:00     ` Christian Marangi [this message]
2024-01-20 17:00       ` Christian Marangi
2024-01-21 19:37       ` Linus Walleij
2024-01-21 19:37         ` Linus Walleij
2024-01-20 11:19 ` [PATCH 0/2] ARM: decompressor: support AUTO_ZRELADDR and appended DTB Geert Uytterhoeven
2024-01-20 11:19   ` Geert Uytterhoeven
2024-01-20 17:10   ` Christian Marangi
2024-01-20 17:10     ` Christian Marangi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65abfc33.df0a0220.65bf1.4e35@mx.google.com \
    --to=ansuelsmth@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andersson@kernel.org \
    --cc=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=eric.devolder@oracle.com \
    --cc=geert+renesas@glider.be \
    --cc=john@phrozen.org \
    --cc=keescook@chromium.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=konrad.dybcio@somainline.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=nathan@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=rppt@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.