[PATCH BlueZ v1 1/2] bap: Add missing Metadata property

[PATCH BlueZ v1 1/2] bap: Add missing Metadata property

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This adds missing Metadata property to MediaEndpoint objects.
---
 profiles/audio/bap.c | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c
index 63bdbb52a53c..6184c9d178a8 100644
--- a/profiles/audio/bap.c
+++ b/profiles/audio/bap.c
@@ -255,6 +255,39 @@ static gboolean get_capabilities(const GDBusPropertyTable *property,
 	return TRUE;
 }
 
+static gboolean has_metadata(const GDBusPropertyTable *property, void *data)
+{
+	struct bap_ep *ep = data;
+	struct iovec *d = NULL;
+
+	bt_bap_pac_get_codec(ep->rpac, NULL, NULL, &d);
+
+	if (d)
+		return TRUE;
+
+	return FALSE;
+}
+
+static gboolean get_metadata(const GDBusPropertyTable *property,
+					DBusMessageIter *iter, void *data)
+{
+	struct bap_ep *ep = data;
+	DBusMessageIter array;
+	struct iovec *d;
+
+	bt_bap_pac_get_codec(ep->rpac, NULL, NULL, &d);
+
+	dbus_message_iter_open_container(iter, DBUS_TYPE_ARRAY,
+					DBUS_TYPE_BYTE_AS_STRING, &array);
+
+	dbus_message_iter_append_fixed_array(&array, DBUS_TYPE_BYTE,
+						&d->iov_base, d->iov_len);
+
+	dbus_message_iter_close_container(iter, &array);
+
+	return TRUE;
+}
+
 static gboolean get_device(const GDBusPropertyTable *property,
 					DBusMessageIter *iter, void *data)
 {
@@ -360,6 +393,8 @@ static const GDBusPropertyTable ep_properties[] = {
 					G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
 	{ "Capabilities", "ay", get_capabilities, NULL, has_capabilities,
 					G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
+	{ "Metadata", "ay", get_metadata, NULL, has_metadata,
+					G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
 	{ "Device", "o", get_device, NULL, NULL,
 					G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
 	{ "Locations", "u", get_locations, NULL, NULL,
-- 
2.43.0

[PATCH BlueZ v1 2/2] bap: Fix not handling out of order responses

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

When EATT is enabled it is possible that response are generated out of
order, since they may come from different sockets/fds, so this attempts
to detect when that happens by checking if the state has already been
changed.
---
 profiles/audio/bap.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c
index 6184c9d178a8..a4036bbbdfa8 100644
--- a/profiles/audio/bap.c
+++ b/profiles/audio/bap.c
@@ -801,8 +801,20 @@ static void config_cb(struct bt_bap_stream *stream,
 
 	setup->id = 0;
 
-	if (!code)
+	if (!code) {
+		/* Check state is already set to config then proceed to qos */
+		if (bt_bap_stream_get_state(stream) ==
+					BT_BAP_STREAM_STATE_CONFIG) {
+			setup->id = bt_bap_stream_qos(stream, &setup->qos,
+							qos_cb, setup);
+			if (!setup->id) {
+				error("Failed to Configure QoS");
+				bt_bap_stream_release(stream, NULL, NULL);
+			}
+		}
+
 		return;
+	}
 
 	if (!setup->msg)
 		return;
-- 
2.43.0

RE: [BlueZ,v1,1/2] bap: Add missing Metadata property

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1139 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=819223

---Test result---

Test Summary:
CheckPatch                    PENDING   118.10 seconds
GitLint                       PENDING   101.29 seconds
BuildEll                      PASS      24.56 seconds
BluezMake                     PASS      790.22 seconds
MakeCheck                     PASS      12.07 seconds
MakeDistcheck                 PASS      164.60 seconds
CheckValgrind                 PASS      226.47 seconds
CheckSmatch                   PASS      342.65 seconds
bluezmakeextell               PASS      110.72 seconds
IncrementalBuild              PASS      1459.06 seconds
ScanBuild                     PASS      977.76 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v1 1/2] bap: Add missing Metadata property

[patchwork-bot+bluetooth]

Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue, 23 Jan 2024 14:04:26 -0500 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This adds missing Metadata property to MediaEndpoint objects.
> ---
>  profiles/audio/bap.c | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)

Here is the summary with links:
  - [BlueZ,v1,1/2] bap: Add missing Metadata property
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=08bf0b2a85f3
  - [BlueZ,v1,2/2] bap: Fix not handling out of order responses
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=d994c9d45dad

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html