From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Jie Yang <yang.jie@linux.intel.com>
Subject: Re: ASoC: Intel: sst: Missing IRQ at index 5 on BYT-T device
Date: Wed, 19 Dec 2018 10:54:55 -0600 [thread overview]
Message-ID: <65b445e8-2202-0554-b920-97ce0f7833ce@linux.intel.com> (raw)
In-Reply-To: <20181219150103.GA52375@gerhold.net>
>
> -static int is_byt_cr(struct device *dev, bool *bytcr)
> +static int is_byt_cr(struct platform_device *pdev, bool *bytcr)
> {
> + struct device *dev = &pdev->dev;
> int status = 0;
>
> + if (platform_get_resource(pdev, IORESOURCE_IRQ, 5) == NULL) {
> + /* This message is even shown if the device would be detected as BYT-CR below */
> + dev_info(dev, "Falling back to Baytrail-CR platform\n");
> + *bytcr = true;
> + return status;
> + }
> +
> if (IS_ENABLED(CONFIG_IOSF_MBI)) {
> u32 bios_status;
This would be my preferred solution but if it doesn't work as Hans
mentions it then we need to think of alternatives.
Baytrail platforms are so different (BIOS and hardware) that I don't
think we'll manage to pull this off without quirks.
next prev parent reply other threads:[~2018-12-19 16:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-16 18:54 ASoC: Intel: sst: Missing IRQ at index 5 on BYT-T device Stephan Gerhold
2018-12-16 19:07 ` Hans de Goede
2018-12-16 22:03 ` Antonio Ospite
2018-12-17 7:53 ` Hans de Goede
2018-12-17 8:25 ` Antonio Ospite
2018-12-17 18:03 ` Stephan Gerhold
2019-01-09 19:22 ` Mark Brown
2019-01-09 21:10 ` Pierre-Louis Bossart
2019-01-09 21:14 ` Mark Brown
2018-12-17 14:52 ` Pierre-Louis Bossart
2018-12-17 18:17 ` Stephan Gerhold
2018-12-17 18:29 ` Pierre-Louis Bossart
2018-12-17 19:10 ` Stephan Gerhold
2018-12-17 19:39 ` Pierre-Louis Bossart
2018-12-17 20:32 ` Stephan Gerhold
2018-12-17 20:43 ` Stephan Gerhold
2018-12-18 2:13 ` Pierre-Louis Bossart
2018-12-19 13:07 ` Stephan Gerhold
2018-12-19 14:04 ` Pierre-Louis Bossart
2018-12-19 14:23 ` Hans de Goede
2018-12-19 20:59 ` Antonio Ospite
2018-12-19 21:51 ` Hans de Goede
2018-12-19 15:01 ` Stephan Gerhold
2018-12-19 16:54 ` Pierre-Louis Bossart [this message]
2018-12-19 17:35 ` Stephan Gerhold
2018-12-19 20:56 ` Antonio Ospite
2019-01-03 10:04 ` Antonio Ospite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65b445e8-2202-0554-b920-97ce0f7833ce@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=stephan@gerhold.net \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.