Re: [PATCH] fix floppy for PAGE_SIZE != 4KB

[Jens Axboe <axboe@kernel.dk>]

On 11/17/25 6:57 AM, René Rebe wrote:
> Hi,
> 
>> On 17. Nov 2025, at 14:23, Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 11/17/25 2:56 AM, Ren? Rebe wrote:
> ...
>>> Any chance we can get my initial one liner constant PAGE_SIZE fix
>>> for this over a decade old bug in? I currently don?t have a budget
>>> to refactor the floppy driver probing for efficiency on bigger PAGE_SIZE
>>> configs I?m not even having a floppy controller on.
>>
>> Yep we can do that. It'd be great if we could augment the change with
>> what commit broke it, so it can get backported to stable kernels as
>> well. Was it:
>>
>> commit fe4ec12e1865a2114056b799e4869bf4c30e47df
>> Author: Christoph Hellwig <hch@lst.de>
>> Date:   Fri Jun 26 10:01:52 2020 +0200
>>
>>    floppy: use block_size
> 
> maybe, but I’m not 100% sure. Probably not the best answer
> for kernel driver development. It might have been broken in
> other ways for over a decade already. I would need to debug
> that to be sure, but then I could also see if I can make it easily
> work without changing the max size constant, ...

I'll just mark it for stable, then at least it'll go to most of
the ones we care about.

-- 
Jens Axboe