Re: [PATCH] fix floppy for PAGE_SIZE != 4KB

[Jens Axboe <axboe@kernel.dk>]

On 11/19/25 2:39 AM, John Paul Adrian Glaubitz wrote:
> Hi,
> 
> On Wed, 2025-11-19 at 10:24 +0100, Ren? Rebe wrote:
>> Hi,
>>
>>> On 19. Nov 2025, at 10:22, John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> wrote:
>>>
>>> On Wed, 2025-11-19 at 10:12 +0100, Ren? Rebe wrote:
>>>>>> Yep we can do that. It'd be great if we could augment the change with
>>>>>> what commit broke it, so it can get backported to stable kernels as
>>>>>> well. Was it:
>>>>>>
>>>>>> commit fe4ec12e1865a2114056b799e4869bf4c30e47df
>>>>>> Author: Christoph Hellwig <hch@lst.de>
>>>>>> Date:   Fri Jun 26 10:01:52 2020 +0200
>>>>>>
>>>>>>   floppy: use block_size
>>>>>
>>>>> Yes, Nick Bowler (CC'ed) bisected it to this commit in [1].
>>>>
>>>> Nice, thanks!
>>>>
>>>> Carefully, it appears to be another commit though:
>>>>
>>>>> I bisected the failure to this old commit:
>>>>>
>>>>>  commit 74d46992e0d9dee7f1f376de0d56d31614c8a17a
>>>>>  Author: Christoph Hellwig <hch@lst.de>
>>>>>  Date:   Wed Aug 23 19:10:32 2017 +0200
>>>>>        block: replace bi_bdev with a gendisk pointer and partitions index
>>>
>>> Yes, you're right. I was briefly distracted when writing this mail.
>>
>> No worries, just checking. Should I send a new patch with the Fixes:
>> or can Jens just add it?
> 
> Jens picked the patch up for his block tree already [1], but he could still take
> a version 2 from you and force-push the new patch to his tree.
> 
> The proper tag would be:
> 
> Fixes: 74d46992e0d9 ("block: replace bi_bdev with a gendisk pointer and partitions index")
> 
> It's up to Jens in any case.

Yeah not doing that for something that went unfixed for 8 years. It's
clearly not that important. Rene will see stable bot rejects as the
author, so I'd suggest just watching for those in a few weeks and
sending in a modified patch. It should go into 5.4, 5.10, 5.15, 6.1,
6.6, and 6.12. Possibly 6.17 unless that gets deprecated before then.

-- 
Jens Axboe