[Buildroot] [PATCH 1/1] support/testing: weston: fix the weston shutdown test

[Buildroot] [PATCH 1/1] support/testing: weston: fix the weston shutdown test

[Julien Olivain]

Commit [1] "support/testing: improve weston test reliability" moved
out the wait time from the emulator (to run on the test controller).

While doing so, the sleep time which was initially _after_ the
"killall weston" invocation to in stop_weston() was incorrectly
moved before the command invocation. In this state, the test can
succeed on fast host computer running the test. But it will most
likely fail on an average computer.

This commit fixes this issue by moving the sleep time after
the command invocation.

[1] https://gitlab.com/buildroot.org/buildroot/-/commit/6561a5d773d8e159556e2b911b315e3b5a0b89b1

Signed-off-by: Julien Olivain <ju.o@free.fr>
---
 support/testing/tests/package/test_weston.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/testing/tests/package/test_weston.py b/support/testing/tests/package/test_weston.py
index 2ed59a7f15..43b5240b2d 100644
--- a/support/testing/tests/package/test_weston.py
+++ b/support/testing/tests/package/test_weston.py
@@ -58,8 +58,8 @@ class TestWeston(infra.basetest.BRTest, GraphicsBase):
 
     def stop_weston(self):
         cmd = "killall weston"
-        time.sleep(3)
         self.assertRunOk(cmd)
+        time.sleep(3)
 
     def test_run(self):
         img = os.path.join(self.builddir, "images", "rootfs.cpio.gz")
-- 
2.49.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] support/testing: weston: fix the weston shutdown test

[Thomas Petazzoni via buildroot]

On Mon, 31 Mar 2025 22:03:02 +0200
Julien Olivain <ju.o@free.fr> wrote:

> Commit [1] "support/testing: improve weston test reliability" moved
> out the wait time from the emulator (to run on the test controller).
> 
> While doing so, the sleep time which was initially _after_ the
> "killall weston" invocation to in stop_weston() was incorrectly
> moved before the command invocation. In this state, the test can
> succeed on fast host computer running the test. But it will most
> likely fail on an average computer.
> 
> This commit fixes this issue by moving the sleep time after
> the command invocation.
> 
> [1] https://gitlab.com/buildroot.org/buildroot/-/commit/6561a5d773d8e159556e2b911b315e3b5a0b89b1
> 
> Signed-off-by: Julien Olivain <ju.o@free.fr>
> ---
>  support/testing/tests/package/test_weston.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] support/testing: weston: fix the weston shutdown test

[Arnout Vandecappelle via buildroot]

On 31/03/2025 22:03, Julien Olivain wrote:
> Commit [1] "support/testing: improve weston test reliability" moved
> out the wait time from the emulator (to run on the test controller).
> 
> While doing so, the sleep time which was initially _after_ the
> "killall weston" invocation to in stop_weston() was incorrectly
> moved before the command invocation. In this state, the test can
> succeed on fast host computer running the test. But it will most
> likely fail on an average computer.
> 
> This commit fixes this issue by moving the sleep time after
> the command invocation.
> 
> [1] https://gitlab.com/buildroot.org/buildroot/-/commit/6561a5d773d8e159556e2b911b315e3b5a0b89b1
> 
> Signed-off-by: Julien Olivain <ju.o@free.fr>

  Applied to 2025.02.x, thanks.

  Regards,
  Arnout

> ---
>   support/testing/tests/package/test_weston.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/testing/tests/package/test_weston.py b/support/testing/tests/package/test_weston.py
> index 2ed59a7f15..43b5240b2d 100644
> --- a/support/testing/tests/package/test_weston.py
> +++ b/support/testing/tests/package/test_weston.py
> @@ -58,8 +58,8 @@ class TestWeston(infra.basetest.BRTest, GraphicsBase):
>   
>       def stop_weston(self):
>           cmd = "killall weston"
> -        time.sleep(3)
>           self.assertRunOk(cmd)
> +        time.sleep(3)
>   
>       def test_run(self):
>           img = os.path.join(self.builddir, "images", "rootfs.cpio.gz")

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot