[PATCH BlueZ 0/1] bap: Fix endpoint unregister for BAP broadcast source

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH BlueZ 0/1] bap: Fix endpoint unregister for BAP broadcast source
@ 2024-04-02 15:49 Silviu Florian Barbulescu
  2024-04-02 15:49 ` [PATCH BlueZ 1/1] " Silviu Florian Barbulescu
  2024-04-02 20:40 ` [PATCH BlueZ 0/1] " patchwork-bot+bluetooth
  0 siblings, 2 replies; 4+ messages in thread
From: Silviu Florian Barbulescu @ 2024-04-02 15:49 UTC (permalink / raw)
  To: linux-bluetooth
  Cc: mihai-octavian.urzica, silviu.barbulescu, vlad.pruteanu,
	andrei.istodorescu, luiz.dentz, iulia.tanasescu

Fix endpoint unregister command for BAP broadcast source
before fix endpoint is not deleted:
endpoint.register 00001852-0000-1000-8000-00805f9b34fb 0x065f9b34fb 0x06
[/local/endpoint/ep0] Auto Accept (yes/no): y
[/local/endpoint/ep0] Max Transports (auto/value): a
[/local/endpoint/ep0] Locations: 3
[/local/endpoint/ep0] Supported Context (value): 0
Capabilities:
03 01 ff 00 02 02 03 02 03 03 05 04 1a 00 f0 00 ................
Metadata:
[bluetooth]# [NEW] Endpoint /org/bluez/hci0/pac_bcast0
[bluetooth]# Endpoint /local/endpoint/ep0 registered
[bluetooth]# endpoint.config /org/bluez/hci0/pac_bcast0
/local/endpoint/ep0 48_4endpoint.config /org/bluez/hci0/pac_bcast0
/local/endpoint/ep0 48_4_1
[/local/endpoint/ep0] BIG (auto/value): 0
[/local/endpoint/ep0] Enter channel location (value/no): 1
[/local/endpoint/ep0] Enter Metadata (value/no): n
.................
[bluetooth]# [NEW] Transport /org/bluez/hci0/pac_bcast0/fd0
[bluetooth]# Endpoint: SetConfiguration
[bluetooth]# Transport /org/bluez/hci0/pac_bcast0/fd0
[bluetooth]# Properties.Device: /org/bluez/hci0
[bluetooth]# Auto Accepting...
[bluetooth]# Endpoint /local/endpoint/ep0 configured
endpoint.unregister 00001852-0000-1000-8000-00805f9b34fb-00805f9b34fb
[bluetooth]# [DEL] Transport /org/bluez/hci0/pac_bcast0/fd0
[bluetooth]# Endpoint /local/endpoint/ep0 unregistered

after fix endpoint is deleted:
[bluetooth]# [CHG] Controller 00:AA:01:00:00:00 Pairable: yes
[bluetooth]# AdvertisementMonitor path registered
endpoint.register 00001852-0000-1000-8000-00805f9b34fb 0x065f9b34fb 0x06
[/local/endpoint/ep0] Auto Accept (yes/no): y
[/local/endpoint/ep0] Max Transports (auto/value): a
[/local/endpoint/ep0] Locations: 3
[/local/endpoint/ep0] Supported Context (value): 0
Capabilities:
03 01 ff 00 02 02 03 02 03 03 05 04 1a 00 f0 00 ................
Metadata:
[bluetooth]# [NEW] Endpoint /org/bluez/hci0/pac_bcast0
[bluetooth]# Endpoint /local/endpoint/ep0 registered
[bluetooth]# endpoint.config /org/bluez/hci0/pac_bcast0
/local/endpoint/ep0 48_4endpoint.config /org/bluez/hci0/pac_bcast0
/local/endpoint/ep0 48_4_1
[/local/endpoint/ep0] BIG (auto/value): 0
[/local/endpoint/ep0] Enter channel location (value/no): 1
[/local/endpoint/ep0] Enter Metadata (value/no): n
............
[bluetooth]# [NEW] Transport /org/bluez/hci0/pac_bcast0/fd0
[bluetooth]# Endpoint: SetConfiguration
[bluetooth]# Transport /org/bluez/hci0/pac_bcast0/fd0
[bluetooth]# Properties.Device: /org/bluez/hci0
[bluetooth]# Auto Accepting...
[bluetooth]# Endpoint /local/endpoint/ep0 configured
endpoint.unregister 00001852-0000-1000-8000-00805f9b34fb-00805f9b34fb
[bluetooth]# [DEL] Transport /org/bluez/hci0/pac_bcast0/fd0
[bluetooth]# [DEL] Endpoint /org/bluez/hci0/pac_bcast0
[bluetooth]# Endpoint /local/endpoint/ep0 unregistered

Silviu Florian Barbulescu (1):
  bap: Fix endpoint unregister for BAP broadcast source

 profiles/audio/bap.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

base-commit: 3403f65e266a0c40ace9cecc868fa96ad3335920
-- 
2.40.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH BlueZ 1/1] bap: Fix endpoint unregister for BAP broadcast source
  2024-04-02 15:49 [PATCH BlueZ 0/1] bap: Fix endpoint unregister for BAP broadcast source Silviu Florian Barbulescu
@ 2024-04-02 15:49 ` Silviu Florian Barbulescu
  2024-04-02 17:42   ` bluez.test.bot
  2024-04-02 20:40 ` [PATCH BlueZ 0/1] " patchwork-bot+bluetooth
  1 sibling, 1 reply; 4+ messages in thread
From: Silviu Florian Barbulescu @ 2024-04-02 15:49 UTC (permalink / raw)
  To: linux-bluetooth
  Cc: mihai-octavian.urzica, silviu.barbulescu, vlad.pruteanu,
	andrei.istodorescu, luiz.dentz, iulia.tanasescu

Fix endpoint not being removed when endpoint unregister
 is called for BAP broadcast source

---
 profiles/audio/bap.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c
index 52a9f5e00..db0af7e7c 100644
--- a/profiles/audio/bap.c
+++ b/profiles/audio/bap.c
@@ -2490,15 +2490,12 @@ static void pac_removed(struct bt_bap_pac *pac, void *user_data)
 
 static void pac_removed_broadcast(struct bt_bap_pac *pac, void *user_data)
 {
-	struct btd_service *service = user_data;
-	struct bap_data *data;
+	struct bap_data *data = user_data;
 	struct queue *queue;
 	struct bap_ep *ep;
 
 	DBG("pac %p", pac);
 
-	data = btd_service_get_user_data(service);
-
 	switch (bt_bap_pac_get_type(pac)) {
 	case BT_BAP_SINK:
 		queue = data->srcs;
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: bap: Fix endpoint unregister for BAP broadcast source
  2024-04-02 15:49 ` [PATCH BlueZ 1/1] " Silviu Florian Barbulescu
@ 2024-04-02 17:42   ` bluez.test.bot
  0 siblings, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2024-04-02 17:42 UTC (permalink / raw)
  To: linux-bluetooth, silviu.barbulescu

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=840702

---Test result---

Test Summary:
CheckPatch                    PASS      0.45 seconds
GitLint                       PASS      0.33 seconds
BuildEll                      PASS      24.59 seconds
BluezMake                     PASS      1700.75 seconds
MakeCheck                     PASS      13.79 seconds
MakeDistcheck                 PASS      178.97 seconds
CheckValgrind                 PASS      248.63 seconds
CheckSmatch                   PASS      353.52 seconds
bluezmakeextell               PASS      120.47 seconds
IncrementalBuild              PASS      1456.28 seconds
ScanBuild                     PASS      1001.85 seconds



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH BlueZ 0/1] bap: Fix endpoint unregister for BAP broadcast source
  2024-04-02 15:49 [PATCH BlueZ 0/1] bap: Fix endpoint unregister for BAP broadcast source Silviu Florian Barbulescu
  2024-04-02 15:49 ` [PATCH BlueZ 1/1] " Silviu Florian Barbulescu
@ 2024-04-02 20:40 ` patchwork-bot+bluetooth
  1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+bluetooth @ 2024-04-02 20:40 UTC (permalink / raw)
  To: Silviu Florian Barbulescu
  Cc: linux-bluetooth, mihai-octavian.urzica, vlad.pruteanu,
	andrei.istodorescu, luiz.dentz, iulia.tanasescu

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue,  2 Apr 2024 18:49:54 +0300 you wrote:
> Fix endpoint unregister command for BAP broadcast source
> before fix endpoint is not deleted:
> endpoint.register 00001852-0000-1000-8000-00805f9b34fb 0x065f9b34fb 0x06
> [/local/endpoint/ep0] Auto Accept (yes/no): y
> [/local/endpoint/ep0] Max Transports (auto/value): a
> [/local/endpoint/ep0] Locations: 3
> [/local/endpoint/ep0] Supported Context (value): 0
> Capabilities:
> 03 01 ff 00 02 02 03 02 03 03 05 04 1a 00 f0 00 ................
> Metadata:
> [bluetooth]# [NEW] Endpoint /org/bluez/hci0/pac_bcast0
> [bluetooth]# Endpoint /local/endpoint/ep0 registered
> [bluetooth]# endpoint.config /org/bluez/hci0/pac_bcast0
> /local/endpoint/ep0 48_4endpoint.config /org/bluez/hci0/pac_bcast0
> /local/endpoint/ep0 48_4_1
> [/local/endpoint/ep0] BIG (auto/value): 0
> [/local/endpoint/ep0] Enter channel location (value/no): 1
> [/local/endpoint/ep0] Enter Metadata (value/no): n
> .................
> [bluetooth]# [NEW] Transport /org/bluez/hci0/pac_bcast0/fd0
> [bluetooth]# Endpoint: SetConfiguration
> [bluetooth]# Transport /org/bluez/hci0/pac_bcast0/fd0
> [bluetooth]# Properties.Device: /org/bluez/hci0
> [bluetooth]# Auto Accepting...
> [bluetooth]# Endpoint /local/endpoint/ep0 configured
> endpoint.unregister 00001852-0000-1000-8000-00805f9b34fb-00805f9b34fb
> [bluetooth]# [DEL] Transport /org/bluez/hci0/pac_bcast0/fd0
> [bluetooth]# Endpoint /local/endpoint/ep0 unregistered
> 
> [...]

Here is the summary with links:
  - [BlueZ,1/1] bap: Fix endpoint unregister for BAP broadcast source
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0d38224bf566

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-04-02 20:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-02 15:49 [PATCH BlueZ 0/1] bap: Fix endpoint unregister for BAP broadcast source Silviu Florian Barbulescu
2024-04-02 15:49 ` [PATCH BlueZ 1/1] " Silviu Florian Barbulescu
2024-04-02 17:42   ` bluez.test.bot
2024-04-02 20:40 ` [PATCH BlueZ 0/1] " patchwork-bot+bluetooth

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.