From: Heiko Stuebner <heiko@sntech.de>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: David Airlie <airlied@linux.ie>,
kernel@collabora.com, linux-kernel@vger.kernel.org,
Sandy Huang <hjc@rock-chips.com>,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/rockchip: psr: do not dereference encoder before it is null checked.
Date: Tue, 16 Oct 2018 15:00:20 +0200 [thread overview]
Message-ID: <6610441.t0YFBFda2e@phil> (raw)
In-Reply-To: <20181013105654.11827-1-enric.balletbo@collabora.com>
Am Samstag, 13. Oktober 2018, 12:56:54 CEST schrieb Enric Balletbo i Serra:
> 'encoder' is deferenced before it is null sanity checked, hence we
> potentially have a null pointer dereference bug. Instead, initialise
> drm_drv from encoder->dev->dev_private after we are sure 'encoder' is
> not null.
>
> Fixes: 5182c1a556d7f ("drm/rockchip: add an common abstracted PSR driver")
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
added a stable-tag and applied to drm-misc-next
Thanks
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/rockchip: psr: do not dereference encoder before it is null checked.
Date: Tue, 16 Oct 2018 15:00:20 +0200 [thread overview]
Message-ID: <6610441.t0YFBFda2e@phil> (raw)
In-Reply-To: <20181013105654.11827-1-enric.balletbo@collabora.com>
Am Samstag, 13. Oktober 2018, 12:56:54 CEST schrieb Enric Balletbo i Serra:
> 'encoder' is deferenced before it is null sanity checked, hence we
> potentially have a null pointer dereference bug. Instead, initialise
> drm_drv from encoder->dev->dev_private after we are sure 'encoder' is
> not null.
>
> Fixes: 5182c1a556d7f ("drm/rockchip: add an common abstracted PSR driver")
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
added a stable-tag and applied to drm-misc-next
Thanks
Heiko
next prev parent reply other threads:[~2018-10-16 13:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 10:56 [PATCH] drm/rockchip: psr: do not dereference encoder before it is null checked Enric Balletbo i Serra
2018-10-13 10:56 ` Enric Balletbo i Serra
2018-10-13 10:56 ` Enric Balletbo i Serra
2018-10-16 13:00 ` Heiko Stuebner [this message]
2018-10-16 13:00 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6610441.t0YFBFda2e@phil \
--to=heiko@sntech.de \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=hjc@rock-chips.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.