[PATCH BlueZ v2] client/player: add error code handling to transport_recv()

[PATCH BlueZ v2] client/player: add error code handling to transport_recv()

[Roman Smirnov]

It is necessary to add return value check as in sock_send().

Found with the SVACE static analysis tool.
---
 V1 -> V2: the name of the patch has been shortened 
 client/player.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/client/player.c b/client/player.c
index 0d031e4b0..1340a7584 100644
--- a/client/player.c
+++ b/client/player.c
@@ -4514,7 +4514,13 @@ static bool transport_recv(struct io *io, void *user_data)
 	uint8_t buf[1024];
 	int ret, len;
 
-	ret = read(io_get_fd(io), buf, sizeof(buf));
+	ret = io_get_fd(io);
+	if (ret < 0) {
+		bt_shell_printf("io_get_fd() returned %d\n", ret);
+		return true;
+	}
+
+	ret = read(ret, buf, sizeof(buf));
 	if (ret < 0) {
 		bt_shell_printf("Failed to read: %s (%d)\n", strerror(errno),
 								-errno);
-- 
2.43.0

RE: [BlueZ,v2] client/player: add error code handling to transport_recv()

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1557 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=868334

---Test result---

Test Summary:
CheckPatch                    PASS      0.45 seconds
GitLint                       FAIL      0.49 seconds
BuildEll                      PASS      25.33 seconds
BluezMake                     PASS      1897.59 seconds
MakeCheck                     PASS      13.34 seconds
MakeDistcheck                 PASS      180.67 seconds
CheckValgrind                 PASS      253.61 seconds
CheckSmatch                   PASS      359.52 seconds
bluezmakeextell               PASS      127.39 seconds
IncrementalBuild              PASS      1666.22 seconds
ScanBuild                     PASS      1035.74 seconds

Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,v2] client/player: add error code handling to transport_recv()

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
7: B2 Line has trailing whitespace: " V1 -> V2: the name of the patch has been shortened "


---
Regards,
Linux Bluetooth

[PATCH BlueZ v2] client/player: add error code handling to transport_recv()

[Roman Smirnov]

It is necessary to add return value check as in sock_send().

Found with the SVACE static analysis tool.
---
 V1 -> V2: the name of the patch has been shortened
 client/player.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/client/player.c b/client/player.c
index 0d031e4b0..1340a7584 100644
--- a/client/player.c
+++ b/client/player.c
@@ -4514,7 +4514,13 @@ static bool transport_recv(struct io *io, void *user_data)
 	uint8_t buf[1024];
 	int ret, len;
 
-	ret = read(io_get_fd(io), buf, sizeof(buf));
+	ret = io_get_fd(io);
+	if (ret < 0) {
+		bt_shell_printf("io_get_fd() returned %d\n", ret);
+		return true;
+	}
+
+	ret = read(ret, buf, sizeof(buf));
 	if (ret < 0) {
 		bt_shell_printf("Failed to read: %s (%d)\n", strerror(errno),
 								-errno);
-- 
2.43.0

RE: [BlueZ,v2] client/player: add error code handling to transport_recv()

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=868404

---Test result---

Test Summary:
CheckPatch                    PASS      0.26 seconds
GitLint                       PASS      0.19 seconds
BuildEll                      PASS      24.36 seconds
BluezMake                     PASS      1651.77 seconds
MakeCheck                     PASS      12.94 seconds
MakeDistcheck                 PASS      180.39 seconds
CheckValgrind                 PASS      255.77 seconds
CheckSmatch                   PASS      360.05 seconds
bluezmakeextell               PASS      120.85 seconds
IncrementalBuild              PASS      1441.50 seconds
ScanBuild                     PASS      1030.93 seconds



---
Regards,
Linux Bluetooth