* [lee-leds:for-leds-next 65/65] drivers/leds/leds-lp5569.c:204:52: error: passing argument 3 of 'lp55xx_read' from incompatible pointer type
@ 2024-07-11 23:35 kernel test robot
2024-07-12 0:48 ` Christian Marangi
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2024-07-11 23:35 UTC (permalink / raw)
To: Christian Marangi; +Cc: oe-kbuild-all, linux-leds, Lee Jones
tree: https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next
head: d9cc80b1c9b40a33c022e125b7f9555813c7f385
commit: d9cc80b1c9b40a33c022e125b7f9555813c7f385 [65/65] leds: leds-lp5569: Enable chip after chip configuration
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20240712/202407120702.K20luS0E-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240712/202407120702.K20luS0E-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407120702.K20luS0E-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/leds/leds-lp5569.c:11:
drivers/leds/leds-lp5569.c: In function 'lp5569_post_init_device':
>> drivers/leds/leds-lp5569.c:204:52: error: passing argument 3 of 'lp55xx_read' from incompatible pointer type [-Wincompatible-pointer-types]
204 | chip, LP5569_REG_STATUS, &val);
| ^~~~
| |
| int *
include/linux/iopoll.h:46:28: note: in definition of macro 'read_poll_timeout'
46 | (val) = op(args); \
| ^~~~
In file included from drivers/leds/leds-lp5569.c:20:
drivers/leds/leds-lp55xx-common.h:229:62: note: expected 'u8 *' {aka 'unsigned char *'} but argument is of type 'int *'
229 | extern int lp55xx_read(struct lp55xx_chip *chip, u8 reg, u8 *val);
| ~~~~^~~
>> drivers/leds/leds-lp5569.c:204:52: error: passing argument 3 of 'lp55xx_read' from incompatible pointer type [-Wincompatible-pointer-types]
204 | chip, LP5569_REG_STATUS, &val);
| ^~~~
| |
| int *
include/linux/iopoll.h:51:36: note: in definition of macro 'read_poll_timeout'
51 | (val) = op(args); \
| ^~~~
drivers/leds/leds-lp55xx-common.h:229:62: note: expected 'u8 *' {aka 'unsigned char *'} but argument is of type 'int *'
229 | extern int lp55xx_read(struct lp55xx_chip *chip, u8 reg, u8 *val);
| ~~~~^~~
vim +/lp55xx_read +204 drivers/leds/leds-lp5569.c
171
172 static int lp5569_post_init_device(struct lp55xx_chip *chip)
173 {
174 int ret;
175 int val;
176
177 val = LP5569_DEFAULT_CONFIG;
178 val |= FIELD_PREP(LP5569_CP_MODE_MASK, chip->pdata->charge_pump_mode);
179 ret = lp55xx_write(chip, LP5569_REG_MISC, val);
180 if (ret)
181 return ret;
182
183 if (chip->pdata->clock_mode == LP55XX_CLOCK_INT) {
184 /* Internal clock MUST be configured before CLK output */
185 ret = lp55xx_update_bits(chip, LP5569_REG_MISC,
186 LP5569_INTERNAL_CLK,
187 LP5569_INTERNAL_CLK);
188 if (ret)
189 return ret;
190
191 ret = lp55xx_update_bits(chip, LP5569_REG_IO_CONTROL,
192 LP5569_CLK_OUTPUT,
193 LP5569_CLK_OUTPUT);
194 if (ret)
195 return ret;
196 }
197
198 ret = lp55xx_write(chip, LP5569_REG_ENABLE, LP5569_ENABLE);
199 if (ret)
200 return ret;
201
202 read_poll_timeout(lp55xx_read, ret, !(val & LP5569_STARTUP_BUSY),
203 LP5569_STARTUP_SLEEP, LP5569_STARTUP_SLEEP * 10, false,
> 204 chip, LP5569_REG_STATUS, &val);
205
206 return lp5569_init_program_engine(chip);
207 }
208
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [lee-leds:for-leds-next 65/65] drivers/leds/leds-lp5569.c:204:52: error: passing argument 3 of 'lp55xx_read' from incompatible pointer type
2024-07-11 23:35 [lee-leds:for-leds-next 65/65] drivers/leds/leds-lp5569.c:204:52: error: passing argument 3 of 'lp55xx_read' from incompatible pointer type kernel test robot
@ 2024-07-12 0:48 ` Christian Marangi
0 siblings, 0 replies; 2+ messages in thread
From: Christian Marangi @ 2024-07-12 0:48 UTC (permalink / raw)
To: kernel test robot; +Cc: oe-kbuild-all, linux-leds, Lee Jones
On Fri, Jul 12, 2024 at 07:35:42AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next
> head: d9cc80b1c9b40a33c022e125b7f9555813c7f385
> commit: d9cc80b1c9b40a33c022e125b7f9555813c7f385 [65/65] leds: leds-lp5569: Enable chip after chip configuration
> config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20240712/202407120702.K20luS0E-lkp@intel.com/config)
> compiler: sh4-linux-gcc (GCC) 14.1.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240712/202407120702.K20luS0E-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202407120702.K20luS0E-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> In file included from drivers/leds/leds-lp5569.c:11:
> drivers/leds/leds-lp5569.c: In function 'lp5569_post_init_device':
> >> drivers/leds/leds-lp5569.c:204:52: error: passing argument 3 of 'lp55xx_read' from incompatible pointer type [-Wincompatible-pointer-types]
> 204 | chip, LP5569_REG_STATUS, &val);
> | ^~~~
> | |
> | int *
> include/linux/iopoll.h:46:28: note: in definition of macro 'read_poll_timeout'
> 46 | (val) = op(args); \
> | ^~~~
> In file included from drivers/leds/leds-lp5569.c:20:
> drivers/leds/leds-lp55xx-common.h:229:62: note: expected 'u8 *' {aka 'unsigned char *'} but argument is of type 'int *'
> 229 | extern int lp55xx_read(struct lp55xx_chip *chip, u8 reg, u8 *val);
> | ~~~~^~~
> >> drivers/leds/leds-lp5569.c:204:52: error: passing argument 3 of 'lp55xx_read' from incompatible pointer type [-Wincompatible-pointer-types]
> 204 | chip, LP5569_REG_STATUS, &val);
> | ^~~~
> | |
> | int *
> include/linux/iopoll.h:51:36: note: in definition of macro 'read_poll_timeout'
> 51 | (val) = op(args); \
> | ^~~~
> drivers/leds/leds-lp55xx-common.h:229:62: note: expected 'u8 *' {aka 'unsigned char *'} but argument is of type 'int *'
> 229 | extern int lp55xx_read(struct lp55xx_chip *chip, u8 reg, u8 *val);
> | ~~~~^~~
>
>
> vim +/lp55xx_read +204 drivers/leds/leds-lp5569.c
Hi Lee,
I just sent v2 of the series that fix this warning. Hope it can be
reverted and v2 applied instead!
>
> 171
> 172 static int lp5569_post_init_device(struct lp55xx_chip *chip)
> 173 {
> 174 int ret;
> 175 int val;
> 176
> 177 val = LP5569_DEFAULT_CONFIG;
> 178 val |= FIELD_PREP(LP5569_CP_MODE_MASK, chip->pdata->charge_pump_mode);
> 179 ret = lp55xx_write(chip, LP5569_REG_MISC, val);
> 180 if (ret)
> 181 return ret;
> 182
> 183 if (chip->pdata->clock_mode == LP55XX_CLOCK_INT) {
> 184 /* Internal clock MUST be configured before CLK output */
> 185 ret = lp55xx_update_bits(chip, LP5569_REG_MISC,
> 186 LP5569_INTERNAL_CLK,
> 187 LP5569_INTERNAL_CLK);
> 188 if (ret)
> 189 return ret;
> 190
> 191 ret = lp55xx_update_bits(chip, LP5569_REG_IO_CONTROL,
> 192 LP5569_CLK_OUTPUT,
> 193 LP5569_CLK_OUTPUT);
> 194 if (ret)
> 195 return ret;
> 196 }
> 197
> 198 ret = lp55xx_write(chip, LP5569_REG_ENABLE, LP5569_ENABLE);
> 199 if (ret)
> 200 return ret;
> 201
> 202 read_poll_timeout(lp55xx_read, ret, !(val & LP5569_STARTUP_BUSY),
> 203 LP5569_STARTUP_SLEEP, LP5569_STARTUP_SLEEP * 10, false,
> > 204 chip, LP5569_REG_STATUS, &val);
> 205
> 206 return lp5569_init_program_engine(chip);
> 207 }
> 208
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
--
Ansuel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-12 0:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-11 23:35 [lee-leds:for-leds-next 65/65] drivers/leds/leds-lp5569.c:204:52: error: passing argument 3 of 'lp55xx_read' from incompatible pointer type kernel test robot
2024-07-12 0:48 ` Christian Marangi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.