From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
daniel@ffwll.ch, deller@gmx.de, geert@linux-m68k.org,
sam@ravnborg.org, kraxel@redhat.com, ppaalanen@gmail.com
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()
Date: Thu, 24 Feb 2022 09:31:14 +0100 [thread overview]
Message-ID: <6692a3cd-21c8-3f09-cf55-ea2b8af34d30@redhat.com> (raw)
In-Reply-To: <20220223193804.18636-5-tzimmermann@suse.de>
On 2/23/22 20:38, Thomas Zimmermann wrote:
> Improve the performance of cfb_imageblit() by manually unrolling
> the inner blitting loop and moving some invariants out. The compiler
> failed to do this automatically. This change keeps cfb_imageblit()
> in sync with sys_imagebit().
>
> A microbenchmark measures the average number of CPU cycles
> for cfb_imageblit() after a stabilizing period of a few minutes
> (i7-4790, FullHD, simpledrm, kernel with debugging).
>
> cfb_imageblit(), new: 15724 cycles
> cfb_imageblit(): old: 30566 cycles
>
> In the optimized case, cfb_imageblit() is now ~2x faster than before.
>
> v3:
> * fix commit description (Pekka)
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
Makes sense, improves perf and makes the two more consistent as you mention.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
daniel@ffwll.ch, deller@gmx.de, geert@linux-m68k.org,
sam@ravnborg.org, kraxel@redhat.com, ppaalanen@gmail.com
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()
Date: Thu, 24 Feb 2022 09:31:14 +0100 [thread overview]
Message-ID: <6692a3cd-21c8-3f09-cf55-ea2b8af34d30@redhat.com> (raw)
In-Reply-To: <20220223193804.18636-5-tzimmermann@suse.de>
On 2/23/22 20:38, Thomas Zimmermann wrote:
> Improve the performance of cfb_imageblit() by manually unrolling
> the inner blitting loop and moving some invariants out. The compiler
> failed to do this automatically. This change keeps cfb_imageblit()
> in sync with sys_imagebit().
>
> A microbenchmark measures the average number of CPU cycles
> for cfb_imageblit() after a stabilizing period of a few minutes
> (i7-4790, FullHD, simpledrm, kernel with debugging).
>
> cfb_imageblit(), new: 15724 cycles
> cfb_imageblit(): old: 30566 cycles
>
> In the optimized case, cfb_imageblit() is now ~2x faster than before.
>
> v3:
> * fix commit description (Pekka)
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
Makes sense, improves perf and makes the two more consistent as you mention.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-02-24 8:31 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 19:37 [PATCH v3 0/5] fbdev: Improve performance of fbdev console Thomas Zimmermann
2022-02-23 19:37 ` Thomas Zimmermann
2022-02-23 19:38 ` [PATCH v3 1/5] fbdev: Improve performance of sys_fillrect() Thomas Zimmermann
2022-02-23 19:38 ` Thomas Zimmermann
2022-02-23 19:38 ` [PATCH v3 2/5] fbdev: Improve performance of sys_imageblit() Thomas Zimmermann
2022-02-23 19:38 ` Thomas Zimmermann
2022-02-23 19:38 ` [PATCH v3 3/5] fbdev: Remove trailing whitespaces from cfbimgblt.c Thomas Zimmermann
2022-02-23 19:38 ` Thomas Zimmermann
2022-02-23 20:23 ` Sam Ravnborg
2022-02-23 20:23 ` Sam Ravnborg
2022-02-24 8:22 ` Javier Martinez Canillas
2022-02-24 8:22 ` Javier Martinez Canillas
2022-02-23 19:38 ` [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit() Thomas Zimmermann
2022-02-23 19:38 ` Thomas Zimmermann
2022-02-23 20:25 ` Sam Ravnborg
2022-02-23 20:25 ` Sam Ravnborg
2022-02-24 9:02 ` Javier Martinez Canillas
2022-02-24 9:02 ` Javier Martinez Canillas
2022-02-24 10:29 ` Sam Ravnborg
2022-02-24 10:29 ` Sam Ravnborg
2022-02-24 10:31 ` Geert Uytterhoeven
2022-02-24 10:31 ` Geert Uytterhoeven
2022-02-24 8:31 ` Javier Martinez Canillas [this message]
2022-02-24 8:31 ` Javier Martinez Canillas
2022-03-08 22:52 ` [v3,4/5] " Marek Szyprowski
2022-03-09 8:22 ` Thomas Zimmermann
2022-03-09 9:22 ` Marek Szyprowski
2022-03-09 10:39 ` Geert Uytterhoeven
2022-03-09 10:39 ` Geert Uytterhoeven
2022-03-10 19:21 ` Thomas Zimmermann
2022-03-10 19:21 ` Thomas Zimmermann
2022-03-10 19:23 ` Geert Uytterhoeven
2022-03-10 19:23 ` Geert Uytterhoeven
2022-03-13 19:23 ` Thomas Zimmermann
2022-03-13 19:23 ` Thomas Zimmermann
2022-03-24 19:11 ` [PATCH v3 4/5] " Guenter Roeck
2022-03-24 19:11 ` Guenter Roeck
2022-03-24 19:18 ` Thomas Zimmermann
2022-03-24 19:18 ` Thomas Zimmermann
2022-03-24 21:18 ` Guenter Roeck
2022-03-24 21:18 ` Guenter Roeck
2022-02-23 19:38 ` [PATCH v3 5/5] drm: Add TODO item for optimizing format helpers Thomas Zimmermann
2022-02-23 19:38 ` Thomas Zimmermann
2022-02-23 20:34 ` Sam Ravnborg
2022-02-23 20:34 ` Sam Ravnborg
2022-02-24 8:39 ` Javier Martinez Canillas
2022-02-24 8:39 ` Javier Martinez Canillas
2022-03-02 19:30 ` [PATCH v3 0/5] fbdev: Improve performance of fbdev console Thomas Zimmermann
2022-03-02 19:30 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6692a3cd-21c8-3f09-cf55-ea2b8af34d30@redhat.com \
--to=javierm@redhat.com \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=kraxel@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=ppaalanen@gmail.com \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.