All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: Lukasz Majczak <lma@semihalf.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Mateusz Gorski <mateusz.gorski@linux.intel.com>
Cc: alsa-devel@alsa-project.org, Guenter Roeck <groeck@google.com>,
	Radoslaw Biernacki <rad@semihalf.com>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Marcin Wojtas <mw@semihalf.com>, Alex Levin <levinale@google.com>
Subject: Re: [PATCH] ASoC: Intel: Skylake: Check the kcontrol against NULL
Date: Fri, 11 Dec 2020 16:42:04 +0100	[thread overview]
Message-ID: <669da93a-2ef2-fa08-6c7f-be2e6b5ac363@linux.intel.com> (raw)
In-Reply-To: <20201210121438.7718-1-lma@semihalf.com>

On 12/10/2020 1:14 PM, Lukasz Majczak wrote:
> +		kcontrol = dobj->control.kcontrol;
> +		if(!kcontrol)
> +			continue;

Small nitpick, there should be space between if and opening parenthesis 
as recommended by coding style.

Thanks,
Amadeusz

  parent reply	other threads:[~2020-12-11 15:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10 12:14 [PATCH] ASoC: Intel: Skylake: Check the kcontrol against NULL Lukasz Majczak
2020-12-10 12:14 ` Lukasz Majczak
2020-12-10 15:55 ` Gorski, Mateusz
2020-12-10 15:55   ` Gorski, Mateusz
2020-12-10 16:01   ` Guenter Roeck
2020-12-11 15:42 ` Amadeusz Sławiński [this message]
2020-12-17 13:04 ` [PATCH v2] " Lukasz Majczak
2020-12-17 13:04   ` Lukasz Majczak
2021-01-12 11:34   ` Łukasz Majczak
2021-01-12 11:34     ` Łukasz Majczak
2021-01-20 15:49     ` Łukasz Majczak
2021-01-20 15:49       ` Łukasz Majczak
2021-01-20 16:33       ` Pierre-Louis Bossart
2021-01-20 16:33         ` Pierre-Louis Bossart
2021-01-20 16:41         ` Rojewski, Cezary
2021-01-20 16:41           ` Rojewski, Cezary
2021-01-20 16:45           ` Rojewski, Cezary
2021-01-20 16:45             ` Rojewski, Cezary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=669da93a-2ef2-fa08-6c7f-be2e6b5ac363@linux.intel.com \
    --to=amadeuszx.slawinski@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=groeck@google.com \
    --cc=levinale@google.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lma@semihalf.com \
    --cc=mateusz.gorski@linux.intel.com \
    --cc=mw@semihalf.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=rad@semihalf.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.