[PATCH] dt-bindings: arm: qcom,ids: Add SoC IDs for SM8635 family

[PATCH] dt-bindings: arm: qcom,ids: Add SoC IDs for SM8635 family

[philmb3487]

Author: Philippe Michaud-Boudreault <philmb3487@proton.me>
Date:   Sat Nov 15 19:41:12 2025 -0500

    dt-bindings: arm: qcom,ids: Add SoC IDs for SM8635 family

    Add the SoC ID for the SM8635.

diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
index cb8ce53146f0..b7c4cbb7a2db 100644
--- a/include/dt-bindings/arm/qcom,ids.h
+++ b/include/dt-bindings/arm/qcom,ids.h
@@ -277,6 +277,7 @@
 #define QCOM_ID_IPQ5302                        595
 #define QCOM_ID_QCS8550                        603
 #define QCOM_ID_QCM8550                        604
+#define QCOM_ID_SM8635                 614
 #define QCOM_ID_SM8750                 618
 #define QCOM_ID_IPQ5300                        624
 #define QCOM_ID_SM7635                 636

Re: [PATCH] dt-bindings: arm: qcom,ids: Add SoC IDs for SM8635 family

[Krzysztof Kozlowski]

On 16/11/2025 01:43, philmb3487 wrote:
> Author: Philippe Michaud-Boudreault <philmb3487@proton.me>
> Date:   Sat Nov 15 19:41:12 2025 -0500
> 
>     dt-bindings: arm: qcom,ids: Add SoC IDs for SM8635 family
> 
>     Add the SoC ID for the SM8635.

1. Unfortunately this looks like a messed up patch header. Please use
standard tools for sending patches.

2. Also missing SoB.

3. Also, missing users of this - you have to organize your work in
proper patchsets. See recent guide on Linaro.org blog how to send patches.

... and finally:

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument, so you will
not CC people just because they made one commit years ago). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.


Best regards,
Krzysztof

Re: [PATCH] dt-bindings: arm: qcom,ids: Add SoC IDs for SM8635 family

[philmb3487]

I'm a bit overwhelmed, submitting is quite a complex process.
Do I send an email to everyone mentioned in ./scripts/get_maintainer.pl ? What's the difference with sending an email to linux-msm ?

I've never used tabs before, but now have to. I can't get this error fixed in emacs, does emacs support the linux syntax format ?

WARNING: please, no space before tabs
#28: FILE: include/dt-bindings/arm/qcom,ids.h:286:
+#define QCOM_ID_SM8635P ^I^I642$

total: 0 errors, 1 warnings, 13 lines checked


Also I tried subscribing to the list, but then I got 500 emails in a day. What's the way to manage that, or if not, then I just don't subscribe?

-- Philippe


On Sunday, November 16th, 2025 at 6:04 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:

> 
> 
> On 16/11/2025 01:43, philmb3487 wrote:
> 
> > Author: Philippe Michaud-Boudreault philmb3487@proton.me
> > Date: Sat Nov 15 19:41:12 2025 -0500
> > 
> > dt-bindings: arm: qcom,ids: Add SoC IDs for SM8635 family
> > 
> > Add the SoC ID for the SM8635.
> 
> 
> 1. Unfortunately this looks like a messed up patch header. Please use
> standard tools for sending patches.
> 
> 2. Also missing SoB.
> 
> 3. Also, missing users of this - you have to organize your work in
> proper patchsets. See recent guide on Linaro.org blog how to send patches.
> 
> ... and finally:
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC (and consider --no-git-fallback argument, so you will
> not CC people just because they made one commit years ago). It might
> happen, that command when run on an older kernel, gives you outdated
> entries. Therefore please be sure you base your patches on recent Linux
> kernel.
> 
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
> 
> 
> Best regards,
> Krzysztof

Re: [PATCH] dt-bindings: arm: qcom,ids: Add SoC IDs for SM8635 family

[Krzysztof Kozlowski]

On 16/11/2025 16:13, philmb3487 wrote:
> I'm a bit overwhelmed, submitting is quite a complex process.

Please do not top post.

> Do I send an email to everyone mentioned in ./scripts/get_maintainer.pl ? What's the difference with sending an email to linux-msm ?

Answer to yourself - why would you skip some maintainers? How person can
get it to the mailbox if you do not Cc them?

I have feeling you did not read my message, because I pointed out also
the command you must use, so yes, to everyone pointed out by
--no-git-fallback.

> 
> I've never used tabs before, but now have to. I can't get this error fixed in emacs, does emacs support the linux syntax format ?

I don't use emacs, dunno.

> 
> WARNING: please, no space before tabs
> #28: FILE: include/dt-bindings/arm/qcom,ids.h:286:
> +#define QCOM_ID_SM8635P ^I^I642$
> 
> total: 0 errors, 1 warnings, 13 lines checked
> 
> 
> Also I tried subscribing to the list, but then I got 500 emails in a day. What's the way to manage that, or if not, then I just don't subscribe?

The only subscription needed is for arm kernel list just to post.

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: arm: qcom,ids: Add SoC IDs for SM8635 family

[Dmitry Baryshkov]

On Sun, Nov 16, 2025 at 03:13:58PM +0000, philmb3487 wrote:
> I'm a bit overwhelmed, submitting is quite a complex process.

Please take a look under Documentation/process/submitting-patches.rst.

For example, one of the issues in your email is that you just
inline-posted the full patch. Instead please use git send-email (it
requires a bit of setup, but then it's easy). An alternative option
(which is also easy and skips most of the email setup) is to use the
`b4` tool: https://b4.docs.kernel.org/en/latest/

> Do I send an email to everyone mentioned in ./scripts/get_maintainer.pl ? What's the difference with sending an email to linux-msm ?

Yes. The different is pretty easy: sometimes people don't read the full
mailing list. They go through their inbox only.

> 
> I've never used tabs before, but now have to. I can't get this error fixed in emacs, does emacs support the linux syntax format ?
> 
> WARNING: please, no space before tabs
> #28: FILE: include/dt-bindings/arm/qcom,ids.h:286:
> +#define QCOM_ID_SM8635P ^I^I642$
> 
> total: 0 errors, 1 warnings, 13 lines checked
> 
> 
> Also I tried subscribing to the list, but then I got 500 emails in a day. What's the way to manage that, or if not, then I just don't subscribe?

Delete eveything that you are not interested in. Or don't subscribe,
it's also fine.

> 
> -- Philippe
> 
> 
> On Sunday, November 16th, 2025 at 6:04 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> 
> > 
> > 
> > On 16/11/2025 01:43, philmb3487 wrote:
> > 
> > > Author: Philippe Michaud-Boudreault philmb3487@proton.me
> > > Date: Sat Nov 15 19:41:12 2025 -0500
> > > 
> > > dt-bindings: arm: qcom,ids: Add SoC IDs for SM8635 family
> > > 
> > > Add the SoC ID for the SM8635.
> > 
> > 
> > 1. Unfortunately this looks like a messed up patch header. Please use
> > standard tools for sending patches.
> > 
> > 2. Also missing SoB.
> > 
> > 3. Also, missing users of this - you have to organize your work in
> > proper patchsets. See recent guide on Linaro.org blog how to send patches.
> > 
> > ... and finally:
> > 
> > Please use scripts/get_maintainers.pl to get a list of necessary people
> > and lists to CC (and consider --no-git-fallback argument, so you will
> > not CC people just because they made one commit years ago). It might
> > happen, that command when run on an older kernel, gives you outdated
> > entries. Therefore please be sure you base your patches on recent Linux
> > kernel.
> > 
> > Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> > people, so fix your workflow. Tools might also fail if you work on some
> > ancient tree (don't, instead use mainline) or work on fork of kernel
> > (don't, instead use mainline). Just use b4 and everything should be
> > fine, although remember about `b4 prep --auto-to-cc` if you added new
> > patches to the patchset.
> > 
> > 
> > Best regards,
> > Krzysztof

-- 
With best wishes
Dmitry