All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Michael Walle <michael@walle.cc>
Cc: linux-mtd <linux-mtd@lists.infradead.org>,
	 linux-kernel <linux-kernel@vger.kernel.org>,
	 Miquel Raynal <miquel.raynal@bootlin.com>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] mtd: require write permissions for locking and badblock ioctls
Date: Wed, 3 Mar 2021 17:34:01 +0100 (CET)	[thread overview]
Message-ID: <675291050.42876.1614789241828.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <040cf2058fe4cf5e63dbff534582881a@walle.cc>

----- Ursprüngliche Mail -----
>>> Thanks for auditing the rest of these from my original patch.  If this
>>> is ok with userspace tools, it's fine with me, but I don't even have
>>> this hardware to test with :)
>> 
>> That's my fear. Michael, did you verify?
> 
> I don't know any tools except the mtd-utils. So no.

openwrt folks have their own tooling, Anrdoid too.
 
>> In general you need to be root to open these device files.
>> So, I don't see a security problem here.
> 
> Then this begs the question, why is this check there in
> the first place?

I fear historical reasons.
As soon you can open the device node you can do evil things.

> This come up because I was adding a OTPERASE which
> was suggested that is was a "dangerous" command. So I
> was puzzled why the ones above are considered "safe" ;)

:-)

Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Michael Walle <michael@walle.cc>
Cc: linux-mtd <linux-mtd@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] mtd: require write permissions for locking and badblock ioctls
Date: Wed, 3 Mar 2021 17:34:01 +0100 (CET)	[thread overview]
Message-ID: <675291050.42876.1614789241828.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <040cf2058fe4cf5e63dbff534582881a@walle.cc>

----- Ursprüngliche Mail -----
>>> Thanks for auditing the rest of these from my original patch.  If this
>>> is ok with userspace tools, it's fine with me, but I don't even have
>>> this hardware to test with :)
>> 
>> That's my fear. Michael, did you verify?
> 
> I don't know any tools except the mtd-utils. So no.

openwrt folks have their own tooling, Anrdoid too.
 
>> In general you need to be root to open these device files.
>> So, I don't see a security problem here.
> 
> Then this begs the question, why is this check there in
> the first place?

I fear historical reasons.
As soon you can open the device node you can do evil things.

> This come up because I was adding a OTPERASE which
> was suggested that is was a "dangerous" command. So I
> was puzzled why the ones above are considered "safe" ;)

:-)

Thanks,
//richard

  reply	other threads:[~2021-03-03 23:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03 15:57 [PATCH] mtd: require write permissions for locking and badblock ioctls Michael Walle
2021-03-03 15:57 ` Michael Walle
2021-03-03 16:08 ` Greg Kroah-Hartman
2021-03-03 16:08   ` Greg Kroah-Hartman
2021-03-03 16:17   ` Richard Weinberger
2021-03-03 16:17     ` Richard Weinberger
2021-03-03 16:25     ` Michael Walle
2021-03-03 16:25       ` Michael Walle
2021-03-03 16:34       ` Richard Weinberger [this message]
2021-03-03 16:34         ` Richard Weinberger
2021-03-22 16:39 ` Rafał Miłecki
2021-03-22 16:39   ` Rafał Miłecki
2021-03-22 17:54   ` Richard Weinberger
2021-03-22 17:54     ` Richard Weinberger
2021-03-28 17:28 ` Miquel Raynal
2021-03-28 17:28   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=675291050.42876.1614789241828.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael@walle.cc \
    --cc=miquel.raynal@bootlin.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.