[PATCH v1] BNEP: Fix the BNEP Unknown Control Message in PTS testing:

[PATCH v1] BNEP: Fix the BNEP Unknown Control Message in PTS testing:

[Shuai Zhang]

This change is required for passing below PTS testcase:
1. BNEP/CTRL/BV-01-C

Fix the flag judgment issue, it should check type
instead of ctrl.

Signed-off-by: Shuai Zhang <quic_shuaz@quicinc.com>
---
 profiles/network/server.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/profiles/network/server.c b/profiles/network/server.c
index 36a1136f6..ad2cd55bd 100644
--- a/profiles/network/server.c
+++ b/profiles/network/server.c
@@ -336,7 +336,7 @@ static gboolean bnep_setup(GIOChannel *chan,
 		 * This packet reply to any control message received,
 		 * which contains an unknown BNEP control type value.
 		 */
-		if (req->ctrl == BNEP_CONTROL)
+		if (req->type == BNEP_CONTROL)
 			bnep_send_unkown_rsp(sk, req->ctrl);
 
 		error("To few setup connection request data received");
-- 
2.25.1

RE: [v1] BNEP: Fix the BNEP Unknown Control Message in PTS testing:

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=924035

---Test result---

Test Summary:
CheckPatch                    PENDING   0.28 seconds
GitLint                       PENDING   0.21 seconds
BuildEll                      PASS      20.60 seconds
BluezMake                     PASS      1480.81 seconds
MakeCheck                     PASS      13.08 seconds
MakeDistcheck                 PASS      158.69 seconds
CheckValgrind                 PASS      214.87 seconds
CheckSmatch                   PASS      271.32 seconds
bluezmakeextell               PASS      97.94 seconds
IncrementalBuild              PENDING   0.33 seconds
ScanBuild                     PASS      872.10 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH v1] BNEP: Fix the BNEP Unknown Control Message in PTS testing:

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri, 10 Jan 2025 14:54:44 +0800 you wrote:
> This change is required for passing below PTS testcase:
> 1. BNEP/CTRL/BV-01-C
> 
> Fix the flag judgment issue, it should check type
> instead of ctrl.
> 
> Signed-off-by: Shuai Zhang <quic_shuaz@quicinc.com>
> 
> [...]

Here is the summary with links:
  - [v1] BNEP: Fix the BNEP Unknown Control Message in PTS testing:
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=a30763866b7a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html