* [PATCH v1 2/2] Bluetooth: btnxpuart: Add support for set BD address
2025-01-14 10:40 [PATCH v1 1/2] dt-bindings: net: bluetooth: nxp: Add support to set BD address Neeraj Sanjay Kale
@ 2025-01-14 10:40 ` Neeraj Sanjay Kale
2025-01-14 11:03 ` [PATCH v1 1/2] dt-bindings: net: bluetooth: nxp: Add support to " Krzysztof Kozlowski
2025-01-14 11:28 ` [v1,1/2] " bluez.test.bot
2 siblings, 0 replies; 4+ messages in thread
From: Neeraj Sanjay Kale @ 2025-01-14 10:40 UTC (permalink / raw)
To: marcel, luiz.dentz, robh, krzk+dt, conor+dt
Cc: linux-bluetooth, linux-kernel, devicetree, amitkumar.karwar,
neeraj.sanjaykale, sherry.sun, ziniu.wang_1, johan.korsnes,
kristian.krohn, manjeet.gupta
This adds support for setting BD address during hci registration. NXP
FW does not allow vendor commands unless it receives a reset command
after FW download and initialization done.
As a workaround, the .set_bdaddr callback function will first send the
HCI reset command, followed by the actual vendor command to set BD
address.
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Signed-off-by: Johan Korsnes <johan.korsnes@remarkable.no>
Signed-off-by: Kristian Husevåg Krohn <kristian.krohn@remarkable.no>
Tested-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
---
drivers/bluetooth/btnxpuart.c | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
index 1230045d78a5..deb546a4e664 100644
--- a/drivers/bluetooth/btnxpuart.c
+++ b/drivers/bluetooth/btnxpuart.c
@@ -1197,6 +1197,34 @@ static int nxp_set_ind_reset(struct hci_dev *hdev, void *data)
return hci_recv_frame(hdev, skb);
}
+static int nxp_set_bdaddr(struct hci_dev *hdev, const bdaddr_t *bdaddr)
+{
+ u8 data[8] = { 0xfe, 0x06, 0, 0, 0, 0, 0, 0 };
+ struct sk_buff *skb;
+ int err;
+
+ memcpy(data + 2, bdaddr, 6);
+
+ skb = __hci_cmd_sync(hdev, HCI_OP_RESET, 0, NULL, HCI_INIT_TIMEOUT);
+ if (IS_ERR(skb)) {
+ err = PTR_ERR(skb);
+ bt_dev_err(hdev, "Reset before setting local-bd-addr failed (%ld)",
+ PTR_ERR(skb));
+ return err;
+ }
+ kfree_skb(skb);
+
+ skb = __hci_cmd_sync(hdev, 0xfc22, sizeof(data), data, HCI_CMD_TIMEOUT);
+ if (IS_ERR(skb)) {
+ err = PTR_ERR(skb);
+ bt_dev_err(hdev, "Changing device address failed (%d)", err);
+ return err;
+ }
+ kfree_skb(skb);
+
+ return 0;
+}
+
/* NXP protocol */
static int nxp_setup(struct hci_dev *hdev)
{
@@ -1547,8 +1575,12 @@ static int nxp_serdev_probe(struct serdev_device *serdev)
hdev->send = nxp_enqueue;
hdev->hw_error = nxp_hw_err;
hdev->shutdown = nxp_shutdown;
+ hdev->set_bdaddr = nxp_set_bdaddr;
+
SET_HCIDEV_DEV(hdev, &serdev->dev);
+ set_bit(HCI_QUIRK_USE_BDADDR_PROPERTY, &hdev->quirks);
+
if (hci_register_dev(hdev) < 0) {
dev_err(&serdev->dev, "Can't register HCI device\n");
goto probe_fail;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1 1/2] dt-bindings: net: bluetooth: nxp: Add support to set BD address
2025-01-14 10:40 [PATCH v1 1/2] dt-bindings: net: bluetooth: nxp: Add support to set BD address Neeraj Sanjay Kale
2025-01-14 10:40 ` [PATCH v1 2/2] Bluetooth: btnxpuart: Add support for " Neeraj Sanjay Kale
@ 2025-01-14 11:03 ` Krzysztof Kozlowski
2025-01-14 11:28 ` [v1,1/2] " bluez.test.bot
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-01-14 11:03 UTC (permalink / raw)
To: Neeraj Sanjay Kale, marcel, luiz.dentz, robh, krzk+dt, conor+dt
Cc: linux-bluetooth, linux-kernel, devicetree, amitkumar.karwar,
sherry.sun, ziniu.wang_1, johan.korsnes, kristian.krohn,
manjeet.gupta
On 14/01/2025 11:40, Neeraj Sanjay Kale wrote:
> This adds a new optional device tree property local-bd-address to allow
> user to set custom BD address for NXP chipsets.
>
> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
> ---
> .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> index 0a2d7baf5db3..beae21c3758a 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> @@ -40,6 +40,8 @@ properties:
> Host-To-Chip power save mechanism is driven by this GPIO
> connected to BT_WAKE_IN pin of the NXP chipset.
>
> + local-bd-address: true
You miss bluetooth ref with unevaluatedProperties: false. See mediatek.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [v1,1/2] dt-bindings: net: bluetooth: nxp: Add support to set BD address
2025-01-14 10:40 [PATCH v1 1/2] dt-bindings: net: bluetooth: nxp: Add support to set BD address Neeraj Sanjay Kale
2025-01-14 10:40 ` [PATCH v1 2/2] Bluetooth: btnxpuart: Add support for " Neeraj Sanjay Kale
2025-01-14 11:03 ` [PATCH v1 1/2] dt-bindings: net: bluetooth: nxp: Add support to " Krzysztof Kozlowski
@ 2025-01-14 11:28 ` bluez.test.bot
2 siblings, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2025-01-14 11:28 UTC (permalink / raw)
To: linux-bluetooth, neeraj.sanjaykale
[-- Attachment #1: Type: text/plain, Size: 2521 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=925213
---Test result---
Test Summary:
CheckPatch PENDING 0.41 seconds
GitLint PENDING 0.33 seconds
SubjectPrefix FAIL 0.37 seconds
BuildKernel PASS 24.86 seconds
CheckAllWarning PASS 27.25 seconds
CheckSparse PASS 30.62 seconds
BuildKernel32 PASS 24.29 seconds
TestRunnerSetup PASS 429.66 seconds
TestRunner_l2cap-tester PASS 20.97 seconds
TestRunner_iso-tester PASS 32.71 seconds
TestRunner_bnep-tester PASS 4.86 seconds
TestRunner_mgmt-tester FAIL 124.86 seconds
TestRunner_rfcomm-tester PASS 7.66 seconds
TestRunner_sco-tester PASS 9.61 seconds
TestRunner_ioctl-tester PASS 8.22 seconds
TestRunner_mesh-tester FAIL 6.46 seconds
TestRunner_smp-tester PASS 7.09 seconds
TestRunner_userchan-tester PASS 5.19 seconds
IncrementalBuild PENDING 0.94 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 490, Passed: 485 (99.0%), Failed: 1, Not Run: 4
Failed Test Cases
LL Privacy - Set Flags 2 (Enable RL) Failed 0.148 seconds
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
BUG: KASAN: slab-use-after-free in run_timer_softirq+0x76c/0x7d0
WARNING: CPU: 0 PID: 65 at kernel/workqueue.c:2257 __queue_work+0x687/0xb40
Total: 10, Passed: 9 (90.0%), Failed: 1, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Failed 0.114 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread