From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Wim Van Sebroeck <wim@iguana.be>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412
Date: Tue, 14 Mar 2017 14:03:49 +0100 [thread overview]
Message-ID: <6788694.7QfyuOlrPv@amdc3058> (raw)
In-Reply-To: <20170311172527.16368-4-krzk@kernel.org>
Hi,
On Saturday, March 11, 2017 07:25:22 PM Krzysztof Kozlowski wrote:
> The Exynos4412 has the same watchdog as newer SoCs (e.g. Exynos5250).
> Just like the others, for working it requires additional steps in Power
> Management Unit: unmasking the reset request and enabling the system
> reset. Without these additional steps in PMU, the watchdog will not be
> able to reset the system on expiration event.
>
> Change the compatible of Exynos4412 watchdog device node to
> samsung,exynos5250-wdt which includes the additional PMU steps.
This is going to confuse people. How's about doing it cleanly
(by adding samsung,exynos4412-wdt compatible and convert existing
users to use instead)?
> This will also fix infinite watchdog interrupt in soft mode (lack of
> interrupt clear) because it is also included in samsung,exynos5250-wdt.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412
Date: Tue, 14 Mar 2017 14:03:49 +0100 [thread overview]
Message-ID: <6788694.7QfyuOlrPv@amdc3058> (raw)
In-Reply-To: <20170311172527.16368-4-krzk@kernel.org>
Hi,
On Saturday, March 11, 2017 07:25:22 PM Krzysztof Kozlowski wrote:
> The Exynos4412 has the same watchdog as newer SoCs (e.g. Exynos5250).
> Just like the others, for working it requires additional steps in Power
> Management Unit: unmasking the reset request and enabling the system
> reset. Without these additional steps in PMU, the watchdog will not be
> able to reset the system on expiration event.
>
> Change the compatible of Exynos4412 watchdog device node to
> samsung,exynos5250-wdt which includes the additional PMU steps.
This is going to confuse people. How's about doing it cleanly
(by adding samsung,exynos4412-wdt compatible and convert existing
users to use instead)?
> This will also fix infinite watchdog interrupt in soft mode (lack of
> interrupt clear) because it is also included in samsung,exynos5250-wdt.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2017-03-14 13:03 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-11 17:25 [PATCH v2 0/8] watchdog: s3c2410: Fixes and improvements Krzysztof Kozlowski
2017-03-11 17:25 ` Krzysztof Kozlowski
2017-03-11 17:25 ` Krzysztof Kozlowski
2017-03-11 17:25 ` [PATCH v2 1/8] watchdog: s3c2410: Remove confusing CONFIG prefix from local defines Krzysztof Kozlowski
2017-03-11 17:25 ` Krzysztof Kozlowski
[not found] ` <20170311172527.16368-2-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-03-11 17:28 ` Krzysztof Kozlowski
2017-03-11 17:28 ` Krzysztof Kozlowski
2017-03-11 17:28 ` Krzysztof Kozlowski
2017-03-11 17:25 ` [PATCH v2 2/8] watchdog: s3c2410: Fix infinite interrupt in soft mode Krzysztof Kozlowski
2017-03-11 17:25 ` Krzysztof Kozlowski
2017-03-11 17:29 ` Krzysztof Kozlowski
2017-03-11 17:29 ` Krzysztof Kozlowski
2017-03-11 17:25 ` [PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412 Krzysztof Kozlowski
2017-03-11 17:25 ` Krzysztof Kozlowski
[not found] ` <20170311172527.16368-4-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-03-12 20:48 ` Guenter Roeck
2017-03-12 20:48 ` Guenter Roeck
2017-03-12 20:48 ` Guenter Roeck
2017-03-13 6:41 ` Krzysztof Kozlowski
2017-03-13 6:41 ` Krzysztof Kozlowski
2017-03-14 13:03 ` Bartlomiej Zolnierkiewicz [this message]
2017-03-14 13:03 ` Bartlomiej Zolnierkiewicz
2017-03-14 13:09 ` Krzysztof Kozlowski
2017-03-14 13:09 ` Krzysztof Kozlowski
2017-03-14 13:09 ` Krzysztof Kozlowski
2017-03-14 13:45 ` Bartlomiej Zolnierkiewicz
2017-03-14 13:45 ` Bartlomiej Zolnierkiewicz
2017-03-14 13:45 ` Bartlomiej Zolnierkiewicz
[not found] ` <20170311172527.16368-1-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-03-11 17:25 ` [PATCH v2 4/8] ARM: dts: s3c64xx: Enable watchdog on all S3C64xx boards Krzysztof Kozlowski
2017-03-11 17:25 ` Krzysztof Kozlowski
2017-03-11 17:25 ` Krzysztof Kozlowski
[not found] ` <20170311172527.16368-5-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-03-12 20:49 ` Guenter Roeck
2017-03-12 20:49 ` Guenter Roeck
2017-03-12 20:49 ` Guenter Roeck
2017-03-14 12:58 ` Bartlomiej Zolnierkiewicz
2017-03-14 12:58 ` Bartlomiej Zolnierkiewicz
2017-03-14 12:58 ` Bartlomiej Zolnierkiewicz
2017-03-14 13:04 ` Krzysztof Kozlowski
2017-03-14 13:04 ` Krzysztof Kozlowski
[not found] ` <CGME20170314133035epcas1p47a04430402688bbb6baebad69b8e5b24@epcas1p4.samsung.com>
[not found] ` <CAJKOXPeCK1cjY78+PfcTprTnyXJ1k9zcUj8nW7onG8y0TWGzzQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-14 13:30 ` Bartlomiej Zolnierkiewicz
2017-03-14 13:30 ` Bartlomiej Zolnierkiewicz
2017-03-14 13:30 ` Bartlomiej Zolnierkiewicz
2017-03-14 13:34 ` Krzysztof Kozlowski
2017-03-14 13:34 ` Krzysztof Kozlowski
2017-03-14 13:34 ` Krzysztof Kozlowski
2017-03-11 17:25 ` [PATCH v2 5/8] ARM: dts: exynos: Enable watchdog on all Exynos4 boards Krzysztof Kozlowski
2017-03-11 17:25 ` Krzysztof Kozlowski
2017-03-11 17:25 ` Krzysztof Kozlowski
[not found] ` <20170311172527.16368-6-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-03-12 20:50 ` Guenter Roeck
2017-03-12 20:50 ` Guenter Roeck
2017-03-12 20:50 ` Guenter Roeck
2017-03-14 13:00 ` Bartlomiej Zolnierkiewicz
2017-03-14 13:00 ` Bartlomiej Zolnierkiewicz
2017-03-14 13:00 ` Bartlomiej Zolnierkiewicz
2017-03-11 17:25 ` [PATCH v2 6/8] ARM: dts: exynos: Fix infinite interrupt in soft mode on Exynos4210 and Exynos5440 Krzysztof Kozlowski
2017-03-11 17:25 ` Krzysztof Kozlowski
2017-03-11 17:25 ` Krzysztof Kozlowski
2017-03-12 20:50 ` Guenter Roeck
2017-03-12 20:50 ` Guenter Roeck
[not found] ` <CGME20170314130505epcas5p3ae5e356cfdf8b7b1d66256e47ea168ee@epcas5p3.samsung.com>
[not found] ` <20170311172527.16368-7-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-03-14 13:05 ` Bartlomiej Zolnierkiewicz
2017-03-14 13:05 ` Bartlomiej Zolnierkiewicz
2017-03-14 13:05 ` Bartlomiej Zolnierkiewicz
2017-03-11 17:25 ` [PATCH v2 7/8] ARM: dts: s3c64xx: Fix infinite interrupt in soft mode Krzysztof Kozlowski
2017-03-11 17:25 ` Krzysztof Kozlowski
2017-03-11 17:25 ` Krzysztof Kozlowski
[not found] ` <20170311172527.16368-8-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-03-12 20:51 ` Guenter Roeck
2017-03-12 20:51 ` Guenter Roeck
2017-03-12 20:51 ` Guenter Roeck
2017-03-14 13:07 ` Bartlomiej Zolnierkiewicz
2017-03-14 13:07 ` Bartlomiej Zolnierkiewicz
2017-03-14 13:07 ` Bartlomiej Zolnierkiewicz
2017-03-11 17:25 ` [PATCH v2 8/8] ARM: dts: s5pv210: " Krzysztof Kozlowski
2017-03-11 17:25 ` Krzysztof Kozlowski
2017-03-12 20:51 ` Guenter Roeck
2017-03-12 20:51 ` Guenter Roeck
2017-03-14 13:07 ` Bartlomiej Zolnierkiewicz
2017-03-14 13:07 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6788694.7QfyuOlrPv@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.