[PATCH BlueZ] shared/asha: Only update device set after start succeeds

[PATCH BlueZ] shared/asha: Only update device set after start succeeds

[Arun Raghavan]

This ensures that one side's connected status is only exposed to the
other after the connection is actually complete.
---
 src/shared/asha.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/shared/asha.c b/src/shared/asha.c
index e623e7156..33bec40da 100644
--- a/src/shared/asha.c
+++ b/src/shared/asha.c
@@ -421,8 +421,6 @@ static void read_rops(bool success,
 			asha->right_side, asha->binaural, asha->csis_supported,
 			asha->render_delay, asha->codec_ids);
 
-	update_asha_set(asha, true);
-
 	check_probe_done(asha);
 }
 
@@ -447,6 +445,7 @@ static void audio_status_notify(uint16_t value_handle, const uint8_t *value,
 		if (status == 0) {
 			asha->state = ASHA_STARTED;
 			DBG("ASHA start complete");
+			update_asha_set(asha, true);
 			asha_set_send_status(asha, true);
 		} else {
 			bt_asha_state_reset(asha);
-- 
2.49.0

RE: [BlueZ] shared/asha: Only update device set after start succeeds

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=957057

---Test result---

Test Summary:
CheckPatch                    PENDING   0.25 seconds
GitLint                       PENDING   0.26 seconds
BuildEll                      PASS      20.34 seconds
BluezMake                     PASS      2631.47 seconds
MakeCheck                     PASS      20.23 seconds
MakeDistcheck                 PASS      197.03 seconds
CheckValgrind                 PASS      273.68 seconds
CheckSmatch                   PASS      301.68 seconds
bluezmakeextell               PASS      127.80 seconds
IncrementalBuild              PENDING   0.22 seconds
ScanBuild                     PASS      895.10 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ] shared/asha: Only update device set after start succeeds

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri, 25 Apr 2025 10:04:47 -0400 you wrote:
> This ensures that one side's connected status is only exposed to the
> other after the connection is actually complete.
> ---
>  src/shared/asha.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Here is the summary with links:
  - [BlueZ] shared/asha: Only update device set after start succeeds
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c29bb3f92825

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html