From: Boqun Feng <boqun.feng@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Waiman Long <longman@redhat.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>
Subject: Re: [PATCH v1 1/1] lockdep: Move hlock_equal() to the respective ifdeffery
Date: Fri, 2 May 2025 07:44:53 -0700 [thread overview]
Message-ID: <6814da67.050a0220.2f3283.cdc1@mx.google.com> (raw)
In-Reply-To: <aBTP9AaJ0uyzAjxG@smile.fi.intel.com>
Hi Andy,
On Fri, May 02, 2025 at 05:00:20PM +0300, Andy Shevchenko wrote:
> On Tue, Apr 15, 2025 at 11:58:56AM +0300, Andy Shevchenko wrote:
> > When hlock_equal() is unused, it prevents kernel builds with clang,
> > `make W=1` and CONFIG_WERROR=y, CONFIG_LOCKDEP=y and
> > CONFIG_LOCKDEP_SMALL=n:
> >
> > lockdep.c:2005:20: error: unused function 'hlock_equal' [-Werror,-Wunused-function]
> >
> > Fix this by moving the function to the respective existing ifdeffery
> > for its the only user.
> >
> > See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
> > inline functions for W=1 build").
>
> Any news here, please? The problem still exists in v6.15-rc4.
>
This is in my radar, so it will be in a PR to tip soon. I didn't reply
earlier because I meant to find a whole cleanup for ifdefferies in
lockdep:
https://lore.kernel.org/lkml/Z46BJ8FhWCIXbM7p@boqun-archlinux/
to avoid whack-a-mole fixes. I never found time so I have to postpone
that. Thanks!
Regards,
Boqun
> --
> With Best Regards,
> Andy Shevchenko
>
>
next prev parent reply other threads:[~2025-05-02 14:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 8:58 [PATCH v1 1/1] lockdep: Move hlock_equal() to the respective ifdeffery Andy Shevchenko
2025-05-02 14:00 ` Andy Shevchenko
2025-05-02 14:44 ` Boqun Feng [this message]
2025-05-02 14:54 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6814da67.050a0220.2f3283.cdc1@mx.google.com \
--to=boqun.feng@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.