Re: [PATCH v1 1/1] lockdep: Move hlock_equal() to the respective ifdeffery

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Fri, May 02, 2025 at 07:44:53AM -0700, Boqun Feng wrote:
> On Fri, May 02, 2025 at 05:00:20PM +0300, Andy Shevchenko wrote:
> > On Tue, Apr 15, 2025 at 11:58:56AM +0300, Andy Shevchenko wrote:
> > > When hlock_equal() is unused, it prevents kernel builds with clang,
> > > `make W=1` and CONFIG_WERROR=y, CONFIG_LOCKDEP=y and
> > > CONFIG_LOCKDEP_SMALL=n:
> > > 
> > >   lockdep.c:2005:20: error: unused function 'hlock_equal' [-Werror,-Wunused-function]
> > > 
> > > Fix this by moving the function to the respective existing ifdeffery
> > > for its the only user.
> > > 
> > > See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
> > > inline functions for W=1 build").
> > 
> > Any news here, please? The problem still exists in v6.15-rc4.
> 
> This is in my radar, so it will be in a PR to tip soon. I didn't reply
> earlier because I meant to find a whole cleanup for ifdefferies in
> lockdep:
> 
> 	https://lore.kernel.org/lkml/Z46BJ8FhWCIXbM7p@boqun-archlinux/

This is good news! Nobody likes ifdeffery, it makes code harder to read.

> to avoid whack-a-mole fixes. I never found time so I have to postpone
> that. Thanks!

-- 
With Best Regards,
Andy Shevchenko