[PATCH BlueZ] shared/asha: Fix bad parens in a comparison

[PATCH BlueZ] shared/asha: Fix bad parens in a comparison

[Arun Raghavan]

The last parameter to the memcmp was incorrectly the result of the
comparison rather than the sizeof()'s value.
---
 src/shared/asha.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/shared/asha.c b/src/shared/asha.c
index 3e1673488..69906fcc5 100644
--- a/src/shared/asha.c
+++ b/src/shared/asha.c
@@ -348,7 +348,7 @@ static void check_probe_done(struct bt_asha *asha)
 
 	/* Once we have ROPs & PSM, we should be good to go */
 	if (asha->psm == 0 || memcmp(asha->hisyncid, zeroes,
-					sizeof(zeroes) == 0))
+					sizeof(zeroes)) == 0)
 		return;
 
 	if (asha->attach_cb) {
-- 
2.49.0

RE: [BlueZ] shared/asha: Fix bad parens in a comparison

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=961533

---Test result---

Test Summary:
CheckPatch                    PENDING   0.26 seconds
GitLint                       PENDING   0.37 seconds
BuildEll                      PASS      20.38 seconds
BluezMake                     PASS      2679.03 seconds
MakeCheck                     PASS      20.83 seconds
MakeDistcheck                 PASS      196.74 seconds
CheckValgrind                 PASS      272.92 seconds
CheckSmatch                   PASS      300.59 seconds
bluezmakeextell               PASS      127.72 seconds
IncrementalBuild              PENDING   0.27 seconds
ScanBuild                     PASS      897.24 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ] shared/asha: Fix bad parens in a comparison

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri,  9 May 2025 16:53:41 -0400 you wrote:
> The last parameter to the memcmp was incorrectly the result of the
> comparison rather than the sizeof()'s value.
> ---
>  src/shared/asha.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [BlueZ] shared/asha: Fix bad parens in a comparison
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=5a112d14e423

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html