[PATCH BlueZ v1] client: Fix crashing command info

[PATCH BlueZ v1] client: Fix crashing command info

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

If command info is called without any parameters, and without connecting
any device, it will call find_set which doesn't check argc and argv are
actually valid.

Fixes: https://github.com/bluez/bluez/issues/1251
---
 client/main.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/client/main.c b/client/main.c
index 36a7446d52c1..5d53a7be11e4 100644
--- a/client/main.c
+++ b/client/main.c
@@ -1641,6 +1641,9 @@ static struct GDBusProxy *find_set(int argc, char *argv[])
 	if (check_default_ctrl() == FALSE)
 		return NULL;
 
+	if (argc < 2 || !strlen(argv[1]))
+		return NULL;
+
 	proxy = find_proxies_by_path(default_ctrl->sets, argv[1]);
 	if (!proxy) {
 		bt_shell_printf("DeviceSet %s not available\n", argv[1]);
-- 
2.49.0

RE: [BlueZ,v1] client: Fix crashing command info

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=964210

---Test result---

Test Summary:
CheckPatch                    PENDING   0.27 seconds
GitLint                       PENDING   0.23 seconds
BuildEll                      PASS      20.61 seconds
BluezMake                     PASS      2741.00 seconds
MakeCheck                     PASS      20.66 seconds
MakeDistcheck                 PASS      197.23 seconds
CheckValgrind                 PASS      272.58 seconds
CheckSmatch                   PASS      299.74 seconds
bluezmakeextell               PASS      127.64 seconds
IncrementalBuild              PENDING   0.29 seconds
ScanBuild                     PASS      913.75 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v1] client: Fix crashing command info

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 19 May 2025 10:20:09 -0400 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> If command info is called without any parameters, and without connecting
> any device, it will call find_set which doesn't check argc and argv are
> actually valid.
> 
> Fixes: https://github.com/bluez/bluez/issues/1251
> 
> [...]

Here is the summary with links:
  - [BlueZ,v1] client: Fix crashing command info
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=6a8fb8a00e53

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html