* [PATCH BlueZ 0/3] Propagate disconnection reason
@ 2025-05-19 16:14 Frédéric Danis
2025-05-19 16:14 ` [PATCH BlueZ 1/3] src/device: Add Disconnected signal to propagate " Frédéric Danis
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: Frédéric Danis @ 2025-05-19 16:14 UTC (permalink / raw)
To: linux-bluetooth
Currently a client application is informed of the disconnection by the
update of the Connected property to false.
This sends a Disconnected signal with the disconnection reason before
the property is updated.
This will help client application to know the reason for the
disconnection and to take appropriate action.
bluetoothctl is updated to display the disconnection reason on reception
of the signal.
This can be tested in bluetoothctl by disconnecting a device, which
generates:
[SIGNAL] org.bluez.Device1.Disconnected disconnection-local-host
Frédéric Danis (3):
src/device: Add Disconnected signal to propagate disconnection reason
doc/device: Add Disconnected signal
client: Display disconnection reason
client/main.c | 20 ++++++++++++++++++++
doc/org.bluez.Device.rst | 17 +++++++++++++++++
src/adapter.c | 13 ++++++++-----
src/device.c | 37 +++++++++++++++++++++++++++++++++++--
src/device.h | 3 ++-
5 files changed, 82 insertions(+), 8 deletions(-)
--
2.43.0
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH BlueZ 1/3] src/device: Add Disconnected signal to propagate disconnection reason
2025-05-19 16:14 [PATCH BlueZ 0/3] Propagate disconnection reason Frédéric Danis
@ 2025-05-19 16:14 ` Frédéric Danis
2025-05-19 17:56 ` Propagate " bluez.test.bot
2025-05-19 16:14 ` [PATCH BlueZ 2/3] doc/device: Add Disconnected signal Frédéric Danis
2025-05-19 16:14 ` [PATCH BlueZ 3/3] client: Display disconnection reason Frédéric Danis
2 siblings, 1 reply; 13+ messages in thread
From: Frédéric Danis @ 2025-05-19 16:14 UTC (permalink / raw)
To: linux-bluetooth
Currently a client application is informed of the disconnection by the
update of the Connected property to false.
This sends a Disconnected signal with the disconnection reason before
the property is updated.
This helps client application to know the reason for the disconnection
and to take appropriate action.
---
src/adapter.c | 13 ++++++++-----
src/device.c | 37 +++++++++++++++++++++++++++++++++++--
src/device.h | 3 ++-
3 files changed, 45 insertions(+), 8 deletions(-)
diff --git a/src/adapter.c b/src/adapter.c
index fd425e6d2..a10721489 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -7549,7 +7549,8 @@ struct agent *adapter_get_agent(struct btd_adapter *adapter)
static void adapter_remove_connection(struct btd_adapter *adapter,
struct btd_device *device,
- uint8_t bdaddr_type)
+ uint8_t bdaddr_type,
+ uint8_t reason)
{
bool remove_device = false;
@@ -7560,7 +7561,7 @@ static void adapter_remove_connection(struct btd_adapter *adapter,
return;
}
- device_remove_connection(device, bdaddr_type, &remove_device);
+ device_remove_connection(device, bdaddr_type, &remove_device, reason);
device_cancel_authentication(device, TRUE);
@@ -7601,9 +7602,11 @@ static void adapter_stop(struct btd_adapter *adapter)
struct btd_device *device = adapter->connections->data;
uint8_t addr_type = btd_device_get_bdaddr_type(device);
- adapter_remove_connection(adapter, device, BDADDR_BREDR);
+ adapter_remove_connection(adapter, device, BDADDR_BREDR,
+ MGMT_DEV_DISCONN_UNKNOWN);
if (addr_type != BDADDR_BREDR)
- adapter_remove_connection(adapter, device, addr_type);
+ adapter_remove_connection(adapter, device, addr_type,
+ MGMT_DEV_DISCONN_UNKNOWN);
}
g_dbus_emit_property_changed(dbus_conn, adapter->path,
@@ -8551,7 +8554,7 @@ static void dev_disconnected(struct btd_adapter *adapter,
device = btd_adapter_find_device(adapter, &addr->bdaddr, addr->type);
if (device) {
- adapter_remove_connection(adapter, device, addr->type);
+ adapter_remove_connection(adapter, device, addr->type, reason);
disconnect_notify(device, reason);
}
diff --git a/src/device.c b/src/device.c
index d230af0a8..16e880f71 100644
--- a/src/device.c
+++ b/src/device.c
@@ -3417,6 +3417,12 @@ static const GDBusMethodTable device_methods[] = {
{ }
};
+static const GDBusSignalTable device_signals[] = {
+ { GDBUS_SIGNAL("Disconnected",
+ GDBUS_ARGS({ "reason", "s" })) },
+ { }
+};
+
static gboolean
dev_property_get_prefer_bearer(const GDBusPropertyTable *property,
DBusMessageIter *iter, void *data)
@@ -3637,13 +3643,34 @@ static void set_temporary_timer(struct btd_device *dev, unsigned int timeout)
dev, NULL);
}
+static const char *disconnect_reason(uint8_t reason)
+{
+ switch (reason) {
+ case MGMT_DEV_DISCONN_UNKNOWN:
+ return "disconnection-unknown";
+ case MGMT_DEV_DISCONN_TIMEOUT:
+ return "disconnection-timeout";
+ case MGMT_DEV_DISCONN_LOCAL_HOST:
+ return "disconnection-local-host";
+ case MGMT_DEV_DISCONN_REMOTE:
+ return "disconnection-remote";
+ case MGMT_DEV_DISCONN_LOCAL_HOST_SUSPEND:
+ return "disconnection-local-suspend";
+ default:
+ warn("Unknown disocnnection value: %u", reason);
+ return "disconnection-unknown";
+ }
+}
+
void device_remove_connection(struct btd_device *device, uint8_t bdaddr_type,
- bool *remove)
+ bool *remove,
+ uint8_t reason)
{
struct bearer_state *state = get_state(device, bdaddr_type);
DBusMessage *reply;
bool remove_device = false;
bool paired_status_updated = false;
+ const char *str_reason;
if (!state->connected)
return;
@@ -3708,6 +3735,12 @@ void device_remove_connection(struct btd_device *device, uint8_t bdaddr_type,
g_slist_free_full(device->eir_uuids, g_free);
device->eir_uuids = NULL;
+ str_reason = disconnect_reason(reason);
+ g_dbus_emit_signal(dbus_conn, device->path, DEVICE_INTERFACE,
+ "Disconnected",
+ DBUS_TYPE_STRING, &str_reason,
+ DBUS_TYPE_INVALID);
+
g_dbus_emit_property_changed(dbus_conn, device->path,
DEVICE_INTERFACE, "Connected");
@@ -4611,7 +4644,7 @@ static struct btd_device *device_new(struct btd_adapter *adapter,
if (g_dbus_register_interface(dbus_conn,
device->path, DEVICE_INTERFACE,
- device_methods, NULL,
+ device_methods, device_signals,
device_properties, device,
device_free) == FALSE) {
error("Unable to register device interface for %s", address);
diff --git a/src/device.h b/src/device.h
index a35bb1386..4eebcebe9 100644
--- a/src/device.h
+++ b/src/device.h
@@ -134,7 +134,8 @@ gboolean device_is_authenticating(struct btd_device *device);
void device_add_connection(struct btd_device *dev, uint8_t bdaddr_type,
uint32_t flags);
void device_remove_connection(struct btd_device *device, uint8_t bdaddr_type,
- bool *remove);
+ bool *remove,
+ uint8_t reason);
void device_request_disconnect(struct btd_device *device, DBusMessage *msg);
bool device_is_disconnecting(struct btd_device *device);
void device_set_ltk(struct btd_device *device, const uint8_t val[16],
--
2.43.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH BlueZ 2/3] doc/device: Add Disconnected signal
2025-05-19 16:14 [PATCH BlueZ 0/3] Propagate disconnection reason Frédéric Danis
2025-05-19 16:14 ` [PATCH BlueZ 1/3] src/device: Add Disconnected signal to propagate " Frédéric Danis
@ 2025-05-19 16:14 ` Frédéric Danis
2025-05-19 16:44 ` Luiz Augusto von Dentz
2025-05-19 16:14 ` [PATCH BlueZ 3/3] client: Display disconnection reason Frédéric Danis
2 siblings, 1 reply; 13+ messages in thread
From: Frédéric Danis @ 2025-05-19 16:14 UTC (permalink / raw)
To: linux-bluetooth
---
doc/org.bluez.Device.rst | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/doc/org.bluez.Device.rst b/doc/org.bluez.Device.rst
index 80501eddd..6229f95ad 100644
--- a/doc/org.bluez.Device.rst
+++ b/doc/org.bluez.Device.rst
@@ -155,6 +155,23 @@ array{array{byte}} GetServiceRecords() [experimental]
:org.bluez.Error.NotConnected:
:org.bluez.Error.DoesNotExist:
+Signals
+-------
+
+void Disconnected(string reason)
+````````````````````````````````
+
+ This signal is launched when a device is disconnected with the reason of
+ the disconnection.
+
+ Possible reasons:
+
+ :disconnection-unknown:
+ :disconnection-timeout:
+ :disconnection-local-host:
+ :disconnection-remote:
+ :disconnection-local-suspend:
+
Properties
----------
--
2.43.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH BlueZ 3/3] client: Display disconnection reason
2025-05-19 16:14 [PATCH BlueZ 0/3] Propagate disconnection reason Frédéric Danis
2025-05-19 16:14 ` [PATCH BlueZ 1/3] src/device: Add Disconnected signal to propagate " Frédéric Danis
2025-05-19 16:14 ` [PATCH BlueZ 2/3] doc/device: Add Disconnected signal Frédéric Danis
@ 2025-05-19 16:14 ` Frédéric Danis
2 siblings, 0 replies; 13+ messages in thread
From: Frédéric Danis @ 2025-05-19 16:14 UTC (permalink / raw)
To: linux-bluetooth
The new org.bluez.Device1.Disconnected signal propagates the
disconnection reason.
---
client/main.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/client/main.c b/client/main.c
index 57d71f2b6..79d0707bb 100644
--- a/client/main.c
+++ b/client/main.c
@@ -709,6 +709,26 @@ static void property_changed(GDBusProxy *proxy, const char *name,
static void message_handler(DBusConnection *connection,
DBusMessage *message, void *user_data)
{
+ if (!strcmp(dbus_message_get_member(message), "Disconnected")) {
+ DBusMessageIter iter;
+ const char *reason;
+
+ if (!dbus_message_iter_init(message, &iter))
+ goto failed;
+
+ if (dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_STRING)
+ goto failed;
+
+ dbus_message_iter_get_basic(&iter, &reason);
+
+ bt_shell_printf("[SIGNAL] %s.%s %s\n",
+ dbus_message_get_interface(message),
+ dbus_message_get_member(message),
+ reason);
+ return;
+ }
+
+failed:
bt_shell_printf("[SIGNAL] %s.%s\n", dbus_message_get_interface(message),
dbus_message_get_member(message));
}
--
2.43.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH BlueZ 2/3] doc/device: Add Disconnected signal
2025-05-19 16:14 ` [PATCH BlueZ 2/3] doc/device: Add Disconnected signal Frédéric Danis
@ 2025-05-19 16:44 ` Luiz Augusto von Dentz
2025-05-19 19:22 ` Bastien Nocera
2025-05-20 9:26 ` Frédéric Danis
0 siblings, 2 replies; 13+ messages in thread
From: Luiz Augusto von Dentz @ 2025-05-19 16:44 UTC (permalink / raw)
To: Frédéric Danis; +Cc: linux-bluetooth
Hi Frédéric,
On Mon, May 19, 2025 at 12:18 PM Frédéric Danis
<frederic.danis@collabora.com> wrote:
>
> ---
> doc/org.bluez.Device.rst | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/doc/org.bluez.Device.rst b/doc/org.bluez.Device.rst
> index 80501eddd..6229f95ad 100644
> --- a/doc/org.bluez.Device.rst
> +++ b/doc/org.bluez.Device.rst
> @@ -155,6 +155,23 @@ array{array{byte}} GetServiceRecords() [experimental]
> :org.bluez.Error.NotConnected:
> :org.bluez.Error.DoesNotExist:
>
> +Signals
> +-------
> +
> +void Disconnected(string reason)
> +````````````````````````````````
> +
> + This signal is launched when a device is disconnected with the reason of
> + the disconnection.
> +
> + Possible reasons:
> +
> + :disconnection-unknown:
> + :disconnection-timeout:
> + :disconnection-local-host:
> + :disconnection-remote:
> + :disconnection-local-suspend:
Perhaps it would be better to use to the actual HCI code instead of
converting it to string, since I suspect application using this signal
may want to recover the actual error to do some sort of reconnecting
policy, etc, or having them both in case the client just wants to
print it.
> +
> Properties
> ----------
>
> --
> 2.43.0
>
>
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: Propagate disconnection reason
2025-05-19 16:14 ` [PATCH BlueZ 1/3] src/device: Add Disconnected signal to propagate " Frédéric Danis
@ 2025-05-19 17:56 ` bluez.test.bot
0 siblings, 0 replies; 13+ messages in thread
From: bluez.test.bot @ 2025-05-19 17:56 UTC (permalink / raw)
To: linux-bluetooth, frederic.danis
[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=964261
---Test result---
Test Summary:
CheckPatch PENDING 0.26 seconds
GitLint PENDING 0.33 seconds
BuildEll PASS 19.99 seconds
BluezMake PASS 2726.44 seconds
MakeCheck PASS 20.36 seconds
MakeDistcheck PASS 197.77 seconds
CheckValgrind PASS 272.16 seconds
CheckSmatch PASS 297.58 seconds
bluezmakeextell PASS 126.66 seconds
IncrementalBuild PENDING 0.32 seconds
ScanBuild PASS 899.13 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH BlueZ 2/3] doc/device: Add Disconnected signal
2025-05-19 16:44 ` Luiz Augusto von Dentz
@ 2025-05-19 19:22 ` Bastien Nocera
2025-05-20 9:32 ` Frédéric Danis
2025-05-20 9:26 ` Frédéric Danis
1 sibling, 1 reply; 13+ messages in thread
From: Bastien Nocera @ 2025-05-19 19:22 UTC (permalink / raw)
To: Luiz Augusto von Dentz, Frédéric Danis; +Cc: linux-bluetooth
On Mon, 2025-05-19 at 12:44 -0400, Luiz Augusto von Dentz wrote:
> Hi Frédéric,
>
> On Mon, May 19, 2025 at 12:18 PM Frédéric Danis
> <frederic.danis@collabora.com> wrote:
> >
> > ---
> > doc/org.bluez.Device.rst | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> >
> > diff --git a/doc/org.bluez.Device.rst b/doc/org.bluez.Device.rst
> > index 80501eddd..6229f95ad 100644
> > --- a/doc/org.bluez.Device.rst
> > +++ b/doc/org.bluez.Device.rst
> > @@ -155,6 +155,23 @@ array{array{byte}} GetServiceRecords()
> > [experimental]
> > :org.bluez.Error.NotConnected:
> > :org.bluez.Error.DoesNotExist:
> >
> > +Signals
> > +-------
> > +
> > +void Disconnected(string reason)
> > +````````````````````````````````
> > +
> > + This signal is launched when a device is disconnected with
> > the reason of
> > + the disconnection.
> > +
> > + Possible reasons:
> > +
> > + :disconnection-unknown:
> > + :disconnection-timeout:
> > + :disconnection-local-host:
> > + :disconnection-remote:
> > + :disconnection-local-suspend:
>
> Perhaps it would be better to use to the actual HCI code instead of
> converting it to string, since I suspect application using this
> signal
> may want to recover the actual error to do some sort of reconnecting
> policy, etc, or having them both in case the client just wants to
> print it.
If there are applications using those signals (I'm guessing, Bluetooth
settings apps), whatever the format of the error, could we have an
expected behaviour associated with individual error types?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH BlueZ 2/3] doc/device: Add Disconnected signal
2025-05-19 16:44 ` Luiz Augusto von Dentz
2025-05-19 19:22 ` Bastien Nocera
@ 2025-05-20 9:26 ` Frédéric Danis
1 sibling, 0 replies; 13+ messages in thread
From: Frédéric Danis @ 2025-05-20 9:26 UTC (permalink / raw)
To: Luiz Augusto von Dentz; +Cc: linux-bluetooth
Hi Luiz,
On 19/05/2025 18:44, Luiz Augusto von Dentz wrote:
> Hi Frédéric,
>
> On Mon, May 19, 2025 at 12:18 PM Frédéric Danis
> <frederic.danis@collabora.com> wrote:
>> ---
>> doc/org.bluez.Device.rst | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/doc/org.bluez.Device.rst b/doc/org.bluez.Device.rst
>> index 80501eddd..6229f95ad 100644
>> --- a/doc/org.bluez.Device.rst
>> +++ b/doc/org.bluez.Device.rst
>> @@ -155,6 +155,23 @@ array{array{byte}} GetServiceRecords() [experimental]
>> :org.bluez.Error.NotConnected:
>> :org.bluez.Error.DoesNotExist:
>>
>> +Signals
>> +-------
>> +
>> +void Disconnected(string reason)
>> +````````````````````````````````
>> +
>> + This signal is launched when a device is disconnected with the reason of
>> + the disconnection.
>> +
>> + Possible reasons:
>> +
>> + :disconnection-unknown:
>> + :disconnection-timeout:
>> + :disconnection-local-host:
>> + :disconnection-remote:
>> + :disconnection-local-suspend:
> Perhaps it would be better to use to the actual HCI code instead of
> converting it to string, since I suspect application using this signal
> may want to recover the actual error to do some sort of reconnecting
> policy, etc, or having them both in case the client just wants to
> print it.
I will update the patch to use the numerical value.
But, the reason provided by MGMT_EV_DEVICE_DISCONNECTED is not the
HCI code but a mgmt value translated in net/bluetooth/hci_event.c
(https://github.com/bluez/bluetooth-next/blob/master/net/bluetooth/hci_event.c#L3366)
--
Frédéric Danis
Senior Software Engineer
Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, United Kingdom
Registered in England & Wales, no. 5513718
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH BlueZ 2/3] doc/device: Add Disconnected signal
2025-05-19 19:22 ` Bastien Nocera
@ 2025-05-20 9:32 ` Frédéric Danis
2025-05-20 10:22 ` Bastien Nocera
0 siblings, 1 reply; 13+ messages in thread
From: Frédéric Danis @ 2025-05-20 9:32 UTC (permalink / raw)
To: Bastien Nocera, Luiz Augusto von Dentz; +Cc: linux-bluetooth
Hi Bastien,
On 19/05/2025 21:22, Bastien Nocera wrote:
> On Mon, 2025-05-19 at 12:44 -0400, Luiz Augusto von Dentz wrote:
>> Hi Frédéric,
>>
>> On Mon, May 19, 2025 at 12:18 PM Frédéric Danis
>> <frederic.danis@collabora.com> wrote:
>>> ---
>>> doc/org.bluez.Device.rst | 17 +++++++++++++++++
>>> 1 file changed, 17 insertions(+)
>>>
>>> diff --git a/doc/org.bluez.Device.rst b/doc/org.bluez.Device.rst
>>> index 80501eddd..6229f95ad 100644
>>> --- a/doc/org.bluez.Device.rst
>>> +++ b/doc/org.bluez.Device.rst
>>> @@ -155,6 +155,23 @@ array{array{byte}} GetServiceRecords()
>>> [experimental]
>>> :org.bluez.Error.NotConnected:
>>> :org.bluez.Error.DoesNotExist:
>>>
>>> +Signals
>>> +-------
>>> +
>>> +void Disconnected(string reason)
>>> +````````````````````````````````
>>> +
>>> + This signal is launched when a device is disconnected with
>>> the reason of
>>> + the disconnection.
>>> +
>>> + Possible reasons:
>>> +
>>> + :disconnection-unknown:
>>> + :disconnection-timeout:
>>> + :disconnection-local-host:
>>> + :disconnection-remote:
>>> + :disconnection-local-suspend:
>> Perhaps it would be better to use to the actual HCI code instead of
>> converting it to string, since I suspect application using this
>> signal
>> may want to recover the actual error to do some sort of reconnecting
>> policy, etc, or having them both in case the client just wants to
>> print it.
> If there are applications using those signals (I'm guessing, Bluetooth
> settings apps), whatever the format of the error, could we have an
> expected behaviour associated with individual error types?
This could be used by client apps like Bluetooth setting to try to
reconnect to the device in case of timeout or unknown disconnection,
or to try to connect to another device depending on internal policy.
--
Frédéric Danis
Senior Software Engineer
Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, United Kingdom
Registered in England & Wales, no. 5513718
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH BlueZ 2/3] doc/device: Add Disconnected signal
2025-05-20 9:32 ` Frédéric Danis
@ 2025-05-20 10:22 ` Bastien Nocera
0 siblings, 0 replies; 13+ messages in thread
From: Bastien Nocera @ 2025-05-20 10:22 UTC (permalink / raw)
To: Frédéric Danis, Luiz Augusto von Dentz; +Cc: linux-bluetooth
On Tue, 2025-05-20 at 11:32 +0200, Frédéric Danis wrote:
> Hi Bastien,
>
> On 19/05/2025 21:22, Bastien Nocera wrote:
> > On Mon, 2025-05-19 at 12:44 -0400, Luiz Augusto von Dentz wrote:
> > > Hi Frédéric,
> > >
> > > On Mon, May 19, 2025 at 12:18 PM Frédéric Danis
> > > <frederic.danis@collabora.com> wrote:
> > > > ---
> > > > doc/org.bluez.Device.rst | 17 +++++++++++++++++
> > > > 1 file changed, 17 insertions(+)
> > > >
> > > > diff --git a/doc/org.bluez.Device.rst
> > > > b/doc/org.bluez.Device.rst
> > > > index 80501eddd..6229f95ad 100644
> > > > --- a/doc/org.bluez.Device.rst
> > > > +++ b/doc/org.bluez.Device.rst
> > > > @@ -155,6 +155,23 @@ array{array{byte}} GetServiceRecords()
> > > > [experimental]
> > > > :org.bluez.Error.NotConnected:
> > > > :org.bluez.Error.DoesNotExist:
> > > >
> > > > +Signals
> > > > +-------
> > > > +
> > > > +void Disconnected(string reason)
> > > > +````````````````````````````````
> > > > +
> > > > + This signal is launched when a device is disconnected
> > > > with
> > > > the reason of
> > > > + the disconnection.
> > > > +
> > > > + Possible reasons:
> > > > +
> > > > + :disconnection-unknown:
> > > > + :disconnection-timeout:
> > > > + :disconnection-local-host:
> > > > + :disconnection-remote:
> > > > + :disconnection-local-suspend:
> > > Perhaps it would be better to use to the actual HCI code instead
> > > of
> > > converting it to string, since I suspect application using this
> > > signal
> > > may want to recover the actual error to do some sort of
> > > reconnecting
> > > policy, etc, or having them both in case the client just wants to
> > > print it.
> > If there are applications using those signals (I'm guessing,
> > Bluetooth
> > settings apps), whatever the format of the error, could we have an
> > expected behaviour associated with individual error types?
>
> This could be used by client apps like Bluetooth setting to try to
> reconnect to the device in case of timeout or unknown disconnection,
> or to try to connect to another device depending on internal policy.
I meant having that information in the docs :)
Cheers
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: Propagate disconnection reason
2025-05-20 16:26 [PATCH BlueZ v2 1/3] src/device: Add Disconnected signal to propagate " Frédéric Danis
@ 2025-05-20 17:58 ` bluez.test.bot
0 siblings, 0 replies; 13+ messages in thread
From: bluez.test.bot @ 2025-05-20 17:58 UTC (permalink / raw)
To: linux-bluetooth, frederic.danis
[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=964653
---Test result---
Test Summary:
CheckPatch PENDING 0.27 seconds
GitLint PENDING 0.28 seconds
BuildEll PASS 19.94 seconds
BluezMake PASS 2553.76 seconds
MakeCheck PASS 20.74 seconds
MakeDistcheck PASS 199.00 seconds
CheckValgrind PASS 275.54 seconds
CheckSmatch PASS 300.86 seconds
bluezmakeextell PASS 127.42 seconds
IncrementalBuild PENDING 0.22 seconds
ScanBuild PASS 896.76 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: Propagate disconnection reason
2025-05-22 15:49 [PATCH BlueZ v3 1/3] src/device: Add Disconnected signal to propagate " Frédéric Danis
@ 2025-05-22 17:01 ` bluez.test.bot
0 siblings, 0 replies; 13+ messages in thread
From: bluez.test.bot @ 2025-05-22 17:01 UTC (permalink / raw)
To: linux-bluetooth, frederic.danis
[-- Attachment #1: Type: text/plain, Size: 35977 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=965460
---Test result---
Test Summary:
CheckPatch PENDING 0.28 seconds
GitLint PENDING 0.86 seconds
BuildEll PASS 20.05 seconds
BluezMake FAIL 83.07 seconds
MakeCheck FAIL 3031.42 seconds
MakeDistcheck FAIL 53.97 seconds
CheckValgrind FAIL 60.83 seconds
CheckSmatch FAIL 189.88 seconds
bluezmakeextell FAIL 100.19 seconds
IncrementalBuild PENDING 0.22 seconds
ScanBuild FAIL 220.83 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: BluezMake - FAIL
Desc: Build BlueZ
Output:
tools/mgmt-tester.c: In function ‘main’:
tools/mgmt-tester.c:12907:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
12907 | int main(int argc, char *argv[])
| ^~~~
src/device.c: In function ‘emit_disconnect_reason’:
src/device.c:3764:7: error: ‘MGMT_DEV_DISCONN_AUTH_FAILURE’ undeclared (first use in this function); did you mean ‘MGMT_DEV_DISCONN_TIMEOUT’?
3764 | case MGMT_DEV_DISCONN_AUTH_FAILURE:
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| MGMT_DEV_DISCONN_TIMEOUT
src/device.c:3764:7: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [Makefile:11163: src/bluetoothd-device.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4691: all] Error 2
##############################
Test: MakeCheck - FAIL
Desc: Run Bluez Make Check
Output:
unit/test-avdtp.c: In function ‘main’:
unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
766 | int main(int argc, char *argv[])
| ^~~~
unit/test-avrcp.c: In function ‘main’:
unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
989 | int main(int argc, char *argv[])
| ^~~~
src/device.c: In function ‘emit_disconnect_reason’:
src/device.c:3764:7: error: ‘MGMT_DEV_DISCONN_AUTH_FAILURE’ undeclared (first use in this function); did you mean ‘MGMT_DEV_DISCONN_TIMEOUT’?
3764 | case MGMT_DEV_DISCONN_AUTH_FAILURE:
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| MGMT_DEV_DISCONN_TIMEOUT
src/device.c:3764:7: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [Makefile:11163: src/bluetoothd-device.o] Error 1
make: *** [Makefile:12346: check] Error 2
##############################
Test: MakeDistcheck - FAIL
Desc: Run Bluez Make Distcheck
Output:
Package cups was not found in the pkg-config search path.
Perhaps you should add the directory containing `cups.pc'
to the PKG_CONFIG_PATH environment variable
No package 'cups' found
../../src/device.c: In function ‘emit_disconnect_reason’:
../../src/device.c:3764:7: error: ‘MGMT_DEV_DISCONN_AUTH_FAILURE’ undeclared (first use in this function); did you mean ‘MGMT_DEV_DISCONN_TIMEOUT’?
3764 | case MGMT_DEV_DISCONN_AUTH_FAILURE:
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| MGMT_DEV_DISCONN_TIMEOUT
../../src/device.c:3764:7: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [Makefile:11163: src/bluetoothd-device.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:4691: all] Error 2
make: *** [Makefile:12267: distcheck] Error 1
##############################
Test: CheckValgrind - FAIL
Desc: Run Bluez Make Check with Valgrind
Output:
tools/mgmt-tester.c: In function ‘main’:
tools/mgmt-tester.c:12907:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
12907 | int main(int argc, char *argv[])
| ^~~~
src/device.c: In function ‘emit_disconnect_reason’:
src/device.c:3764:7: error: ‘MGMT_DEV_DISCONN_AUTH_FAILURE’ undeclared (first use in this function); did you mean ‘MGMT_DEV_DISCONN_TIMEOUT’?
3764 | case MGMT_DEV_DISCONN_AUTH_FAILURE:
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| MGMT_DEV_DISCONN_TIMEOUT
src/device.c:3764:7: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [Makefile:11163: src/bluetoothd-device.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:12346: check] Error 2
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:
src/shared/crypto.c:271:21: warning: Variable length array is used.
src/shared/crypto.c:272:23: warning: Variable length array is used.
src/shared/gatt-helpers.c:768:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:830:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1323:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1354:23: warning: Variable length array is used.
src/shared/gatt-server.c:278:25: warning: Variable length array is used.
src/shared/gatt-server.c:618:25: warning: Variable length array is used.
src/shared/gatt-server.c:716:25: warning: Variable length array is used.
src/shared/bap.c:315:25: warning: array of flexible structures
src/shared/bap.c: note: in included file:
./src/shared/ascs.h:88:25: warning: array of flexible structures
src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):
/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function'
/usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction'
/usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction'
/usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction'
src/shared/crypto.c:271:21: warning: Variable length array is used.
src/shared/crypto.c:272:23: warning: Variable length array is used.
src/shared/gatt-helpers.c:768:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:830:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1323:31: warning: Variable length array is used.
src/shared/gatt-helpers.c:1354:23: warning: Variable length array is used.
src/shared/gatt-server.c:278:25: warning: Variable length array is used.
src/shared/gatt-server.c:618:25: warning: Variable length array is used.
src/shared/gatt-server.c:716:25: warning: Variable length array is used.
src/shared/bap.c:315:25: warning: array of flexible structures
src/shared/bap.c: note: in included file:
./src/shared/ascs.h:88:25: warning: array of flexible structures
src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h):
/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function'
/usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction'
/usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction'
/usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction'
tools/mesh-cfgtest.c:1453:17: warning: unknown escape sequence: '\%'
tools/sco-tester.c: note: in included file:
./lib/bluetooth.h:232:15: warning: array of flexible structures
./lib/bluetooth.h:237:31: warning: array of flexible structures
tools/bneptest.c:634:39: warning: unknown escape sequence: '\%'
tools/seq2bseq.c:57:26: warning: Variable length array is used.
tools/obex-client-tool.c: note: in included file (through /usr/include/readline/readline.h):
/usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function'
/usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction'
/usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction'
/usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction'
android/avctp.c:505:34: warning: Variable length array is used.
android/avctp.c:556:34: warning: Variable length array is used.
unit/test-avrcp.c:373:26: warning: Variable length array is used.
unit/test-avrcp.c:398:26: warning: Variable length array is used.
unit/test-avrcp.c:414:24: warning: Variable length array is used.
android/avrcp-lib.c:1085:34: warning: Variable length array is used.
android/avrcp-lib.c:1583:34: warning: Variable length array is used.
android/avrcp-lib.c:1612:34: warning: Variable length array is used.
android/avrcp-lib.c:1638:34: warning: Variable length array is used.
src/device.c: In function ‘emit_disconnect_reason’:
src/device.c:3764:7: error: ‘MGMT_DEV_DISCONN_AUTH_FAILURE’ undeclared (first use in this function); did you mean ‘MGMT_DEV_DISCONN_TIMEOUT’?
3764 | case MGMT_DEV_DISCONN_AUTH_FAILURE:
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| MGMT_DEV_DISCONN_TIMEOUT
src/device.c:3764:7: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [Makefile:11163: src/bluetoothd-device.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4691: all] Error 2
##############################
Test: bluezmakeextell - FAIL
Desc: Build Bluez with External ELL
Output:
src/device.c: In function ‘emit_disconnect_reason’:
src/device.c:3764:7: error: ‘MGMT_DEV_DISCONN_AUTH_FAILURE’ undeclared (first use in this function); did you mean ‘MGMT_DEV_DISCONN_TIMEOUT’?
3764 | case MGMT_DEV_DISCONN_AUTH_FAILURE:
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| MGMT_DEV_DISCONN_TIMEOUT
src/device.c:3764:7: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [Makefile:11163: src/bluetoothd-device.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4691: all] Error 2
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
##############################
Test: ScanBuild - FAIL
Desc: Run Scan Build
Output:
src/shared/gatt-client.c:451:21: warning: Use of memory after it is freed
gatt_db_unregister(op->client->db, op->db_id);
^~~~~~~~~~
src/shared/gatt-client.c:696:2: warning: Use of memory after it is freed
discovery_op_complete(op, false, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:996:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1102:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1296:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1361:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1636:6: warning: Use of memory after it is freed
if (read_db_hash(op)) {
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1641:2: warning: Use of memory after it is freed
discover_all(op);
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2147:6: warning: Use of memory after it is freed
if (read_db_hash(op)) {
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2155:8: warning: Use of memory after it is freed
discovery_op_ref(op),
^~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3244:2: warning: Use of memory after it is freed
complete_write_long_op(req, success, 0, false);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3266:2: warning: Use of memory after it is freed
request_unref(req);
^~~~~~~~~~~~~~~~~~
12 warnings generated.
src/shared/bap.c:1502:8: warning: Use of memory after it is freed
bap = bt_bap_ref_safe(bap);
^~~~~~~~~~~~~~~~~~~~
src/shared/bap.c:2253:20: warning: Use of memory after it is freed
return queue_find(stream->bap->streams, NULL, stream);
^~~~~~~~~~~~~~~~~~~~
2 warnings generated.
src/shared/gatt-client.c:451:21: warning: Use of memory after it is freed
gatt_db_unregister(op->client->db, op->db_id);
^~~~~~~~~~
src/shared/gatt-client.c:696:2: warning: Use of memory after it is freed
discovery_op_complete(op, false, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:996:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1102:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1296:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1361:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1636:6: warning: Use of memory after it is freed
if (read_db_hash(op)) {
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1641:2: warning: Use of memory after it is freed
discover_all(op);
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2147:6: warning: Use of memory after it is freed
if (read_db_hash(op)) {
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2155:8: warning: Use of memory after it is freed
discovery_op_ref(op),
^~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3244:2: warning: Use of memory after it is freed
complete_write_long_op(req, success, 0, false);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3266:2: warning: Use of memory after it is freed
request_unref(req);
^~~~~~~~~~~~~~~~~~
12 warnings generated.
tools/hciattach.c:817:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 10)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:865:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 4)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:887:8: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 10)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:909:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 4)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:930:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 4)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/hciattach.c:974:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n'
if ((n = read_hci_event(fd, resp, 6)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
6 warnings generated.
src/shared/bap.c:1502:8: warning: Use of memory after it is freed
bap = bt_bap_ref_safe(bap);
^~~~~~~~~~~~~~~~~~~~
src/shared/bap.c:2253:20: warning: Use of memory after it is freed
return queue_find(stream->bap->streams, NULL, stream);
^~~~~~~~~~~~~~~~~~~~
2 warnings generated.
src/oui.c:50:2: warning: Value stored to 'hwdb' is never read
hwdb = udev_hwdb_unref(hwdb);
^ ~~~~~~~~~~~~~~~~~~~~~
src/oui.c:53:2: warning: Value stored to 'udev' is never read
udev = udev_unref(udev);
^ ~~~~~~~~~~~~~~~~
2 warnings generated.
tools/rfcomm.c:234:3: warning: Value stored to 'i' is never read
i = execvp(cmdargv[0], cmdargv);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/rfcomm.c:234:7: warning: Null pointer passed to 1st parameter expecting 'nonnull'
i = execvp(cmdargv[0], cmdargv);
^~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/rfcomm.c:354:8: warning: Although the value stored to 'fd' is used in the enclosing expression, the value is never actually read from 'fd'
if ((fd = open(devname, O_RDONLY | O_NOCTTY)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/rfcomm.c:497:14: warning: Assigned value is garbage or undefined
req.channel = raddr.rc_channel;
^ ~~~~~~~~~~~~~~~~
tools/rfcomm.c:515:8: warning: Although the value stored to 'fd' is used in the enclosing expression, the value is never actually read from 'fd'
if ((fd = open(devname, O_RDONLY | O_NOCTTY)) < 0) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5 warnings generated.
tools/hcidump.c:180:9: warning: Potential leak of memory pointed to by 'dp'
if (fds[i].fd == sock)
^~~
tools/hcidump.c:248:17: warning: Assigned value is garbage or undefined
dh->ts_sec = htobl(frm.ts.tv_sec);
^ ~~~~~~~~~~~~~~~~~~~~
tools/hcidump.c:326:9: warning: 1st function call argument is an uninitialized value
if (be32toh(dp.flags) & 0x02) {
^~~~~~~~~~~~~~~~~
/usr/include/endian.h:46:22: note: expanded from macro 'be32toh'
# define be32toh(x) __bswap_32 (x)
^~~~~~~~~~~~~~
tools/hcidump.c:341:20: warning: 1st function call argument is an uninitialized value
frm.data_len = be32toh(dp.len);
^~~~~~~~~~~~~~~
/usr/include/endian.h:46:22: note: expanded from macro 'be32toh'
# define be32toh(x) __bswap_32 (x)
^~~~~~~~~~~~~~
tools/hcidump.c:346:14: warning: 1st function call argument is an uninitialized value
opcode = be32toh(dp.flags) & 0xffff;
^~~~~~~~~~~~~~~~~
/usr/include/endian.h:46:22: note: expanded from macro 'be32toh'
# define be32toh(x) __bswap_32 (x)
^~~~~~~~~~~~~~
tools/hcidump.c:384:17: warning: Assigned value is garbage or undefined
frm.data_len = btohs(dh.len);
^ ~~~~~~~~~~~~~
tools/hcidump.c:394:11: warning: Assigned value is garbage or undefined
frm.len = frm.data_len;
^ ~~~~~~~~~~~~
tools/hcidump.c:398:9: warning: 1st function call argument is an uninitialized value
ts = be64toh(ph.ts);
^~~~~~~~~~~~~~
/usr/include/endian.h:51:22: note: expanded from macro 'be64toh'
# define be64toh(x) __bswap_64 (x)
^~~~~~~~~~~~~~
tools/hcidump.c:403:13: warning: 1st function call argument is an uninitialized value
frm.in = be32toh(dp.flags) & 0x01;
^~~~~~~~~~~~~~~~~
/usr/include/endian.h:46:22: note: expanded from macro 'be32toh'
# define be32toh(x) __bswap_32 (x)
^~~~~~~~~~~~~~
tools/hcidump.c:408:11: warning: Assigned value is garbage or undefined
frm.in = dh.in;
^ ~~~~~
tools/hcidump.c:437:7: warning: Null pointer passed to 1st parameter expecting 'nonnull'
fd = open(file, open_flags, 0644);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
11 warnings generated.
tools/ciptool.c:350:7: warning: 5th function call argument is an uninitialized value
sk = do_connect(ctl, dev_id, &src, &dst, psm, (1 << CMTP_LOOPBACK));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
src/sdp-xml.c:126:10: warning: Assigned value is garbage or undefined
buf[1] = data[i + 1];
^ ~~~~~~~~~~~
src/sdp-xml.c:300:11: warning: Assigned value is garbage or undefined
buf[1] = data[i + 1];
^ ~~~~~~~~~~~
src/sdp-xml.c:338:11: warning: Assigned value is garbage or undefined
buf[1] = data[i + 1];
^ ~~~~~~~~~~~
3 warnings generated.
tools/sdptool.c:941:26: warning: Result of 'malloc' is converted to a pointer of type 'uint32_t', which is incompatible with sizeof operand type 'int'
uint32_t *value_int = malloc(sizeof(int));
~~~~~~~~~~ ^~~~~~ ~~~~~~~~~~~
tools/sdptool.c:980:4: warning: 1st function call argument is an uninitialized value
free(allocArray[i]);
^~~~~~~~~~~~~~~~~~~
tools/sdptool.c:3777:2: warning: Potential leak of memory pointed to by 'si.name'
return add_service(0, &si);
^~~~~~~~~~~~~~~~~~~~~~~~~~
tools/sdptool.c:4112:4: warning: Potential leak of memory pointed to by 'context.svc'
return -1;
^~~~~~~~~
4 warnings generated.
tools/avtest.c:243:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:253:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 4);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:262:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:276:5: warning: Value stored to 'len' is never read
len = write(sk, buf,
^ ~~~~~~~~~~~~~~
tools/avtest.c:283:5: warning: Value stored to 'len' is never read
len = write(sk, buf,
^ ~~~~~~~~~~~~~~
tools/avtest.c:290:5: warning: Value stored to 'len' is never read
len = write(sk, buf,
^ ~~~~~~~~~~~~~~
tools/avtest.c:297:5: warning: Value stored to 'len' is never read
len = write(sk, buf,
^ ~~~~~~~~~~~~~~
tools/avtest.c:309:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 4);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:313:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:322:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:326:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:335:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:342:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:364:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 4);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:368:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:377:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:381:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:394:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 4);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:398:5: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:405:4: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:415:4: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:580:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:588:3: warning: Value stored to 'len' is never read
len = write(sk, buf, invalid ? 2 : 3);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/avtest.c:602:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 4 + media_transport_size);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/avtest.c:615:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:625:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:637:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:652:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:664:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:673:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 3);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:680:3: warning: Value stored to 'len' is never read
len = write(sk, buf, 2);
^ ~~~~~~~~~~~~~~~~~
tools/avtest.c:716:2: warning: Value stored to 'len' is never read
len = write(sk, buf, AVCTP_HEADER_LENGTH + sizeof(play_pressed));
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
32 warnings generated.
tools/btproxy.c:836:15: warning: Null pointer passed to 1st parameter expecting 'nonnull'
tcp_port = atoi(optarg);
^~~~~~~~~~~~
tools/btproxy.c:839:8: warning: Null pointer passed to 1st parameter expecting 'nonnull'
if (strlen(optarg) > 3 && !strncmp(optarg, "hci", 3))
^~~~~~~~~~~~~~
2 warnings generated.
tools/create-image.c:76:3: warning: Value stored to 'fd' is never read
fd = -1;
^ ~~
tools/create-image.c:84:3: warning: Value stored to 'fd' is never read
fd = -1;
^ ~~
tools/create-image.c:92:3: warning: Value stored to 'fd' is never read
fd = -1;
^ ~~
tools/create-image.c:105:2: warning: Value stored to 'fd' is never read
fd = -1;
^ ~~
4 warnings generated.
tools/check-selftest.c:42:3: warning: Value stored to 'ptr' is never read
ptr = fgets(result, sizeof(result), fp);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
tools/gatt-service.c:294:2: warning: 2nd function call argument is an uninitialized value
chr_write(chr, value, len);
^~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
tools/btgatt-client.c:1824:2: warning: Value stored to 'argv' is never read
argv += optind;
^ ~~~~~~
1 warning generated.
tools/btgatt-server.c:1212:2: warning: Value stored to 'argv' is never read
argv -= optind;
^ ~~~~~~
1 warning generated.
tools/obex-server-tool.c:133:13: warning: Null pointer passed to 1st parameter expecting 'nonnull'
data->fd = open(name, O_WRONLY | O_CREAT | O_NOCTTY, 0600);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tools/obex-server-tool.c:192:13: warning: Null pointer passed to 1st parameter expecting 'nonnull'
data->fd = open(name, O_RDONLY | O_NOCTTY, 0);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
tools/btpclientctl.c:402:3: warning: Value stored to 'bit' is never read
bit = 0;
^ ~
tools/btpclientctl.c:1655:2: warning: Null pointer passed to 2nd parameter expecting 'nonnull'
memcpy(cp->data, ad_data, ad_len);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
src/sdpd-request.c:211:13: warning: Result of 'malloc' is converted to a pointer of type 'char', which is incompatible with sizeof operand type 'uint16_t'
pElem = malloc(sizeof(uint16_t));
^~~~~~ ~~~~~~~~~~~~~~~~
src/sdpd-request.c:239:13: warning: Result of 'malloc' is converted to a pointer of type 'char', which is incompatible with sizeof operand type 'uint32_t'
pElem = malloc(sizeof(uint32_t));
^~~~~~ ~~~~~~~~~~~~~~~~
2 warnings generated.
android/avrcp-lib.c:1968:3: warning: 1st function call argument is an uninitialized value
g_free(text[i]);
^~~~~~~~~~~~~~~
1 warning generated.
profiles/audio/avdtp.c:893:25: warning: Use of memory after it is freed
session->prio_queue = g_slist_remove(session->prio_queue, req);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
profiles/audio/avdtp.c:900:24: warning: Use of memory after it is freed
session->req_queue = g_slist_remove(session->req_queue, req);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
profiles/audio/a2dp.c:375:8: warning: Use of memory after it is freed
if (!cb->resume_cb)
^~~~~~~~~~~~~
profiles/audio/a2dp.c:3269:20: warning: Access to field 'starting' results in a dereference of a null pointer (loaded from variable 'stream')
stream->starting = TRUE;
~~~~~~ ^
profiles/audio/a2dp.c:3272:8: warning: Access to field 'suspending' results in a dereference of a null pointer (loaded from variable 'stream')
if (!stream->suspending && stream->suspend_timer) {
^~~~~~~~~~~~~~~~~~
profiles/audio/a2dp.c:3332:22: warning: Access to field 'suspending' results in a dereference of a null pointer (loaded from variable 'stream')
stream->suspending = TRUE;
~~~~~~ ^
4 warnings generated.
profiles/health/hdp.c:644:3: warning: Use of memory after it is freed
hdp_tmp_dc_data_unref(dc_data);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
profiles/health/hdp.c:800:19: warning: Use of memory after it is freed
path = g_strdup(chan->path);
^~~~~~~~~~
profiles/health/hdp.c:1779:6: warning: Use of memory after it is freed
hdp_tmp_dc_data_ref(hdp_conn),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
profiles/health/hdp.c:1836:30: warning: Use of memory after it is freed
reply = g_dbus_create_error(data->msg, ERROR_INTERFACE ".HealthError",
^~~~~~~~~
4 warnings generated.
profiles/health/hdp_util.c:1052:2: warning: Use of memory after it is freed
conn_data->func(conn_data->data, gerr);
^~~~~~~~~~~~~~~
1 warning generated.
profiles/audio/avrcp.c:1961:2: warning: Value stored to 'operands' is never read
operands += sizeof(*pdu);
^ ~~~~~~~~~~~~
1 warning generated.
attrib/gatt.c:970:2: warning: Potential leak of memory pointed to by 'long_write'
return prepare_write(long_write);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
src/sdpd-request.c:211:13: warning: Result of 'malloc' is converted to a pointer of type 'char', which is incompatible with sizeof operand type 'uint16_t'
pElem = malloc(sizeof(uint16_t));
^~~~~~ ~~~~~~~~~~~~~~~~
src/sdpd-request.c:239:13: warning: Result of 'malloc' is converted to a pointer of type 'char', which is incompatible with sizeof operand type 'uint32_t'
pElem = malloc(sizeof(uint32_t));
^~~~~~ ~~~~~~~~~~~~~~~~
2 warnings generated.
src/sdp-client.c:353:14: warning: Access to field 'cb' results in a dereference of a null pointer
(*ctxt)->cb = cb;
~~~~~~~~~~~~^~~~
1 warning generated.
src/gatt-database.c:1173:10: warning: Value stored to 'bits' during its initialization is never read
uint8_t bits[] = { BT_GATT_CHRC_CLI_FEAT_ROBUST_CACHING,
^~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
src/sdp-xml.c:126:10: warning: Assigned value is garbage or undefined
buf[1] = data[i + 1];
^ ~~~~~~~~~~~
src/sdp-xml.c:300:11: warning: Assigned value is garbage or undefined
buf[1] = data[i + 1];
^ ~~~~~~~~~~~
src/sdp-xml.c:338:11: warning: Assigned value is garbage or undefined
buf[1] = data[i + 1];
^ ~~~~~~~~~~~
3 warnings generated.
src/device.c: In function ‘emit_disconnect_reason’:
src/device.c:3764:7: error: ‘MGMT_DEV_DISCONN_AUTH_FAILURE’ undeclared (first use in this function); did you mean ‘MGMT_DEV_DISCONN_TIMEOUT’?
3764 | case MGMT_DEV_DISCONN_AUTH_FAILURE:
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| MGMT_DEV_DISCONN_TIMEOUT
src/device.c:3764:7: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [Makefile:11163: src/bluetoothd-device.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4691: all] Error 2
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: Propagate disconnection reason
2025-05-23 7:26 [PATCH BlueZ v4 1/4] lib/mgmt: Add MGMT_DEV_DISCONN_AUTH_FAILURE define Frédéric Danis
@ 2025-05-23 8:46 ` bluez.test.bot
0 siblings, 0 replies; 13+ messages in thread
From: bluez.test.bot @ 2025-05-23 8:46 UTC (permalink / raw)
To: linux-bluetooth, frederic.danis
[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=965695
---Test result---
Test Summary:
CheckPatch PENDING 0.39 seconds
GitLint PENDING 0.31 seconds
BuildEll PASS 20.53 seconds
BluezMake PASS 2611.25 seconds
MakeCheck PASS 20.20 seconds
MakeDistcheck PASS 201.22 seconds
CheckValgrind PASS 277.99 seconds
CheckSmatch PASS 305.14 seconds
bluezmakeextell PASS 130.37 seconds
IncrementalBuild PENDING 0.30 seconds
ScanBuild PASS 927.61 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2025-05-23 8:46 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-19 16:14 [PATCH BlueZ 0/3] Propagate disconnection reason Frédéric Danis
2025-05-19 16:14 ` [PATCH BlueZ 1/3] src/device: Add Disconnected signal to propagate " Frédéric Danis
2025-05-19 17:56 ` Propagate " bluez.test.bot
2025-05-19 16:14 ` [PATCH BlueZ 2/3] doc/device: Add Disconnected signal Frédéric Danis
2025-05-19 16:44 ` Luiz Augusto von Dentz
2025-05-19 19:22 ` Bastien Nocera
2025-05-20 9:32 ` Frédéric Danis
2025-05-20 10:22 ` Bastien Nocera
2025-05-20 9:26 ` Frédéric Danis
2025-05-19 16:14 ` [PATCH BlueZ 3/3] client: Display disconnection reason Frédéric Danis
-- strict thread matches above, loose matches on Subject: below --
2025-05-20 16:26 [PATCH BlueZ v2 1/3] src/device: Add Disconnected signal to propagate " Frédéric Danis
2025-05-20 17:58 ` Propagate " bluez.test.bot
2025-05-22 15:49 [PATCH BlueZ v3 1/3] src/device: Add Disconnected signal to propagate " Frédéric Danis
2025-05-22 17:01 ` Propagate " bluez.test.bot
2025-05-23 7:26 [PATCH BlueZ v4 1/4] lib/mgmt: Add MGMT_DEV_DISCONN_AUTH_FAILURE define Frédéric Danis
2025-05-23 8:46 ` Propagate disconnection reason bluez.test.bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.