From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: dts: BCM5301X: Make usb3 phy use mdio phy driver
Date: Wed, 18 Apr 2018 15:31:17 -0700 [thread overview]
Message-ID: <68519de5-9a47-9cb5-064c-dc4703aaa508@gmail.com> (raw)
In-Reply-To: <20180409223153.41893-1-npcomplete13@gmail.com>
On 04/09/2018 03:31 PM, Vivek Unune wrote:
> Currently, usb3 phy in bcm5301x.dtsi uses platform driver which
> requires register range "ccb-mii" <0x18003000 0x1000>. This range
> overlaps with mdio cmd and param registers (<0x18003000 0x8>).
> Essentially, the platform driver partly acts like a mdio bus
> driver, hence to use of this register range.
>
> In some Northstar devices like Linksys EA9500, secondary switch
> is connected via external mdio. The only way to access and
> configure the external switch is via mdio bus. When we enable the
> mdio bus in it's current state, the mdio bus and any child buses
> fail to register because of the register range overlap.
>
> On Northstar, the usb3 phy is connected at address 0x10 on the
> internal mdio bus. This change moves the usb3_phy node and makes
> it a child node of internal mdio bus.
>
> Thanks to Rafa? Mi?ecki's commit af850e14a7ae
> ("phy: bcm-ns-usb3: add MDIO driver using proper bus layer") the
> same usb3 platform driver can now act as usb3 phy mdio driver.
>
> Tested on Linksys Panamera (EA9500)
>
> Signed-off-by: Vivek Unune <npcomplete13@gmail.com>
> ---
> v2: Disabled usb3_phy by default, then enabled in dts where
> necessary
Rafal, Hauke, this looks good to me, can you review? Thanks
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Vivek Unune <npcomplete13@gmail.com>,
hauke@hauke-m.de, zajec5@gmail.com, jonmason@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, robh+dt@kernel.org,
mark.rutland@arm.com, linux@armlinux.org.uk
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: dts: BCM5301X: Make usb3 phy use mdio phy driver
Date: Wed, 18 Apr 2018 15:31:17 -0700 [thread overview]
Message-ID: <68519de5-9a47-9cb5-064c-dc4703aaa508@gmail.com> (raw)
In-Reply-To: <20180409223153.41893-1-npcomplete13@gmail.com>
On 04/09/2018 03:31 PM, Vivek Unune wrote:
> Currently, usb3 phy in bcm5301x.dtsi uses platform driver which
> requires register range "ccb-mii" <0x18003000 0x1000>. This range
> overlaps with mdio cmd and param registers (<0x18003000 0x8>).
> Essentially, the platform driver partly acts like a mdio bus
> driver, hence to use of this register range.
>
> In some Northstar devices like Linksys EA9500, secondary switch
> is connected via external mdio. The only way to access and
> configure the external switch is via mdio bus. When we enable the
> mdio bus in it's current state, the mdio bus and any child buses
> fail to register because of the register range overlap.
>
> On Northstar, the usb3 phy is connected at address 0x10 on the
> internal mdio bus. This change moves the usb3_phy node and makes
> it a child node of internal mdio bus.
>
> Thanks to Rafał Miłecki's commit af850e14a7ae
> ("phy: bcm-ns-usb3: add MDIO driver using proper bus layer") the
> same usb3 platform driver can now act as usb3 phy mdio driver.
>
> Tested on Linksys Panamera (EA9500)
>
> Signed-off-by: Vivek Unune <npcomplete13@gmail.com>
> ---
> v2: Disabled usb3_phy by default, then enabled in dts where
> necessary
Rafal, Hauke, this looks good to me, can you review? Thanks
--
Florian
next prev parent reply other threads:[~2018-04-18 22:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 13:56 [PATCH] ARM: dts: BCM5301X:Make usb3 phy use mdio phy driver Vivek Unune
2018-03-15 13:56 ` Vivek Unune
2018-04-09 22:31 ` [PATCH v2] ARM: dts: BCM5301X: Make " Vivek Unune
2018-04-09 22:31 ` Vivek Unune
2018-04-18 22:31 ` Florian Fainelli [this message]
2018-04-18 22:31 ` Florian Fainelli
2018-05-09 12:08 ` Vivek Unune
2018-05-09 12:08 ` Vivek Unune
2018-06-12 18:49 ` Florian Fainelli
2018-06-12 18:49 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68519de5-9a47-9cb5-064c-dc4703aaa508@gmail.com \
--to=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.