All of lore.kernel.org
 help / color / mirror / Atom feed
* [syzbot] [wireless?] WARNING in _ieee80211_sta_cur_vht_bw
@ 2025-06-26  5:52 syzbot
  2025-06-26 12:57 ` syzbot
  2025-07-01 18:16 ` [syzbot] " syzbot
  0 siblings, 2 replies; 6+ messages in thread
From: syzbot @ 2025-06-26  5:52 UTC (permalink / raw)
  To: johannes, linux-kernel, linux-wireless, netdev, syzkaller-bugs

Hello,

syzbot found the following issue on:

HEAD commit:    010c40c1f50e Merge tag 'wireless-2025-06-25' of https://gi..
git tree:       net
console output: https://syzkaller.appspot.com/x/log.txt?x=10825b70580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=d11f52d3049c3790
dashboard link: https://syzkaller.appspot.com/bug?extid=ededba317ddeca8b3f08
compiler:       Debian clang version 20.1.6 (++20250514063057+1e4d39e07757-1~exp1~20250514183223.118), Debian LLD 20.1.6

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/eb94516e5d57/disk-010c40c1.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/86a8a81b1a19/vmlinux-010c40c1.xz
kernel image: https://storage.googleapis.com/syzbot-assets/05406e73c0a2/bzImage-010c40c1.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+ededba317ddeca8b3f08@syzkaller.appspotmail.com

------------[ cut here ]------------
WARNING: CPU: 0 PID: 11521 at ./include/net/mac80211.h:7748 ieee80211_chan_width_to_rx_bw include/net/mac80211.h:7748 [inline]
WARNING: CPU: 0 PID: 11521 at ./include/net/mac80211.h:7748 _ieee80211_sta_cur_vht_bw+0x524/0x6e0 net/mac80211/vht.c:549
Modules linked in:
CPU: 0 UID: 0 PID: 11521 Comm: syz.0.1373 Not tainted 6.16.0-rc2-syzkaller-00185-g010c40c1f50e #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
RIP: 0010:ieee80211_chan_width_to_rx_bw include/net/mac80211.h:7748 [inline]
RIP: 0010:_ieee80211_sta_cur_vht_bw+0x524/0x6e0 net/mac80211/vht.c:549
Code: 00 00 00 eb 49 41 83 fd 05 74 30 41 83 fd 0d 75 13 e8 80 ac e5 f6 b8 04 00 00 00 eb 31 e8 74 ac e5 f6 eb 28 e8 6d ac e5 f6 90 <0f> 0b 90 eb 1d e8 62 ac e5 f6 b8 02 00 00 00 eb 13 e8 56 ac e5 f6
RSP: 0018:ffffc90003936f48 EFLAGS: 00010283
RAX: ffffffff8adaafe3 RBX: ffff8880580dc000 RCX: 0000000000080000
RDX: ffffc900049a2000 RSI: 00000000000003aa RDI: 00000000000003ab
RBP: 0000000000000000 R08: ffff888027683c00 R09: 0000000000000007
R10: 000000000000000d R11: 0000000000000002 R12: 0000000000000000
R13: 0000000000000007 R14: ffff8880580dc180 R15: 1ffff1100b01b830
FS:  00007f6ba57f66c0(0000) GS:ffff888125c51000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00002000000045c0 CR3: 0000000031c9c000 CR4: 00000000003526f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 ieee80211_sta_cur_vht_bw net/mac80211/ieee80211_i.h:2229 [inline]
 __ieee80211_vht_handle_opmode+0x3c0/0x850 net/mac80211/vht.c:701
 sta_link_apply_parameters+0xbb8/0xec0 net/mac80211/cfg.c:1965
 sta_apply_parameters+0x944/0x15b0 net/mac80211/cfg.c:2089
 ieee80211_add_station+0x424/0x6a0 net/mac80211/cfg.c:2172
 rdev_add_station+0x105/0x290 net/wireless/rdev-ops.h:201
 nl80211_new_station+0x1723/0x1b40 net/wireless/nl80211.c:7843
 genl_family_rcv_msg_doit+0x212/0x300 net/netlink/genetlink.c:1115
 genl_family_rcv_msg net/netlink/genetlink.c:1195 [inline]
 genl_rcv_msg+0x60e/0x790 net/netlink/genetlink.c:1210
 netlink_rcv_skb+0x205/0x470 net/netlink/af_netlink.c:2534
 genl_rcv+0x28/0x40 net/netlink/genetlink.c:1219
 netlink_unicast_kernel net/netlink/af_netlink.c:1313 [inline]
 netlink_unicast+0x758/0x8d0 net/netlink/af_netlink.c:1339
 netlink_sendmsg+0x805/0xb30 net/netlink/af_netlink.c:1883
 sock_sendmsg_nosec net/socket.c:712 [inline]
 __sock_sendmsg+0x219/0x270 net/socket.c:727
 ____sys_sendmsg+0x505/0x830 net/socket.c:2566
 ___sys_sendmsg+0x21f/0x2a0 net/socket.c:2620
 __sys_sendmsg net/socket.c:2652 [inline]
 __do_sys_sendmsg net/socket.c:2657 [inline]
 __se_sys_sendmsg net/socket.c:2655 [inline]
 __x64_sys_sendmsg+0x19b/0x260 net/socket.c:2655
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f6ba798e929
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f6ba57f6038 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007f6ba7bb5fa0 RCX: 00007f6ba798e929
RDX: 0000000000000000 RSI: 0000200000001080 RDI: 0000000000000005
RBP: 00007f6ba7a10b39 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f6ba7bb5fa0 R15: 00007ffc309021b8
 </TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

^ permalink raw reply	[flat|nested] 6+ messages in thread
[parent not found: <CAF3JpA5AaoPXnQ81PYoEP89kGbKype5Fcew8JWSds4xbz40s+g@mail.gmail.com>]
* WARNING in _ieee80211_sta_cur_vht_bw
@ 2025-07-01 19:49 Moonhee Lee
  2025-07-01 20:34 ` [syzbot] [wireless?] " syzbot
  0 siblings, 1 reply; 6+ messages in thread
From: Moonhee Lee @ 2025-07-01 19:49 UTC (permalink / raw)
  To: syzbot+ededba317ddeca8b3f08; +Cc: linux-kernel, syzkaller-bugs

[-- Attachment #1: Type: text/plain, Size: 10 bytes --]

#syz test

[-- Attachment #2: 0001-mac80211-reject-opmode-notification-for-unsupported-.patch --]
[-- Type: text/x-patch, Size: 1619 bytes --]

From 6780f4872d60415bbf262bc84fab1ad80991d1e4 Mon Sep 17 00:00:00 2001
From: Moon Hee Lee <moonhee.lee.ca@gmail.com>
Date: Tue, 1 Jul 2025 12:36:48 -0700
Subject: [PATCH] mac80211: reject opmode notification for unsupported channel
 widths

VHT operating mode notification should not be applied when the channel
width is 5 MHz or 10 MHz, as VHT does not support those widths.

Without this check, a malformed opmode notification with 10 MHz width
can reach ieee80211_chan_width_to_rx_bw(), triggering a WARN_ON due to
invalid channel width. This issue was reported by syzbot.

Reject unsupported channel widths early in sta_link_apply_parameters()
when opmode notification is used.

Signed-off-by: Moon Hee Lee <moonhee.lee.ca@gmail.com>
---
 net/mac80211/cfg.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
index 56540c3701ed..5a6ae093a8bd 100644
--- a/net/mac80211/cfg.c
+++ b/net/mac80211/cfg.c
@@ -1981,6 +1981,21 @@ static int sta_link_apply_parameters(struct ieee80211_local *local,
 	ieee80211_sta_init_nss(link_sta);
 
 	if (params->opmode_notif_used) {
+		enum nl80211_chan_width width = link->conf->chanreq.oper.width;
+
+		switch (width) {
+		case NL80211_CHAN_WIDTH_20_NOHT:
+		case NL80211_CHAN_WIDTH_20:
+		case NL80211_CHAN_WIDTH_40:
+		case NL80211_CHAN_WIDTH_80:
+		case NL80211_CHAN_WIDTH_160:
+		case NL80211_CHAN_WIDTH_80P80:
+		case NL80211_CHAN_WIDTH_320:
+			break;
+		default:
+			return -EINVAL;
+		}
+
 		/* returned value is only needed for rc update, but the
 		 * rc isn't initialized here yet, so ignore it
 		 */
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] wifi: mac80211: reject opmode notification for unsupported channel widths
@ 2025-07-01 21:11 Moon Hee Lee
  2025-07-01 21:43 ` [syzbot] [wireless?] WARNING in _ieee80211_sta_cur_vht_bw syzbot
  0 siblings, 1 reply; 6+ messages in thread
From: Moon Hee Lee @ 2025-07-01 21:11 UTC (permalink / raw)
  To: syzbot+ededba317ddeca8b3f08, syzkaller-bugs, linux-kernel; +Cc: moonhee.lee.ca

#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless.git main

---
 net/mac80211/cfg.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
index d9d88f2f2831..f2e96eb07e8f 100644
--- a/net/mac80211/cfg.c
+++ b/net/mac80211/cfg.c
@@ -1959,6 +1959,21 @@ static int sta_link_apply_parameters(struct ieee80211_local *local,
 	ieee80211_sta_init_nss(link_sta);
 
 	if (params->opmode_notif_used) {
+		enum nl80211_chan_width width = link->conf->chanreq.oper.width;
+
+		switch (width) {
+		case NL80211_CHAN_WIDTH_20_NOHT:
+		case NL80211_CHAN_WIDTH_20:
+		case NL80211_CHAN_WIDTH_40:
+		case NL80211_CHAN_WIDTH_80:
+		case NL80211_CHAN_WIDTH_160:
+		case NL80211_CHAN_WIDTH_80P80:
+		case NL80211_CHAN_WIDTH_320:
+			break;
+		default:
+			return -EINVAL;
+		}
+
 		/* returned value is only needed for rc update, but the
 		 * rc isn't initialized here yet, so ignore it
 		 */
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-07-01 21:43 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-26  5:52 [syzbot] [wireless?] WARNING in _ieee80211_sta_cur_vht_bw syzbot
2025-06-26 12:57 ` syzbot
2025-07-01 18:16 ` [syzbot] " syzbot
     [not found] <CAF3JpA5AaoPXnQ81PYoEP89kGbKype5Fcew8JWSds4xbz40s+g@mail.gmail.com>
2025-07-01 19:04 ` [syzbot] [wireless?] " syzbot
  -- strict thread matches above, loose matches on Subject: below --
2025-07-01 19:49 Moonhee Lee
2025-07-01 20:34 ` [syzbot] [wireless?] " syzbot
2025-07-01 21:11 [PATCH] wifi: mac80211: reject opmode notification for unsupported channel widths Moon Hee Lee
2025-07-01 21:43 ` [syzbot] [wireless?] WARNING in _ieee80211_sta_cur_vht_bw syzbot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.