[PATCH BlueZ] avdtp: fix not adding stream to global streams list

[PATCH BlueZ] avdtp: fix not adding stream to global streams list

[Pauli Virtanen]

stream_new() shall be used to create new avdtp_stream, so that they can
be found from global list.

Fix one case where it was not used.  Fixes crash when unregistering lsep
and then disconnecting, due to stream for the removed lsep not being
cleaned up when SEP is freed.

Fixes: https://github.com/bluez/bluez/issues/1325
---
 profiles/audio/avdtp.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
index 17671a1ba..b849896a9 100644
--- a/profiles/audio/avdtp.c
+++ b/profiles/audio/avdtp.c
@@ -3575,10 +3575,7 @@ int avdtp_set_configuration(struct avdtp *session,
 	DBG("%p: int_seid=%u, acp_seid=%u", session,
 			lsep->info.seid, rsep->seid);
 
-	new_stream = g_new0(struct avdtp_stream, 1);
-	new_stream->session = session;
-	new_stream->lsep = lsep;
-	new_stream->rseid = rsep->seid;
+	new_stream = stream_new(session, lsep, rsep->seid);
 
 	if (rsep->delay_reporting && lsep->delay_reporting) {
 		struct avdtp_service_capability *delay_reporting;
-- 
2.50.0

RE: [BlueZ] avdtp: fix not adding stream to global streams list

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=980952

---Test result---

Test Summary:
CheckPatch                    PENDING   0.27 seconds
GitLint                       PENDING   0.24 seconds
BuildEll                      PASS      20.05 seconds
BluezMake                     PASS      2606.23 seconds
MakeCheck                     PASS      19.77 seconds
MakeDistcheck                 PASS      185.48 seconds
CheckValgrind                 PASS      234.51 seconds
CheckSmatch                   PASS      304.25 seconds
bluezmakeextell               PASS      127.46 seconds
IncrementalBuild              PENDING   0.25 seconds
ScanBuild                     PASS      906.75 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ] avdtp: fix not adding stream to global streams list

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 10 Jul 2025 13:08:54 +0300 you wrote:
> stream_new() shall be used to create new avdtp_stream, so that they can
> be found from global list.
> 
> Fix one case where it was not used.  Fixes crash when unregistering lsep
> and then disconnecting, due to stream for the removed lsep not being
> cleaned up when SEP is freed.
> 
> [...]

Here is the summary with links:
  - [BlueZ] avdtp: fix not adding stream to global streams list
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=47a4c73cd553

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html