[PATCH] shared/asha: Do not start ASHA in case of CoC connection failure

[PATCH] shared/asha: Do not start ASHA in case of CoC connection failure

[Arkadiusz Bokowy]

---
 profiles/audio/asha.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/profiles/audio/asha.c b/profiles/audio/asha.c
index 9bd57d780..a17b877d9 100644
--- a/profiles/audio/asha.c
+++ b/profiles/audio/asha.c
@@ -89,6 +89,11 @@ static void connect_cb(GIOChannel *io, GError *err, gpointer user_data)
 	struct bt_asha_device *asha_dev = conn_data->asha_dev;
 	GError *gerr = NULL;
 
+	if (err) {
+		error("%s", err->message);
+		return;
+	}
+
 	if (!bt_io_get(io, &gerr,
 				BT_IO_OPT_IMTU, &asha_dev->imtu,
 				BT_IO_OPT_OMTU, &asha_dev->omtu,
@@ -96,7 +101,7 @@ static void connect_cb(GIOChannel *io, GError *err, gpointer user_data)
 		/* Let this be non-fatal? */
 		asha_dev->omtu = ASHA_MIN_MTU;
 		asha_dev->imtu = ASHA_CONNECTION_MTU;
-		error("Could not get L2CAP CoC socket MTU: %s", err->message);
+		error("Could not get L2CAP CoC socket MTU: %s", gerr->message);
 		g_error_free(gerr);
 	}
 
@@ -362,7 +367,7 @@ static void asha_source_device_remove(struct btd_service *service)
 	asha_dev = btd_service_get_user_data(service);
 	if (!asha_dev) {
 		/* Can this actually happen? */
-		DBG("Not handlihng ASHA profile");
+		DBG("Not handling ASHA profile");
 		return;
 	}
 
@@ -479,7 +484,7 @@ static int asha_source_disconnect(struct btd_service *service)
 
 	if (!asha_dev) {
 		/* Can this actually happen? */
-		DBG("Not handlihng ASHA profile");
+		DBG("Not handling ASHA profile");
 		return -1;
 	}
 
-- 
2.43.0

RE: shared/asha: Do not start ASHA in case of CoC connection failure

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=987426

---Test result---

Test Summary:
CheckPatch                    PENDING   0.25 seconds
GitLint                       PENDING   0.23 seconds
BuildEll                      PASS      20.40 seconds
BluezMake                     PASS      2654.49 seconds
MakeCheck                     PASS      20.23 seconds
MakeDistcheck                 PASS      183.82 seconds
CheckValgrind                 PASS      235.17 seconds
CheckSmatch                   PASS      304.54 seconds
bluezmakeextell               PASS      127.81 seconds
IncrementalBuild              PENDING   0.27 seconds
ScanBuild                     PASS      910.46 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH] shared/asha: Do not start ASHA in case of CoC connection failure

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 31 Jul 2025 18:26:05 +0200 you wrote:
> ---
>  profiles/audio/asha.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)

Here is the summary with links:
  - shared/asha: Do not start ASHA in case of CoC connection failure
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=af816afa7ed1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html