* [igt-dev] [PATCH i-g-t] tests/kms_cdclk: Minor fix
@ 2021-07-06 21:27 Swati Sharma
2021-07-06 21:45 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Swati Sharma @ 2021-07-06 21:27 UTC (permalink / raw)
To: igt-dev
Driver still works in a such way that we never reduce CDCLK, but always
only increase it. That was done in order to avoid continuous CDCLK switching,
So, in case if new CDCLK is 307200 and there is no change in CDCLK beacuse
of above stated driver optimization; pass the test else check lt condition.
Cc: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
tests/kms_cdclk.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/kms_cdclk.c b/tests/kms_cdclk.c
index d2a9fa5f..818cbfd5 100644
--- a/tests/kms_cdclk.c
+++ b/tests/kms_cdclk.c
@@ -31,6 +31,7 @@ IGT_TEST_DESCRIPTION("Test cdclk features : crawling");
#define HDISPLAY_4K 3840
#define VDISPLAY_4K 2160
#define VREFRESH 60
+#define MAX_CDCLK_4K 307200
/* Test flags */
enum {
@@ -228,7 +229,8 @@ static void test_mode_transition(data_t *data, enum pipe pipe, igt_output_t *out
igt_info("CD clock frequency %d -> %d\n", cdclk_ref, cdclk_new);
/* cdclk should bump */
- igt_assert_lt(cdclk_ref, cdclk_new);
+ if (cdclk_new != MAX_CDCLK_4K)
+ igt_assert_lt(cdclk_ref, cdclk_new);
/* cleanup */
do_cleanup_display(display);
--
2.25.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread* [igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_cdclk: Minor fix 2021-07-06 21:27 [igt-dev] [PATCH i-g-t] tests/kms_cdclk: Minor fix Swati Sharma @ 2021-07-06 21:45 ` Patchwork 2021-07-06 22:06 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork 2021-07-07 5:04 ` [igt-dev] [PATCH i-g-t] " Shankar, Uma 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2021-07-06 21:45 UTC (permalink / raw) To: Swati Sharma; +Cc: igt-dev == Series Details == Series: tests/kms_cdclk: Minor fix URL : https://patchwork.freedesktop.org/series/92252/ State : warning == Summary == Pipeline status: FAILED. see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/354479 for the overview. containers:igt has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/11565350): STEP 4: ENV PATH="/opt/igt/bin:${PATH}" ac47bd03fd79eb904987f55182951446b94a04962351f227af0abac8b441fd34 STEP 5: ENV LD_LIBRARY_PATH="/opt/igt/lib:/opt/igt/lib64:${LD_LIBRARY_PATH}" 424cd0580fe7e7dc774230ce84d08ace5d1b063598e9f67d1f7c16b65c39060f STEP 6: ENV IGT_TEST_ROOT="/opt/igt/libexec/igt-gpu-tools" d3065d0796781a186ea3b1332b46e12356a08e20b6d4a83577ef12988d073d38 STEP 7: CMD docker-help.sh STEP 8: COMMIT registry.freedesktop.org/gfx-ci/igt-ci-tags/igt:commit-575bb72aab640364e06c9b438fde1353e7313c10 d61b7a2fa3b38758e61decbe787d3a863af4112235eb0b4ad2326457bb8ddc5f Getting image source signatures Copying blob sha256:b8ff56153000c463ead35feae95e14444f4ed4ee51c863125550d0e500e91c18 Copying blob sha256:17d8edeb87407da3fdf866ff431f19edd723a72d6f478c66be76e70dd620b8dd Copying blob sha256:3504a8337d3b7eaabfd338d6a971d02441d28ebef8bd81f730d87f936ed58079 Error: Error copying image to the remote destination: Error writing blob: Error determining upload URL: http: no Location header in response section_end:1625607754:step_script section_start:1625607754:cleanup_file_variables Cleaning up file based variables section_end:1625607755:cleanup_file_variables ERROR: Job failed: exit code 1 == Logs == For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/354479 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_cdclk: Minor fix 2021-07-06 21:27 [igt-dev] [PATCH i-g-t] tests/kms_cdclk: Minor fix Swati Sharma 2021-07-06 21:45 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork @ 2021-07-06 22:06 ` Patchwork 2021-07-07 5:04 ` [igt-dev] [PATCH i-g-t] " Shankar, Uma 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2021-07-06 22:06 UTC (permalink / raw) To: Swati Sharma; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 3373 bytes --] == Series Details == Series: tests/kms_cdclk: Minor fix URL : https://patchwork.freedesktop.org/series/92252/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10307 -> IGTPW_5986 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with IGTPW_5986 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_5986, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5986/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_5986: ### IGT changes ### #### Possible regressions #### * igt@vgem_basic@unload: - fi-bwr-2160: NOTRUN -> [INCOMPLETE][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5986/fi-bwr-2160/igt@vgem_basic@unload.html Known issues ------------ Here are the changes found in IGTPW_5986 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s0: - fi-cfl-8109u: [PASS][2] -> [INCOMPLETE][3] ([i915#155]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10307/fi-cfl-8109u/igt@gem_exec_suspend@basic-s0.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5986/fi-cfl-8109u/igt@gem_exec_suspend@basic-s0.html * igt@kms_chamelium@dp-crc-fast: - fi-kbl-7500u: [PASS][4] -> [FAIL][5] ([i915#1372]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10307/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5986/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html #### Possible fixes #### * igt@core_hotunplug@unbind-rebind: - fi-bwr-2160: [{ABORT}][6] -> [PASS][7] [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10307/fi-bwr-2160/igt@core_hotunplug@unbind-rebind.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5986/fi-bwr-2160/igt@core_hotunplug@unbind-rebind.html #### Warnings #### * igt@runner@aborted: - fi-bwr-2160: [FAIL][8] ([i915#2505]) -> [FAIL][9] ([i915#2505] / [i915#2722]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10307/fi-bwr-2160/igt@runner@aborted.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5986/fi-bwr-2160/igt@runner@aborted.html [i915#1372]: https://gitlab.freedesktop.org/drm/intel/issues/1372 [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155 [i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505 [i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722 Participating hosts (38 -> 36) ------------------------------ Missing (2): fi-bsw-cyan fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_6129 -> IGTPW_5986 CI-20190529: 20190529 CI_DRM_10307: 5f62539f797eecbee492eb05bf574b3ea02ad9ff @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_5986: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5986/index.html IGT_6129: 687589e76f787d26ee2b539e551a9be06bd41ce3 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5986/index.html [-- Attachment #1.2: Type: text/html, Size: 4153 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_cdclk: Minor fix 2021-07-06 21:27 [igt-dev] [PATCH i-g-t] tests/kms_cdclk: Minor fix Swati Sharma 2021-07-06 21:45 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork 2021-07-06 22:06 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork @ 2021-07-07 5:04 ` Shankar, Uma 2021-07-07 5:08 ` Shankar, Uma 2 siblings, 1 reply; 5+ messages in thread From: Shankar, Uma @ 2021-07-07 5:04 UTC (permalink / raw) To: Sharma, Swati2, igt-dev@lists.freedesktop.org > -----Original Message----- > From: Sharma, Swati2 <swati2.sharma@intel.com> > Sent: Wednesday, July 7, 2021 2:58 AM > To: igt-dev@lists.freedesktop.org > Cc: Sharma, Swati2 <swati2.sharma@intel.com>; Shankar, Uma > <uma.shankar@intel.com> > Subject: [igt-dev][PATCH i-g-t] tests/kms_cdclk: Minor fix > > Driver still works in a such way that we never reduce CDCLK, but always only > increase it. That was done in order to avoid continuous CDCLK switching, > > So, in case if new CDCLK is 307200 and there is no change in CDCLK beacuse of > above stated driver optimization; pass the test else check lt condition. As discussed on offline chats, enhance this test to lower modes for all connectors in order to lower cd clock and get a proper DVFS behavior, along with the above mentioned kernel change. But for now, this change helps avoid getting false failure reports, so: Reviewed-by: Uma Shankar <uma.shakar@intel.com> > > Cc: Uma Shankar <uma.shankar@intel.com> > Signed-off-by: Swati Sharma <swati2.sharma@intel.com> > --- > tests/kms_cdclk.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/kms_cdclk.c b/tests/kms_cdclk.c index d2a9fa5f..818cbfd5 100644 > --- a/tests/kms_cdclk.c > +++ b/tests/kms_cdclk.c > @@ -31,6 +31,7 @@ IGT_TEST_DESCRIPTION("Test cdclk features : crawling"); > #define HDISPLAY_4K 3840 > #define VDISPLAY_4K 2160 > #define VREFRESH 60 > +#define MAX_CDCLK_4K 307200 > > /* Test flags */ > enum { > @@ -228,7 +229,8 @@ static void test_mode_transition(data_t *data, enum pipe > pipe, igt_output_t *out > igt_info("CD clock frequency %d -> %d\n", cdclk_ref, cdclk_new); > > /* cdclk should bump */ > - igt_assert_lt(cdclk_ref, cdclk_new); > + if (cdclk_new != MAX_CDCLK_4K) > + igt_assert_lt(cdclk_ref, cdclk_new); > > /* cleanup */ > do_cleanup_display(display); > -- > 2.25.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_cdclk: Minor fix 2021-07-07 5:04 ` [igt-dev] [PATCH i-g-t] " Shankar, Uma @ 2021-07-07 5:08 ` Shankar, Uma 0 siblings, 0 replies; 5+ messages in thread From: Shankar, Uma @ 2021-07-07 5:08 UTC (permalink / raw) To: Sharma, Swati2, igt-dev@lists.freedesktop.org > > -----Original Message----- > > From: Sharma, Swati2 <swati2.sharma@intel.com> > > Sent: Wednesday, July 7, 2021 2:58 AM > > To: igt-dev@lists.freedesktop.org > > Cc: Sharma, Swati2 <swati2.sharma@intel.com>; Shankar, Uma > > <uma.shankar@intel.com> > > Subject: [igt-dev][PATCH i-g-t] tests/kms_cdclk: Minor fix Missed to call out earlier, Please rename the patch header with what is the minor fix. Something like: "Fix cdclock failure condition" or something similar. > > Driver still works in a such way that we never reduce CDCLK, but > > always only increase it. That was done in order to avoid continuous > > CDCLK switching, > > > > So, in case if new CDCLK is 307200 and there is no change in CDCLK > > beacuse of above stated driver optimization; pass the test else check lt condition. > > As discussed on offline chats, enhance this test to lower modes for all connectors in > order to lower cd clock and get a proper DVFS behavior, along with the above > mentioned kernel change. > > But for now, this change helps avoid getting false failure reports, so: > Reviewed-by: Uma Shankar <uma.shakar@intel.com> > > > > > Cc: Uma Shankar <uma.shankar@intel.com> > > Signed-off-by: Swati Sharma <swati2.sharma@intel.com> > > --- > > tests/kms_cdclk.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/tests/kms_cdclk.c b/tests/kms_cdclk.c index > > d2a9fa5f..818cbfd5 100644 > > --- a/tests/kms_cdclk.c > > +++ b/tests/kms_cdclk.c > > @@ -31,6 +31,7 @@ IGT_TEST_DESCRIPTION("Test cdclk features : crawling"); > > #define HDISPLAY_4K 3840 > > #define VDISPLAY_4K 2160 > > #define VREFRESH 60 > > +#define MAX_CDCLK_4K 307200 > > > > /* Test flags */ > > enum { > > @@ -228,7 +229,8 @@ static void test_mode_transition(data_t *data, > > enum pipe pipe, igt_output_t *out > > igt_info("CD clock frequency %d -> %d\n", cdclk_ref, cdclk_new); > > > > /* cdclk should bump */ > > - igt_assert_lt(cdclk_ref, cdclk_new); > > + if (cdclk_new != MAX_CDCLK_4K) > > + igt_assert_lt(cdclk_ref, cdclk_new); > > > > /* cleanup */ > > do_cleanup_display(display); > > -- > > 2.25.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-07-07 5:08 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-07-06 21:27 [igt-dev] [PATCH i-g-t] tests/kms_cdclk: Minor fix Swati Sharma 2021-07-06 21:45 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork 2021-07-06 22:06 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork 2021-07-07 5:04 ` [igt-dev] [PATCH i-g-t] " Shankar, Uma 2021-07-07 5:08 ` Shankar, Uma
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.